feat: add option to disable logging for benchmarks

Author: michaelmior

src/bench_utils.rs

@@ -21,6 +21,9 @@ pub struct Args {
     #[arg(short, long, default_value_t = 30)]
     pub duration: u64,
 
+    #[arg(long, default_value_t = false)]
+    pub no_log: bool,
+
     #[cfg(feature = "profiling")]
     #[arg(long, default_value_t = false)]
     pub profile: bool,

src/bin/argusdb.rs

@@ -53,6 +53,10 @@ struct Args {
     #[arg(long)]
     index_threshold: Option<u64>,
 
+    /// Disable logging
+    #[arg(long, default_value_t = false)]
+    no_log: bool,
+
     /// Print help
     #[arg(long, action = clap::ArgAction::Help)]
     help: Option<bool>,
@@ -72,6 +76,8 @@ struct Settings {
     jstable_dir: String,
     #[serde(default = "default_index_threshold")]
     index_threshold: u64,
+    #[serde(default = "default_no_log")]
+    no_log: bool,
 }
 
 fn default_host() -> String {
@@ -98,6 +104,10 @@ fn default_index_threshold() -> u64 {
     1024
 }
 
+fn default_no_log() -> bool {
+    false
+}
+
 pub struct ArgusHandler {
     db: Arc<Mutex<DB>>,
 }
@@ -276,19 +286,28 @@ async fn main() {
             .set_override("index_threshold", index_threshold as i64)
             .unwrap();
     }
+    if args.no_log {
+        builder = builder.set_override("no_log", true).unwrap();
+    }
 
     let subscriber = tracing_subscriber::fmt()
         .with_max_level(Level::TRACE)
         .finish();
     tracing::subscriber::set_global_default(subscriber).unwrap();
     let settings: Settings = builder.build().unwrap().try_deserialize().unwrap();
 
+    let log_threshold = if settings.no_log {
+        None
+    } else {
+        Some(1024 * 1024)
+    };
+
     let db = Arc::new(Mutex::new(DB::new(
         &settings.jstable_dir,
         settings.memtable_threshold,
         settings.jstable_threshold,
         settings.index_threshold,
-        Some(1024 * 1024),
+        log_threshold,
     )));
     let handler = Arc::new(ArgusHandler::new(db));
     let processor = Arc::new(ArgusProcessor { handler });

src/bin/bench_runner.rs

@@ -50,7 +50,8 @@ async fn main() {
     let db_path = dir.path().to_str().unwrap();
     println!("Setting up DB at {}", db_path);
 
-    let db = Arc::new(Mutex::new(DB::new(db_path, 1000, 10, 1024, None)));
+    let log_threshold = if args.no_log { None } else { Some(1024 * 1024) };
+    let db = Arc::new(Mutex::new(DB::new(db_path, 1000, 10, 1024, log_threshold)));
 
     // 2. Load Data
     let data_dir = Path::new("workbook/data");

src/bin/bench_runner_server.rs

@@ -84,21 +84,27 @@ async fn main() {
     let host = "127.0.0.1";
 
     println!("Starting ArgusDB server on {}:{}", host, port);
-    let child = Command::new("./target/release/argusdb")
-        .args(&[
-            "--jstable-dir",
-            &db_path,
-            "--host",
-            host,
-            "--port",
-            &port.to_string(),
-            "--memtable-threshold",
-            "1000",
-            "--jstable-threshold",
-            "10",
-            "--index-threshold",
-            "1024",
-        ])
+    let mut command = Command::new("./target/release/argusdb");
+    command.args(&[
+        "--jstable-dir",
+        &db_path,
+        "--host",
+        host,
+        "--port",
+        &port.to_string(),
+        "--memtable-threshold",
+        "1000",
+        "--jstable-threshold",
+        "10",
+        "--index-threshold",
+        "1024",
+    ]);
+
+    if args.no_log {
+        command.arg("--no-log");
+    }
+
+    let child = command
         .stdout(Stdio::inherit())
         .stderr(Stdio::inherit())
         .spawn()