Drop Pytype support

Resolves #30

Author: davidfstr

.github/copilot-instructions.md

@@ -47,18 +47,17 @@ The validation logic uses a recursive pattern:
 
 Code contains extensive typechecker annotations:
 - `# type: ignore[error-code]` for mypy
-- `# pytype` for pytype
 - `# pyre` for pyre  
 - `# pyright` for pyright
 
-When adding features, test against all typecheckers: `make typecheck` runs mypy, pyright, pyre, and pytype.
+When adding features, test against all typecheckers: `make typecheck` runs mypy, pyright, and pyre.
 
 ## Development Workflows
 
 ### Testing Commands (Makefile)
 - `make test` - Run unittest against current Python version
 - `make testall` - Run tox across Python 3.9-3.13 (uses venv3.9/, venv3.10/, etc.)
-- `make typecheck` - Run all typecheckers (mypy, pyright, pyre, pytype)
+- `make typecheck` - Run all typecheckers (mypy, pyright, pyre)
 - `make format` - Format with black + isort
 - `make lint` - Check black/isort/flake8 compliance
 

Makefile

@@ -13,7 +13,6 @@ path := .
 
 # ex: "10.14.6" (if on macOS) or "" if not on macOS
 macos_version := $(shell which sw_vers > /dev/null 2>&1 && sw_vers -productVersion)
-pytype_path := $(shell which pytype)
 
 .PHONY: help
 help:  ## Show this help message.
@@ -65,7 +64,7 @@ flake:  ## Run flake8 linter.
 
 
 .PHONY: typecheck
-typecheck: mypy pyright pyre pytype  ## Run all typecheckers.
+typecheck: mypy pyright pyre  ## Run all typecheckers.
 
 
 .PHONY: mypy
@@ -89,15 +88,6 @@ pyre:
 endif
 
 
-.PHONY: pytype
-ifneq "$(pytype_path)" ""
-pytype:  ## Run pytype typechecker.
-	pytype --keep-going trycast/__init__.py tests.py
-else
-pytype:
-endif
-
-
 .PHONY: coverage
 coverage:  ## Generate code coverage report.
 	coverage run -m unittest

README.md

@@ -340,7 +340,6 @@ Trycast does type check successfully with the following type checkers:
 * [Mypy]
 * [Pyright] / [Pylance]
 * [Pyre]
-* [Pytype]
 
 
 ## API Reference
@@ -526,6 +525,8 @@ raised exceptions, and other details.
 
 * Drop support for Python 3.8.
     * Remove supporting code for Python 3.8's neutered TypedDict.
+* Drop support for Pytype type checker, since it has been 
+  [deprecated](https://github.com/google/pytype/blob/main/README.md).
 
 ### v1.2.1
 
@@ -605,7 +606,7 @@ raised exceptions, and other details.
     * trycast has been in production use for over a year
       at [at least one company] without issues.
     * trycast supports all major Python type checkers
-      (Mypy, Pyright/Pylance, Pyre, Pytype).
+      (Mypy, Pyright/Pylance, Pyre).
     * trycast's initial API is finalized.
 * Fix `coverage` to be a dev-dependency rather than a regular dependency.
 

benchmarks/data/http_request_parsing_example.py

@@ -1,7 +1,5 @@
 from typing import Literal, Mapping, Optional
-from typing import (
-    TypedDict as RichTypedDict,  # type: ignore[not-supported-yet]  # pytype
-)
+from typing import TypedDict as RichTypedDict
 
 
 # For test_http_request_parsing_example

poetry.lock

@@ -36,8 +36,6 @@ mypy = "*"
 mypy_extensions = "*"
 pyright = "*"
 pyre-check = "*"
-# NOTE: Duplicated in: [tool.tox] > legacy_tox_ini > [testenv] > deps
-pytype = { version = "==2024.04.11", python = ">=3.7.4,<3.10" }
 tox = ">=4.0.0,<5.0.0"
 black = "==24.3.0"
 isort = "^5.9.1"
@@ -73,7 +71,6 @@ profile = "black"
 atomic = true
 line_length = 88
 skip_glob = [
-    ".pytype",
     "test_data/forwardrefs_example*.py",
     "test_data/type_statement_example.py",
     "venv*",
@@ -94,7 +91,6 @@ isolated_build = True
 [testenv]
 deps =
     mypy
-    pytype == 2024.04.11 ; python_version < "3.10"
     typing-extensions >= 4.11.0rc1
 commands =
     python3 -m unittest

pyproject.toml

@@ -29,12 +29,8 @@
     Tuple,
     Type,
 )
-from typing import (
-    TypedDict as NativeTypedDict,  # type: ignore[not-supported-yet]  # pytype
-)
-from typing import (
-    TypedDict as RichTypedDict,  # type: ignore[not-supported-yet]  # pytype
-)
+from typing import TypedDict as NativeTypedDict
+from typing import TypedDict as RichTypedDict
 from typing import TypeVar, Union, cast
 from unittest import SkipTest, TestCase
 
@@ -74,9 +70,9 @@ def eval_type(x, y, z):
 
 # ParamSpec
 if sys.version_info >= (3, 13):
-    from typing import ParamSpec  # type: ignore[import-error]  # pytype
+    from typing import ParamSpec
 else:
-    from typing_extensions import ParamSpec  # type: ignore[not-supported-yet]  # pytype
+    from typing_extensions import ParamSpec
 
 _FAILURE = object()
 
@@ -1156,12 +1152,12 @@ def test_typeddict_required_notrequired(self) -> None:
             self.assertIs(typing.Required, typing_extensions.Required)  # type: ignore[16]  # pyre
             self.assertIs(typing.NotRequired, typing_extensions.NotRequired)  # type: ignore[16]  # pyre
 
-        class TotalMovie(typing_extensions.TypedDict):  # type: ignore[not-supported-yet]  # pytype
+        class TotalMovie(typing_extensions.TypedDict):
             title: str
-            year: typing_extensions.NotRequired[int]  # type: ignore[not-supported-yet]  # pytype
+            year: typing_extensions.NotRequired[int]
 
         class NontotalMovie(typing_extensions.TypedDict, total=False):
-            title: typing_extensions.Required[str]  # type: ignore[not-supported-yet]  # pytype
+            title: typing_extensions.Required[str]
             year: int
 
         # TotalMovie
@@ -1186,7 +1182,7 @@ def test_typeddict_readonly(self) -> None:
         if sys.version_info >= (3, 13):
             self.assertIs(typing.ReadOnly, typing_extensions.ReadOnly)  # type: ignore[attr-defined, 16]  # mypy, pyre
 
-        class Movie(typing_extensions.TypedDict):  # type: ignore[not-supported-yet]  # pytype
+        class Movie(typing_extensions.TypedDict):
             title: str
             year: int
 
@@ -1519,22 +1515,22 @@ def test_any(self) -> None:
     if sys.version_info >= (3, 11):
 
         def test_never(self) -> None:
-            self.assertTryCastFailure(Never, "words")  # type: ignore[wrong-arg-types]  # pytype
-            self.assertTryCastFailure(Never, 1)  # type: ignore[wrong-arg-types]  # pytype
-            self.assertTryCastFailure(Never, None)  # type: ignore[wrong-arg-types]  # pytype
-            self.assertTryCastFailure(Never, str)  # type: ignore[wrong-arg-types]  # pytype
+            self.assertTryCastFailure(Never, "words")
+            self.assertTryCastFailure(Never, 1)
+            self.assertTryCastFailure(Never, None)
+            self.assertTryCastFailure(Never, str)
 
-            self.assertTryCastFailure(Never, ValueError)  # type: ignore[wrong-arg-types]  # pytype
-            self.assertTryCastFailure(Never, ValueError())  # type: ignore[wrong-arg-types]  # pytype
+            self.assertTryCastFailure(Never, ValueError)
+            self.assertTryCastFailure(Never, ValueError())
 
     def test_noreturn(self) -> None:
-        self.assertTryCastFailure(NoReturn, "words")  # type: ignore[wrong-arg-types]  # pytype
-        self.assertTryCastFailure(NoReturn, 1)  # type: ignore[wrong-arg-types]  # pytype
-        self.assertTryCastFailure(NoReturn, None)  # type: ignore[wrong-arg-types]  # pytype
-        self.assertTryCastFailure(NoReturn, str)  # type: ignore[wrong-arg-types]  # pytype
+        self.assertTryCastFailure(NoReturn, "words")
+        self.assertTryCastFailure(NoReturn, 1)
+        self.assertTryCastFailure(NoReturn, None)
+        self.assertTryCastFailure(NoReturn, str)
 
-        self.assertTryCastFailure(NoReturn, ValueError)  # type: ignore[wrong-arg-types]  # pytype
-        self.assertTryCastFailure(NoReturn, ValueError())  # type: ignore[wrong-arg-types]  # pytype
+        self.assertTryCastFailure(NoReturn, ValueError)
+        self.assertTryCastFailure(NoReturn, ValueError())
 
     # === Forward References ===
 
@@ -1885,7 +1881,7 @@ class Point3D(Point2D, total=False):  # type: ignore[reportGeneralTypeIssues]  #
         if sys.version_info < (3, 9):
 
             def test_rejects_python_3_8_typeddict_when_strict_is_true(self) -> None:
-                class Point2D(typing.TypedDict):  # type: ignore[not-supported-yet]  # pytype
+                class Point2D(typing.TypedDict):
                     x: int
                     y: int
 
@@ -2884,16 +2880,14 @@ def _demands_a_str(value: str) -> str:
     #        self._demands_a_never(value)  # ensure typechecks
     #
     # @staticmethod
-    # def _demands_a_never(value: NoReturn) -> NoReturn:  # type: ignore[invalid-annotation]  # pytype
+    # def _demands_a_never(value: NoReturn) -> NoReturn:
     #    raise ValueError("expected this code to be unreachable")
 
 
 # ------------------------------------------------------------------------------
 # Internal: TestIsTypedDict
 
-from typing import (
-    TypedDict as TypingTypedDict,  # type: ignore[not-supported-yet]  # pytype
-)
+from typing import TypedDict as TypingTypedDict
 
 from trycast import _is_typed_dict
 
@@ -2903,9 +2897,7 @@ class TypingPoint(TypingTypedDict):
     y: int
 
 
-from typing_extensions import (
-    TypedDict as TypingExtensionsTypedDict,  # type: ignore[not-supported-yet]  # pytype
-)
+from typing_extensions import TypedDict as TypingExtensionsTypedDict
 
 
 class TypingExtensionsPoint(TypingExtensionsTypedDict):
@@ -2950,8 +2942,8 @@ def _tag(tag_name: str) -> Callable[[Callable[_P, _R]], Callable[_P, _R]]:  # ty
         $ TRYCAST_SKIP_TEST_TAGS=pyright,pyre python -m unittest
     """
 
-    def decorate(f: Callable[_P, _R]) -> Callable[_P, _R]:  # type: ignore[invalid-annotation]  # pytype
-        def decorated(*args: _P.args, **kwargs: _P.kwargs) -> _R:  # type: ignore[invalid-annotation]  # pytype
+    def decorate(f: Callable[_P, _R]) -> Callable[_P, _R]:
+        def decorated(*args: _P.args, **kwargs: _P.kwargs) -> _R:
             if tag_name in os.environ.get("TRYCAST_SKIP_TEST_TAGS", "").split(","):
                 raise SkipTest(f"skipping test tagged {tag_name}")
             return f(*args, **kwargs)
@@ -3012,23 +3004,5 @@ def test_no_pyre_typechecker_errors_exist(self) -> None:
 
             self.fail(f"pyre typechecking failed:\n\n{output_str}")
 
-    @_tag("pytype")
-    def test_no_pytype_typechecker_errors_exist(self) -> None:
-        try:
-            subprocess.check_output(
-                ["pytype", "--keep-going", "trycast/__init__.py", "tests.py"],
-                env={"LANG": "en_US.UTF-8", "PATH": os.environ.get("PATH", "")},
-                stderr=subprocess.STDOUT,
-            )
-        except subprocess.CalledProcessError as e:  # pragma: no cover
-            self.fail(
-                f'pytype typechecking failed:\n\n{e.output.decode("utf-8").strip()}'
-            )
-        except FileNotFoundError:
-            if sys.version_info >= (3, 10):
-                self.skipTest("Cannot run pytype on Python 3.10+")
-            else:  # pragma: no cover
-                raise
-
 
 # ------------------------------------------------------------------------------