fixup: check

Author: fizyk

mirakuru/base.py

@@ -143,9 +143,9 @@ def __init__(  # pylint:disable=too-many-arguments
             self.command_parts = shlex.split(command)
 
         self._cwd = cwd
-        self._shell = True
-        if not IS_WINDOWS:
-            self._shell = shell
+        self._shell = shell
+        # if not IS_WINDOWS:
+        #     self._shell = shell
 
         self._timeout = timeout
         self._sleep = sleep

tests/executors/test_executor.py

@@ -2,7 +2,6 @@
 """Test basic executor functionality."""
 
 import gc
-import platform
 import shlex
 import signal
 import uuid
@@ -109,56 +108,22 @@ def test_context_stopped() -> None:
 
 
 @pytest.mark.parametrize("command", (ECHO_FOOBAR, shlex.split(ECHO_FOOBAR)))
-@pytest.mark.parametrize(
-    "expected_output",
-    (
-        pytest.param(
-            "foobar\n",
-            marks=pytest.mark.skipif(
-                platform.system() == "Windows", reason="Windows leaves quotes"
-            ),
-        ),
-        pytest.param(
-            '"foobar"\n',
-            marks=pytest.mark.skipif(
-                platform.system() != "Windows", reason="Windows leaves quotes"
-            ),
-        ),
-    ),
-)
-def test_process_output(command: Union[str, List[str]], expected_output: str) -> None:
+def test_process_output(command: Union[str, List[str]]) -> None:
     """Start a process, check output and shut it down."""
     executor = SimpleExecutor(command)
     executor.start()
 
-    assert executor.output().read() == expected_output, f"command was {command!r}"
+    assert executor.output().read() == "foobar\n", f"command was {command!r}"
     executor.stop()
 
 
 @pytest.mark.parametrize("command", (ECHO_FOOBAR, shlex.split(ECHO_FOOBAR)))
-@pytest.mark.parametrize(
-    "expected_output",
-    (
-        pytest.param(
-            "foobar",
-            marks=pytest.mark.skipif(
-                platform.system() == "Windows", reason="Windows leaves quotes"
-            ),
-        ),
-        pytest.param(
-            '"foobar"',
-            marks=pytest.mark.skipif(
-                platform.system() != "Windows", reason="Windows leaves quotes"
-            ),
-        ),
-    ),
-)
-def test_process_output_shell(command: Union[str, List[str]], expected_output: str) -> None:
+def test_process_output_shell(command: Union[str, List[str]]) -> None:
     """Start a process, check output and shut it down with shell set to True."""
     executor = SimpleExecutor(command, shell=True)
     executor.start()
 
-    assert executor.output().read().strip() == expected_output, f"command was {command!r}"
+    assert executor.output().read().strip() == "foobar", f"command was {command!r}"
     executor.stop()