Skip to content

Commit b9e9b02

Browse files
committed
Fix remaining CI issues
- Remove lcov dependency from coverage report (we use gcov directly) - Comment out Codecov upload for now (requires lcov format) - Simplify coverage reporting in CI to work with our gcov-based script
1 parent e2237ca commit b9e9b02

File tree

1 file changed

+13
-11
lines changed

1 file changed

+13
-11
lines changed

.github/workflows/ci.yml

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -49,22 +49,24 @@ jobs:
4949
- name: Generate coverage report
5050
if: matrix.os == 'ubuntu-latest' && matrix.compiler == 'gcc'
5151
run: |
52-
sudo apt-get update
53-
sudo apt-get install -y lcov
5452
make coverage
5553
echo "## Coverage Summary" >> $GITHUB_STEP_SUMMARY
5654
echo '```' >> $GITHUB_STEP_SUMMARY
57-
lcov --summary coverage/coverage.info >> $GITHUB_STEP_SUMMARY 2>&1
55+
# Our coverage script uses gcov directly and outputs to console
56+
# Capture the last part of the output for the summary
57+
make coverage 2>&1 | tail -20 >> $GITHUB_STEP_SUMMARY
5858
echo '```' >> $GITHUB_STEP_SUMMARY
5959
60-
- name: Upload coverage to Codecov
61-
if: matrix.os == 'ubuntu-latest' && matrix.compiler == 'gcc'
62-
uses: codecov/codecov-action@v3
63-
with:
64-
file: ./coverage/coverage.info
65-
flags: unittests
66-
name: codecov-umbrella
67-
fail_ci_if_error: false
60+
# Codecov upload disabled for now - our coverage script uses gcov directly
61+
# not lcov format. Could be re-enabled if we switch to lcov.
62+
#- name: Upload coverage to Codecov
63+
# if: matrix.os == 'ubuntu-latest' && matrix.compiler == 'gcc'
64+
# uses: codecov/codecov-action@v3
65+
# with:
66+
# file: ./coverage/coverage.info
67+
# flags: unittests
68+
# name: codecov-umbrella
69+
# fail_ci_if_error: false
6870

6971
cross-compile:
7072
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)