From d3d3e8de32f699b83a008c0eb61bd845ce7848e2 Mon Sep 17 00:00:00 2001 From: Alhoussein <84826294+alhss@users.noreply.github.com> Date: Mon, 17 Nov 2025 21:00:54 +0000 Subject: [PATCH] removed handling two data types from API --- updater/lib/dependabot/pull_request.rb | 11 +++-------- updater/spec/dependabot/pull_request_spec.rb | 20 -------------------- 2 files changed, 3 insertions(+), 28 deletions(-) diff --git a/updater/lib/dependabot/pull_request.rb b/updater/lib/dependabot/pull_request.rb index 5c99b747362..8fd1affb104 100644 --- a/updater/lib/dependabot/pull_request.rb +++ b/updater/lib/dependabot/pull_request.rb @@ -81,16 +81,11 @@ def normalize_directory(directory) sig { params(attributes: T::Hash[Symbol, T.untyped]).returns(T::Array[Dependabot::PullRequest]) } def self.create_from_job_definition(attributes) attributes.fetch(:existing_pull_requests).map do |pr| - case pr - when Array - pr_number = pr.first["pr-number"] - when Hash - pr_number = pr["pr-number"] - pr = pr["dependencies"] # now pr becomes the dependencies array from the pr - end + pr_number = pr["pr-number"] + deps = pr["dependencies"] dependencies = - pr.map do |dep| + deps.map do |dep| PullRequest::Dependency.new( name: dep.fetch("dependency-name"), version: dep.fetch("dependency-version", nil), diff --git a/updater/spec/dependabot/pull_request_spec.rb b/updater/spec/dependabot/pull_request_spec.rb index 479db7e38e3..12aeff2a804 100644 --- a/updater/spec/dependabot/pull_request_spec.rb +++ b/updater/spec/dependabot/pull_request_spec.rb @@ -10,26 +10,6 @@ [[{ "dependency-name" => "foo", "dependency-version" => "1.0.0", "directory" => "/", "pr-number" => 123 }]] end - it "can properly handle when each PR from the job is an array" do - pr2 = described_class.create_from_job_definition( # ← Fix: Correct method call - existing_pull_requests: existing_pull_requests - ) - pr2 = pr2.first # get the first PR from the array - - pr1 = described_class.new( - [ - Dependabot::PullRequest::Dependency.new( - name: "foo", - version: "1.0.0", - directory: "/" - ) - ], - pr_number: 123 - ) - expect(pr2.pr_number).to eq(123) - expect(pr2).to eq(pr1) - end - it "can properly handle when each PR is a hash and dependencies object is present" do existing_pull_requests = [{ "pr-number" => 123,