Skip to content

Commit 2809b56

Browse files
authored
Release v2.10.1
2 parents caeb963 + f5ddc83 commit 2809b56

File tree

5 files changed

+41
-3
lines changed

5 files changed

+41
-3
lines changed

.github/workflows/npm_publish.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ on:
33
types: [released]
44
jobs:
55
publish:
6+
environment: release
67
runs-on: ubuntu-latest
78
steps:
89
- uses: actions/checkout@v2

.github/workflows/post_check_svgs_comment.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353

5454
- name: Comment on the PR about the result - SVG Error
5555
uses: jungwinter/comment@v1 # let us comment on a specific PR
56-
if: success() && (steps.err_message_reader.outputs.content != '0' || steps.err_message_reader.outputs.content != '1')
56+
if: success() && (steps.err_message_reader.outputs.content != '0' && steps.err_message_reader.outputs.content != '1')
5757
env:
5858
MESSAGE: |
5959
Hi!

CONTRIBUTING.md

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ First of all, thanks for taking the time to contribute! This project can only gr
1313
<li><a href="#updateDevicon">Updating the <code>devicon.json</code></a></li>
1414
<li><a href="#example">Example</a></li>
1515
<li><a href="#requestingIcon">Requesting An Icon</a></li>
16+
<li><a href="#teams">Maintainer/Reviewer/Teams</a></li>
1617
<li><a href="#buildScript">Regarding the Build Script</a></li>
1718
</ul>
1819

@@ -247,6 +248,42 @@ As an example, let's assume you have created the svgs for Redhat and Amazon Web
247248
<li>Optional: include links where the icon can be found</li>
248249
</ul>
249250

251+
<hr>
252+
<h2 id='teams'>Maintainer/Reviewer/Teams</h2>
253+
<p>
254+
Devicon is living by it's contributors and <a href="https://github.com/orgs/devicons/people">maintainers</a>. Everyone can and is asked to contribute to this project.
255+
You <b>don't</b> have to be in a team to contribute!
256+
</p>
257+
<p>
258+
The branches <code>master</code> and <code>develop</code> are protected branches and only members
259+
with corresponding permissions (see teams below) are able to push changes to them.
260+
Additional branches <b>must</b> follow the pattern <code><i>username</i>/feature/<i>description</i></code>.
261+
The <code>/feature/</code> indicates that a change is made to existing code (regardless
262+
if it's a fix, refactor or actual feature). The naming convention is based on the <i>gitflow</i>-workflow.
263+
</p>
264+
<p>For organisational purposes we introduced <a href="https://github.com/orgs/devicons/teams">teams</a> with permissions and responsibilities:</p>
265+
<dl>
266+
<dt>Supporter (@devicons/supporter)</dt>
267+
<dd>
268+
Members of this team are responsible for reviewing pull request (auto assigned), managing issues and preparing the upcoming release.<br />
269+
Supporters have <code>Write</code> access to the repository (allowing them to create own branches)
270+
and are allowed to push changes to the <code>develop</code> branch (pull request and status checks required).
271+
</dd>
272+
<dt>Maintainer (@devicons/maintainer)</dt>
273+
<dd>
274+
Maintainer role inherits from the 'Supporter' role and adds <code>Maintainer</code> permission
275+
to the repository.
276+
Members of this team are allowed to publish a new release (push <code>master</code> branch after pull
277+
request and status checks).
278+
</dd>
279+
</dl>
280+
<p>
281+
Wanna join the team? Please <a href="https://github.com/devicons/devicon/discussions/new">open a public discussion</a> where
282+
you introduce yourself.<br />
283+
New member requests have to be approved by all active members of the team <b>Maintainer</b>. Every member
284+
of this team has a veto permission to reject a new member.<br />
285+
</p>
286+
250287
<hr>
251288
<h2 id='buildScript'>Regarding The Build Script</h2>
252289
<p>To make adding icons easier for repo maintainers, we rely on GitHub Actions, Python, Selenium, and Gulp to automate our tasks.</p>

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ Add css rules in your stylesheet
151151

152152
<h2 id="contribute">Contributing</h2>
153153
<p>
154-
We are happy for every contribution. Please have a look at our <a href="CONTRIBUTING.md#overview-on-submitting-icons">contribution guidelines</a>
154+
We are happy for every contribution. Please have a look at our <a href="CONTRIBUTING.md">contribution guidelines</a>
155155
to see how you can contribute to this project.
156156
</p>
157157

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "devicon",
3-
"version": "2.10.0",
3+
"version": "2.10.1",
44
"description": "Programming related icons collection",
55
"main": "devicon.min.css",
66
"scripts": {

0 commit comments

Comments
 (0)