Voice channels regarding bugs

[Qrix]

Environment

• PHP Version:
  • 8.2.3
• DiscordPHP Version:
  • 10.45 and 10.45.11

I see many bugs with not working Voice Channel status

$interaction->member->getVoiceChannel()

always returns null. Also events from VOICE_STATE_UPDATE:

$discord->on(Event::VOICE_STATE_UPDATE, function (VoiceStateUpdate $state, Discord $discord, $oldstate){
 var_dump($oldstate); //always null
}

[valzargaming]

Old state missing should be fixed now with 109bacb and v10.45.12

[valzargaming]

The getVoiceChannel method cycles through the guild's voice channels found in the member's server to find which one the member is in.

/**
 * Returns the voicechannel of the member.
 *
 * @return Channel|null
 */
public function getVoiceChannel(): ?Channel
{
    if ($guild = $this->guild) {
        return $guild->channels->find(function (Channel $channel) {
            if ($channel->isVoiceBased() && $members = $channel->members) {
                return $members->offsetExists($this->id);
            }

            return false;
        });
    }

    return null;
}

I think the problem might be with how the members collection in the channel is being generated.

public function getMembersAttribute(): ExCollectionInterface
{
    if ($guild = $this->guild) {
        return $guild->voice_states->filter(fn (VoiceStateUpdate $voice_state) => $voice_state->channel_id === $this->id);
    }

    /** @var ExCollectionInterface<VoiceStateUpdate> */
    return $this->discord->getCollectionClass()::for(VoiceStateUpdate::class, 'user_id');
}

I couldn't immediately find anything that might indicate what the issue is, so please let me know if you have any data indicating where a variable doesn't match what's expected.

[valzargaming]

I think the root cause of the issue was fixed in 65119ef and v10.45.13. The repository did not have a discriminator set, so the getMembersAttribute method was unable to locate anything by the user_id.

[Qrix]

10.45.13:

Warning: Undefined array key "user" in /usr/src/discord/vendor/team-reflex/discord-php/src/Discord/Discord.php on line 980

Fatal error: Uncaught TypeError: Discord\Repository\AbstractRepository::create(): Argument #1 ($attributes) must be of type object|array, null given, called in /usr/src/discord/vendor/team-reflex/discord-php/src/Discord/Discord.php on line 980 and defined in /usr/src/discord/vendor/team-reflex/discord-php/src/Discord/Repository/AbstractRepositoryTrait.php:162
Stack trace:
#0 /usr/src/discord/vendor/team-reflex/discord-php/src/Discord/Discord.php(980): Discord\Repository\AbstractRepository->create(NULL, true)
#1 /usr/src/discord/vendor/team-reflex/discord-php/src/Discord/Discord.php(892): Discord\Discord->handleGuildMembersChunk(Object(Discord\WebSockets\Payload))
#2 /usr/src/discord/vendor/team-reflex/discord-php/src/Discord/Discord.php(791): Discord\Discord->handleDispatch(Object(stdClass))
#3 /usr/src/discord/vendor/team-reflex/discord-php/src/Discord/Discord.php(745): Discord\Discord->processWsMessage('{"t":"GUILD_MEM...')
#4 /usr/src/discord/vendor/evenement/evenement/src/EventEmitterTrait.php(143): Discord\Discord->handleWsMessage(Object(Ratchet\RFC6455\Messaging\Message), Object(Ratchet\Client\WebSocket))
#5 /usr/src/discord/vendor/ratchet/pawl/src/WebSocket.php(72): Ratchet\Client\WebSocket->emit('message', Array)
#6 /usr/src/discord/vendor/ratchet/rfc6455/src/Messaging/MessageBuffer.php(233): Ratchet\Client\WebSocket->Ratchet\Client\{closure}(Object(Ratchet\RFC6455\Messaging\Message), Object(Ratchet\RFC6455\Messaging\MessageBuffer))
#7 /usr/src/discord/vendor/ratchet/rfc6455/src/Messaging/MessageBuffer.php(179): Ratchet\RFC6455\Messaging\MessageBuffer->processData('\x82\x7F\x00\x00\x00\x00\x00\x01B\xA4\xEC\xBD[o\\...')
#8 /usr/src/discord/vendor/evenement/evenement/src/EventEmitterTrait.php(143): Ratchet\RFC6455\Messaging\MessageBuffer->onData('\x82\x7F\x00\x00\x00\x00\x00\x01B\xA4\xEC\xBD[o\\...')
#9 /usr/src/discord/vendor/react/stream/src/Util.php(71): Evenement\EventEmitter->emit('data', Array)
#10 /usr/src/discord/vendor/evenement/evenement/src/EventEmitterTrait.php(143): React\Stream\Util::React\Stream\{closure}('\x88L\x86M\xE79\xB7LI\x01j\xC0X\x1D\xE4...')
#11 /usr/src/discord/vendor/react/stream/src/DuplexResourceStream.php(209): Evenement\EventEmitter->emit('data', Array)
#12 /usr/src/discord/vendor/react/event-loop/src/StreamSelectLoop.php(246): React\Stream\DuplexResourceStream->handleData(Resource id #264)
#13 /usr/src/discord/vendor/react/event-loop/src/StreamSelectLoop.php(213): React\EventLoop\StreamSelectLoop->waitForStreamActivity(860026)
#14 /usr/src/discord/vendor/team-reflex/discord-php/src/Discord/Discord.php(1819): React\EventLoop\StreamSelectLoop->run()
#15 /usr/src/discord/bot.php(250): Discord\Discord->run()
#16 {main}
  thrown in /usr/src/discord/vendor/team-reflex/discord-php/src/Discord/Repository/AbstractRepositoryTrait.php on line 162

but I applied 65119ef and 109bacb to version 10.45.11 and looks that is ok

[valzargaming]

Thanks! That should be fixed with v10.45.14