Add OCI artifact wrapper for spec-compliant manifest with artifactType #1633
+113
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce artifactImage wrapper that injects the artifactType field and replaces the config blob with the OCI empty descriptor, since go-containerregistry's v1.Manifest struct does not support artifactType. Push now wraps images with NewArtifactImage so pushed manifests include artifactType (application/vnd.docker.cagent.config.v1+json) and an empty config descriptor per the OCI image spec guidelines for artifact usage. Assisted-By: cagent
Member
Author
|
@jcarter3 Would that fix the issue? |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review Summary
✅ No issues found
This PR correctly implements an OCI artifact wrapper that injects the artifactType field into manifests. The implementation:
- Properly uses
json.RawMessagefor pre-encoded JSON handling - Correctly overrides manifest-related methods while preserving config and layers
- Has good test coverage verifying the artifactType injection and preservation of base image properties
- Follows Go best practices with appropriate error handling
The code is well-designed and production-ready.
krissetto
approved these changes
Feb 7, 2026
Contributor
|
@dgageot That fixes the artifact type issues, yes! The layers are still showing as tar.gzip though, when they are just plain yaml files. So that part still needs fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1508
Introduce artifactImage wrapper that injects the artifactType field and replaces the config blob with the OCI empty descriptor, since go-containerregistry's v1.Manifest struct does not support artifactType.
Push now wraps images with NewArtifactImage so pushed manifests include artifactType (application/vnd.docker.cagent.config.v1+json) and an empty config descriptor per the OCI image spec guidelines for artifact usage.
Assisted-By: cagent