Skip to content

Update .NET guide to .NET 10#23729

Open
brandonh6k wants to merge 7 commits intodocker:mainfrom
brandonh6k:main
Open

Update .NET guide to .NET 10#23729
brandonh6k wants to merge 7 commits intodocker:mainfrom
brandonh6k:main

Conversation

@brandonh6k
Copy link
Contributor

Description

Errr... I updated the .NET guide to 10. 😆

Related issues or tickets

The sample .NET repo has a PR as well - docker/docker-dotnet-sample#9

Reviews

  • Technical review
  • Editorial review
  • Product review

@netlify
Copy link

netlify bot commented Nov 17, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 203f207
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/69861a4f54608f0008c8d02a
😎 Deploy Preview https://deploy-preview-23729--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brandonh6k. It looks like the v10 DHI images just dropped. Suggest updating to those, or somehow make sure the v9 build will work with the updated sample app.

@brandonh6k
Copy link
Contributor Author

@craig-osterhout Thanks for the review. I've pushed a new change to the guide that incorporates all of those changes. Also, I extended the DHI tabbing through the rest of the guide (the Develop and Run Test pages) for consistency.

@craig-osterhout
Copy link
Contributor

Thanks @brandonh6k. Sorry, we had to quietly pause all reviews/changes for the surprise DHI free updates. Can you help update this based on that?
Essentially, for DHI, mirroring is no longer required, and users can directly use the public images at dhi.io/<image>:<tag> as long as they authenticate.

Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as changes requested.

@craig-osterhout
Copy link
Contributor

/review

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation Review Summary

Reviewed the .NET 10 update and DHI integration changes. Found one unrelated change that should be removed.

Issues Found

  • HIGH: Unrelated .gitignore changes should be removed

The documentation updates for .NET 10 and Docker Hardened Images look good overall. The content is clear, accurate, and follows the established patterns.

@brandonh6k
Copy link
Contributor Author

Addressed Reviewer Bot comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants