Address review comments

Author: roji

src/EFCore.SqlServer/Extensions/SqlServerEntityTypeBuilderExtensions.cs

@@ -330,7 +330,7 @@ public static bool CanSetIsTemporal(
     /// <param name="name">The name to assign to the index.</param>
     /// <returns>A builder to further configure the vector index.</returns>
     [Experimental(EFDiagnostics.SqlServerVectorSearch)]
-    public static VectorIndexBuilder<TEntity> HasVectorIndex<TEntity>(
+    public static SqlServerVectorIndexBuilder<TEntity> HasVectorIndex<TEntity>(
         this EntityTypeBuilder<TEntity> entityTypeBuilder,
         Expression<Func<TEntity, object?>> indexExpression,
         string metric,
@@ -345,7 +345,7 @@ public static VectorIndexBuilder<TEntity> HasVectorIndex<TEntity>(
             : entityTypeBuilder.HasIndex(indexExpression, name);
         indexBuilder.Metadata.SetVectorMetric(metric);
 
-        return new VectorIndexBuilder<TEntity>(indexBuilder);
+        return new SqlServerVectorIndexBuilder<TEntity>(indexBuilder);
     }
 
     /// <summary>
@@ -381,7 +381,7 @@ public static VectorIndexBuilder<TEntity> HasVectorIndex<TEntity>(
     /// <param name="name">The name to assign to the index.</param>
     /// <returns>A builder to further configure the vector index.</returns>
     [Experimental(EFDiagnostics.SqlServerVectorSearch)]
-    public static VectorIndexBuilder HasVectorIndex(
+    public static SqlServerVectorIndexBuilder HasVectorIndex(
         this EntityTypeBuilder entityTypeBuilder,
         string propertyName,
         string metric,
@@ -395,7 +395,7 @@ public static VectorIndexBuilder HasVectorIndex(
             : entityTypeBuilder.HasIndex(propertyName, name);
         indexBuilder.Metadata.SetVectorMetric(metric);
 
-        return new VectorIndexBuilder(indexBuilder);
+        return new SqlServerVectorIndexBuilder(indexBuilder);
     }
 
     /// <summary>

…/Metadata/Builders/VectorIndexBuilder.cs …/Builders/SqlServerVectorIndexBuilder.cssrc/EFCore.SqlServer/Metadata/Builders/VectorIndexBuilder.cs renamed to src/EFCore.SqlServer/Metadata/Builders/SqlServerVectorIndexBuilder.cs src/EFCore.SqlServer/Metadata/Builders/VectorIndexBuilder.cs renamed to src/EFCore.SqlServer/Metadata/Builders/SqlServerVectorIndexBuilder.cs

@@ -15,7 +15,7 @@ namespace Microsoft.EntityFrameworkCore.Metadata.Builders;
 /// </remarks>
 /// <param name="indexBuilder">The index builder.</param>
 [Experimental(EFDiagnostics.SqlServerVectorSearch)]
-public class VectorIndexBuilder(IndexBuilder indexBuilder)
+public class SqlServerVectorIndexBuilder(IndexBuilder indexBuilder)
 {
     /// <summary>
     ///     The index being configured.
@@ -31,7 +31,7 @@ public virtual IMutableIndex Metadata
     /// </remarks>
     /// <param name="name">The name of the index.</param>
     /// <returns>A builder to further configure the index.</returns>
-    public virtual VectorIndexBuilder HasDatabaseName(string? name)
+    public virtual SqlServerVectorIndexBuilder HasDatabaseName(string? name)
     {
         Metadata.SetDatabaseName(name);
 
@@ -48,7 +48,7 @@ public virtual VectorIndexBuilder HasDatabaseName(string? name)
     /// </remarks>
     /// <param name="metric">The similarity metric for the vector index (e.g. "cosine", "euclidean", "dot").</param>
     /// <returns>A builder to further configure the vector index.</returns>
-    public virtual VectorIndexBuilder UseMetric(string metric)
+    public virtual SqlServerVectorIndexBuilder UseMetric(string metric)
     {
         Check.NotEmpty(metric);
 
@@ -67,7 +67,7 @@ public virtual VectorIndexBuilder UseMetric(string metric)
     /// </remarks>
     /// <param name="type">The type of the vector index (e.g. "DiskANN").</param>
     /// <returns>A builder to further configure the vector index.</returns>
-    public virtual VectorIndexBuilder UseType(string? type)
+    public virtual SqlServerVectorIndexBuilder UseType(string? type)
     {
         Metadata.SetVectorIndexType(type);
 

…etadata/Builders/VectorIndexBuilder`1.cs …uilders/SqlServerVectorIndexBuilder`1.cssrc/EFCore.SqlServer/Metadata/Builders/VectorIndexBuilder`1.cs renamed to src/EFCore.SqlServer/Metadata/Builders/SqlServerVectorIndexBuilder`1.cs src/EFCore.SqlServer/Metadata/Builders/VectorIndexBuilder`1.cs renamed to src/EFCore.SqlServer/Metadata/Builders/SqlServerVectorIndexBuilder`1.cs

@@ -20,7 +20,7 @@ namespace Microsoft.EntityFrameworkCore.Metadata.Builders;
 /// </seealso>
 /// <seealso href="https://learn.microsoft.com/sql/relational-databases/vectors/vectors-sql-server">Vectors in the SQL Database Engine.</seealso>
 [Experimental(EFDiagnostics.SqlServerVectorSearch)]
-public class VectorIndexBuilder<TEntity>(IndexBuilder<TEntity> indexBuilder)
+public class SqlServerVectorIndexBuilder<TEntity>(IndexBuilder<TEntity> indexBuilder)
 {
     /// <summary>
     ///     The index being configured.
@@ -36,7 +36,7 @@ public virtual IMutableIndex Metadata
     /// </remarks>
     /// <param name="name">The name of the index.</param>
     /// <returns>A builder to further configure the index.</returns>
-    public virtual VectorIndexBuilder<TEntity> HasDatabaseName(string? name)
+    public virtual SqlServerVectorIndexBuilder<TEntity> HasDatabaseName(string? name)
     {
         Metadata.SetDatabaseName(name);
 
@@ -53,7 +53,7 @@ public virtual VectorIndexBuilder<TEntity> HasDatabaseName(string? name)
     /// </remarks>
     /// <param name="metric">The similarity metric for the vector index (e.g. "cosine", "euclidean", "dot").</param>
     /// <returns>A builder to further configure the vector index.</returns>
-    public virtual VectorIndexBuilder<TEntity> UseMetric(string metric)
+    public virtual SqlServerVectorIndexBuilder<TEntity> UseMetric(string metric)
     {
         Check.NotEmpty(metric);
 
@@ -72,7 +72,7 @@ public virtual VectorIndexBuilder<TEntity> UseMetric(string metric)
     /// </remarks>
     /// <param name="type">The type of the vector index (e.g. "DiskANN").</param>
     /// <returns>A builder to further configure the vector index.</returns>
-    public virtual VectorIndexBuilder<TEntity> UseType(string? type)
+    public virtual SqlServerVectorIndexBuilder<TEntity> UseType(string? type)
     {
         Metadata.SetVectorIndexType(type);