Add ICssHotReloadServiceFactory#9859
Merged
LittleLittleCloud merged 3 commits intomainfrom Nov 21, 2025
Merged
Conversation
tmat
reviewed
Nov 20, 2025
...VisualStudio.ProjectSystem.Managed/ProjectSystem/HotReload/Contracts/ICssHotReloadService.cs
Outdated
Show resolved
Hide resolved
tmat
approved these changes
Nov 20, 2025
drewnoakes
approved these changes
Nov 21, 2025
Member
drewnoakes
left a comment
drewnoakes
left a comment
There was a problem hiding this comment.
Approving, but I would suggest you first experiment with using an ExportFactory<T> on the consumption side instead of merging this PR. It'd avoid needing a new public interface, and using ExportFactory<T> is likely more flexible.
You can import ExportFactory<ICssHotReloadService> via MEF (just as you would import ICssHotReloadServiceFactory) then call CreateExport() on it to get an ExportLifetimeContext<ICssHotReloadServiceFactory> which you can then use the Value of, and Dispose it when you're done.
Member
|
Oh I didn't see it was set to auto complete... |
LittleLittleCloud
added a commit
that referenced
this pull request
Nov 24, 2025
This reverts commit 23b56a2.
LittleLittleCloud
added a commit
that referenced
this pull request
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generally, we only want to active ICssHotReloadService when there's a debug session. So
Therefore this PR adds a
ICssHotReloadServiceFactoryas a MEF component to create ICssHotReloadService. TheICssHotReloadServiceFactory's lifetime will be the same as PS host. And the lifetime management ofICssHotReloadServicewill belong to the owner class who createsICssHotReloadService