Cache hook policy in handler to avoid per-turn workspace reloads

Author: drpedapati

pkg/agent/loop.go

@@ -231,7 +231,7 @@ func NewAgentLoop(cfg *config.Config, msgBus *bus.MessageBus, provider providers
 	hookDispatcher = hooks.NewDispatcher(auditSink)
 	if hookPolicy.Enabled || hookPolicyErr != nil {
 		provenanceHandler := &builtin.ProvenanceHandler{}
-		policyHandler := builtin.NewPolicyHandler(workspace)
+		policyHandler := builtin.NewPolicyHandler(hookPolicy, hookDiag, hookPolicyErr)
 		if hookPolicyErr != nil {
 			for _, ev := range hooks.KnownEvents() {
 				hookDispatcher.Register(ev, provenanceHandler)

pkg/hooks/builtin/policy.go

@@ -2,47 +2,62 @@ package builtin
 
 import (
 	"context"
+	"errors"
 
 	"github.com/sipeed/picoclaw/pkg/hookpolicy"
 	"github.com/sipeed/picoclaw/pkg/hooks"
 )
 
 // PolicyHandler applies workspace hook policy (HOOKS.md + hooks.yaml).
 type PolicyHandler struct {
-	workspace string
+	policy   hookpolicy.Policy
+	warnings []string
+	loadErr  error
 }
 
-func NewPolicyHandler(workspace string) *PolicyHandler {
-	return &PolicyHandler{workspace: workspace}
+func NewPolicyHandler(policy hookpolicy.Policy, diag hookpolicy.Diagnostics, loadErr error) *PolicyHandler {
+	warnings := make([]string, 0, len(diag.Warnings))
+	warnings = append(warnings, diag.Warnings...)
+	return &PolicyHandler{
+		policy:   policy,
+		warnings: warnings,
+		loadErr:  loadErr,
+	}
 }
 
 func (h *PolicyHandler) Name() string {
 	return "policy"
 }
 
 func (h *PolicyHandler) Handle(_ context.Context, ev hooks.Event, data hooks.Context) hooks.Result {
-	policy, diag, err := hookpolicy.LoadPolicy(h.workspace)
-	if err != nil {
+	if h.loadErr != nil {
 		return hooks.Result{
 			Status:  hooks.StatusError,
 			Message: "failed to load hook policy",
-			Err:     err,
+			Err:     h.loadErr,
+		}
+	}
+	if h.policy.Events == nil {
+		return hooks.Result{
+			Status:  hooks.StatusError,
+			Message: "hook policy missing event configuration",
+			Err:     errors.New("hook policy events are not initialized"),
 		}
 	}
 
 	meta := map[string]any{
-		"policy_enabled": policy.Enabled,
+		"policy_enabled": h.policy.Enabled,
 		"turn_id":        data.TurnID,
 	}
-	if len(diag.Warnings) > 0 {
-		meta["warnings"] = diag.Warnings
+	if len(h.warnings) > 0 {
+		meta["warnings"] = h.warnings
 	}
 
-	if !policy.Enabled {
+	if !h.policy.Enabled {
 		return hooks.Result{Status: hooks.StatusOK, Message: "hooks disabled by policy", Metadata: meta}
 	}
 
-	eventPolicy, ok := policy.Events[ev]
+	eventPolicy, ok := h.policy.Events[ev]
 	if !ok {
 		return hooks.Result{Status: hooks.StatusOK, Message: "event not configured", Metadata: meta}
 	}