Exporting diagram with validation markers to svg throws error

[jmenzies12]

Hey there,

We extended the AbstractModelValidator.doLiveValidation in order to add validation markers to our diagram nodes based on validations from our Langium document. This worked fine.

However, we've ran into a bit of a weird issue when exporting to SVG, it triggers computedBounds on export, which tries to compute the bounds for the validation marker using the ID, however it cannot find the validation marker id in the model index. From what I can see the markers returned from doLiveValidation get given a new ID that is not contained in the model index.

Just wanted to check if we were doing something wrong when adding the validation markers? Or if maybe this is a bug with the SVG export?

Interestingly the position of the marker ends up inside the node in the export vs outside in the editor (but maybe this is just because of the computedBounds failure). See below:

vs

Cheers
Jonathan

[tortmayr]

@jmenzies12
Sorry for the late reply, somehow we missed this discussion.

I had a quick look at this issue and it seems like this is a bug in the base GLSP framework.

1. When exporting an SVG the diagram layout is recomputed locally. Somewho the corresponding ComputedBoundsAction is sent to the server, which should not happen.
2. I can reproduce the issue with the incorrect styling of the issue markers. We have to investigate why this style is not properly propagated to the exported svg.

[tortmayr]

Bug is fixed with eclipse-glsp/glsp-client#451

[jmenzies12]

No worries! The fix looks good to me, thanks for sorting that out.