Query on Monitor-Specific UI Rescaling from SWT point of view introduced in 4.34

[deepika-u]

I see that there is a monitor specific UI scaling feature that was introduced in Eclipse 4.34(from platform UI - eclipse-platform/eclipse.platform.ui#2461). I wanted to take a look at the core implementation behind this feature(specific to SWT) for a requirement for one of my clients, but I haven’t been able to locate the original pull request where it was implemented. Although I could find the umbrella bug(#1961) related to HiDPI support, the actual PR containing the core changes isn’t obvious. Will you be able to redirect me to that particular PR which has the core implementation behind this feature.

[HeikoKlare]

The implementation of that feature consists of hundreds of PRs. It was incrementally implemented and integrated with the use of a feature toggle.
The best source of information is probably the recently added feature documentation.

[deepika-u]

Thanks alot, in case if i have specific query on this i shall get back to you.

[deepika-u]

@HeikoKlare
Thanks for your quick answer. We went though the doc indetail.
From the doc you have shared, what we understand is HiDPi support is implemented in 2 phases:

1. The first one being focused on rendering a sharp UI only on primary screen. This change targeted only on the primary monitor when starting up which is the HiDPi support itself.

2. The second phase is Monitor specific UI scaling which is extended support on the first one that handles runtime DPI changes not just in primary monitor but across different monitors automatically when switched between monitors.

From the bug report, it appears that basic HiDPI support (feature 1) was already implemented in Eclipse 4.4 at least partially (https://bugs.eclipse.org/bugs/show_bug.cgi?id=474252). so in that way 4.31 already includes this initial HiDPI support. What is missing in 4.31 is the second feature which is exactly our customer requirement.

Will you be able to direct us to a minimal set of prs(with which we can create a patch on 4.31 or a minimal version of eclipse upgrade) where this basic feature would work with a multi-monitor setup?

[HeikoKlare]

Will you be able to direct us to a minimal set of prs(with which we can create a patch on 4.31 or a minimal version of eclipse upgrade) where this basic feature would work with a multi-monitor setup?

There is no dedicated set of PRs that you can use, as it's a bunch of rework, refactoring and extensions, which, as explained above, led to hundreds of PRs implementing that feature guarded by a feature toggle.
For using the feature, my recommendation would be to use an as up-to-date state of SWT as possible for the best experience. With 4.36 the state was already quite decent, which is why it was enabled by default (https://eclipse.dev/eclipse/markdown/?f=news/4.36/platform.md). Still many fixes and improvements have been made afterwards, such that if you need to update anyway, you should consider directly moving to 4.38 or even 4.39.

[deepika-u]

Thanks alot for your inputs.