-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Description
Bug Description:
Scrolling the merge editor vertically can sometimes cause misalignments in scroll-sync between the vertically split panes.
Steps to Reproduce:
-
Open the 3-way merge editor with the
Merge Editor (Dev): Open Merge Editor State from JSONcommand (which is available in the command palette,F1) using the following JSON:{ "base": "1\n2\n3\n4\n5\na\n6\n7\n8\n9\n10", "input1": "1\n2\n3\n4\n5\n6\n7\n8\n9\n10", "input2": "1\n2\n3\n4\n5\na\nb\nc\nd\ne\nf\ng\n6\n7\n8\n9\n10", "result": "1\n2\n3\n4\n5\na\n6\n7\n8\n9\n10" }This corresponds to the following merge conflict:
-
Scroll the
Left(!) pane vertically until the merge conflict is displayed at the top of theLeftpane:
Observe that, while the merge conflict is displayed at the top of each of the horizontally split panes now, the bottom (
Result) pane displays the line5at the top. It would be expected that the merge conflict should be displayed at the top of theResultpane also in this case:
-
Scroll the
Result(!) pane vertically until the merge conflict is displayed at the top of theResultpane:
Observe that the merge conflict is no longer displayed at the top of each of the horizontally split panes in this case, contrary to what would have been expected.
-
Continue scrolling the
Resultpane vertically until the lineais displayed just near the top of theResultpane:
Observe that the merge conflict is almost scrolled out of view in the horizontally split panes now, while it would be expected that all panes should be precisely aligned relative to the line
ain this case:
Additional Information
I'm going to submit a fix.
- Operating System: all
- Theia Version: 1.68 (current master)