configs

Author: dgafka

packages/Ecotone/src/Messaging/Config/MessagingSystemConfiguration.php

@@ -881,6 +881,19 @@ public function process(ContainerBuilder $builder): void
             $this->afterCallMethodInterceptors,
         );
 
+        foreach ($this->gatewayBuilders as $gatewayBuilder) {
+            if (!isset($this->channelBuilders[$gatewayBuilder->getRequestChannelName()])) {
+                throw ConfigurationException::create("Gateway {$gatewayBuilder->getInterfaceName()}:{$gatewayBuilder->getRelatedMethodName()} has not existing request channel {$gatewayBuilder->getRequestChannelName()}. Have you forgot to declare some Message Handler for it?");
+            }
+        }
+        foreach ($this->messageHandlerBuilders as $messageHandlerBuilder) {
+            if ($messageHandlerBuilder instanceof MessageHandlerBuilderWithOutputChannel) {
+                if (!$this->isChannelDefinedFor($messageHandlerBuilder)) {
+                    throw ConfigurationException::create("Message handler {$messageHandlerBuilder} has not existing output channel {$messageHandlerBuilder->getInputMessageChannelName()}. Have you forgot to declare some Message Handler for it?");
+                }
+            }
+        }
+
         foreach ($this->serviceDefinitions as $id => $definition) {
             $messagingBuilder->register($id, $definition);
         }
@@ -1074,4 +1087,26 @@ private function getMessageHandlersBasedOnPriority(): array
 
         return $messageHandlerBuildersAccordinglyToPriority;
     }
+
+    public function isChannelDefinedFor(MessageHandlerBuilderWithOutputChannel|MessageHandlerBuilder $messageHandlerBuilder): bool
+    {
+        if (!$messageHandlerBuilder->getOutputMessageChannelName()) {
+            return true;
+        }
+
+        if (isset($this->channelBuilders[$messageHandlerBuilder->getOutputMessageChannelName()])) {
+            return true;
+        }
+
+        foreach ($this->messageHandlerBuilders as $comparableHandler) {
+            if (
+                $comparableHandler->getInputMessageChannelName() === $messageHandlerBuilder->getOutputMessageChannelName()
+                && $comparableHandler->getEndpointId() !== $messageHandlerBuilder->getEndpointId()
+            ) {
+                return true;
+            }
+        }
+
+        return false;
+    }
 }

packages/Ecotone/src/Messaging/Handler/Gateway/GatewayProxyBuilder.php

@@ -281,6 +281,11 @@ public function registerProxy(MessagingContainerBuilder $builder): Reference
         return new Reference($this->getReferenceName());
     }
 
+    public function getRequestChannelName(): string
+    {
+        return $this->requestChannelName;
+    }
+
     public function compile(MessagingContainerBuilder $builder): Definition
     {
         $interfaceToCallReference = new InterfaceToCallReference($this->interfaceName, $this->methodName);

packages/Ecotone/tests/Lite/EcotoneLiteTest.php

@@ -5,10 +5,12 @@
 use Ecotone\Lite\EcotoneLite;
 use Ecotone\Lite\Test\TestConfiguration;
 use Ecotone\Messaging\Channel\SimpleMessageChannelBuilder;
+use Ecotone\Messaging\Config\ConfigurationException;
 use Ecotone\Messaging\Config\ConsoleCommandResultSet;
 use Ecotone\Messaging\Config\ModulePackageList;
 use Ecotone\Messaging\Config\ServiceConfiguration;
 use PHPUnit\Framework\TestCase;
+use Test\Ecotone\Messaging\Fixture\Handler\Gateway\MultipleMethodsGatewayExample;
 use Test\Ecotone\Modelling\Fixture\Order\ChannelConfiguration;
 use Test\Ecotone\Modelling\Fixture\Order\OrderService;
 

packages/Ecotone/tests/Messaging/Fixture/InterceptedBridge/BridgeExampleIncomplete.php

@@ -0,0 +1,21 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Test\Ecotone\Messaging\Fixture\InterceptedBridge;
+
+use Ecotone\Messaging\Attribute\Interceptor\Around;
+use Ecotone\Messaging\Attribute\ServiceActivator;
+use Ecotone\Messaging\Handler\Processor\MethodInvoker\MethodInvocation;
+
+/**
+ * licence Apache-2.0
+ */
+final class BridgeExampleIncomplete
+{
+    #[ServiceActivator('bridgeExample', outputChannelName: 'bridgeSum')]
+    public function result(int $result): int
+    {
+        return $result;
+    }
+}

packages/Ecotone/tests/Messaging/Unit/Config/MessagingSystemConfigurationTest.php

@@ -56,9 +56,12 @@
 use Test\Ecotone\Messaging\Fixture\Endpoint\ConsumerContinuouslyWorkingService;
 use Test\Ecotone\Messaging\Fixture\Handler\DumbMessageHandlerBuilder;
 use Test\Ecotone\Messaging\Fixture\Handler\ExceptionMessageHandler;
+use Test\Ecotone\Messaging\Fixture\Handler\Gateway\MultipleMethodsGatewayExample;
 use Test\Ecotone\Messaging\Fixture\Handler\NoReturnMessageHandler;
 use Test\Ecotone\Messaging\Fixture\Handler\Processor\Interceptor\CallWithAnnotationFromMethodInterceptorExample;
 use Test\Ecotone\Messaging\Fixture\Handler\Processor\StubCallSavingService;
+use Test\Ecotone\Messaging\Fixture\InterceptedBridge\BridgeExample;
+use Test\Ecotone\Messaging\Fixture\InterceptedBridge\BridgeExampleIncomplete;
 use Test\Ecotone\Messaging\Fixture\SameChannelAndRouting\SomeTestCommandHandler;
 use Test\Ecotone\Messaging\Fixture\SameChannelAndRouting\SomeTestEventHandler;
 use Test\Ecotone\Messaging\Fixture\Service\CalculatingService;
@@ -2169,4 +2172,24 @@ public function test_throwing_exception_if_registered_event_handler_with_same_ro
                 ])
         );
     }
+
+    public function test_throwing_exception_on_lacking_request_channel_for_gateway(): void
+    {
+        $this->expectException(ConfigurationException::class);
+
+        EcotoneLite::bootstrapFlowTesting(
+            [MultipleMethodsGatewayExample::class],
+            [],
+        );
+    }
+
+    public function test_throwing_exception_on_lacking_output_channel_for_endpoint(): void
+    {
+        $this->expectException(ConfigurationException::class);
+
+        EcotoneLite::bootstrapFlowTesting(
+            [BridgeExampleIncomplete::class],
+            [],
+        );
+    }
 }