Fix whitespace handle in uris.

Fixes #270

Author: ericdallo

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- Fix whitespace handle in uris. #270
+
 ## 0.92.1
 
 - Add `x-llm-application-name: eca` to prompt requests, useful to track and get metrics when using LLM gateways.

docs/examples.md

@@ -133,7 +133,7 @@ If you think your config is relevant to be shared for other people, [open a pull
         "customTools": {
             "clj-nrepl-eval": {
                 "description": "${file:tools/clj-nrepl-eval.md}",
-                "command": "clj-nrepl-eval -p $(cat .nrepl-port) $'{{code}}'",
+                "command": "read -r -d '' CLJ_PAYLOAD << 'Mjz9q5s8' || true\n{{code}}\nMjz9q5s8\nclj-nrepl-eval -p $(cat .nrepl-port) \"$CLJ_PAYLOAD\"",
                 "schema": {
                     "properties": {
                         "code": {

src/eca/shared.clj

@@ -28,10 +28,10 @@
   (System/lineSeparator))
 
 (defn uri->filename [uri]
-  (let [uri (-> (URI. uri)
-                (.toASCIIString)
-                (URI.))]
-    (-> uri Paths/get .toString
+  (let [^URI uri (-> uri
+                     (string/replace " " "%20")
+                     (URI.))]
+    (-> (Paths/get uri) .toString
         ;; WINDOWS drive letters
         (string/replace #"^[a-z]:\\" string/upper-case))))
 

test/eca/shared_test.clj

@@ -15,7 +15,10 @@
     (is (= (when h/windows? "C:\\Users\\FirstName LastName\\c.clj")
            (when h/windows? (shared/uri->filename "file:/c:/Users/FirstName%20LastName/c.clj"))))
     (is (= (when h/windows? "C:\\c.clj")
-           (when h/windows? (shared/uri->filename "file:///c:/c.clj"))))))
+           (when h/windows? (shared/uri->filename "file:///c:/c.clj")))))
+  (testing "Spaces"
+    (is (= (h/file-path "/Users/foo/Library/Some Document/comappleCloudDocs")
+           (shared/uri->filename (h/file-uri "file:///Users/foo/Library/Some Document/comappleCloudDocs"))))))
 
 (deftest assoc-some-test
   (testing "single association"
@@ -122,18 +125,18 @@
     (is (= "**" (shared/obfuscate "ab")))
     (is (= "****" (shared/obfuscate "abcd"))))
 
-    (testing "default preserve-num=3 with various lengths"
+  (testing "default preserve-num=3 with various lengths"
       ;; length 5: middle forced to at least 5 stars, preserve shrinks to floor(len/2)
-      (is (= "ab*****de" (shared/obfuscate "abcde")))
+    (is (= "ab*****de" (shared/obfuscate "abcde")))
       ;; length 6: prefix 3, 5 stars, suffix 3 => 11 chars
-      (is (= "abc*****def" (shared/obfuscate "abcdef")))
+    (is (= "abc*****def" (shared/obfuscate "abcdef")))
       ;; length 7: prefix 3, 5 stars, suffix 3 => 11 chars
-      (is (= "abc*****efg" (shared/obfuscate "abcdefg")))
+    (is (= "abc*****efg" (shared/obfuscate "abcdefg")))
       ;; length 10: prefix 3, 5 stars, suffix 3 => 11 chars
-      (is (= "abc*****hij" (shared/obfuscate "abcdefghij"))))
-  
-    (testing "respect (bounded) preserve-num"
+    (is (= "abc*****hij" (shared/obfuscate "abcdefghij"))))
+
+  (testing "respect (bounded) preserve-num"
       ;; preserve-num smaller than half the length
-      (is (= "a*****f" (shared/obfuscate "abcdef" :preserve-num 1)))
+    (is (= "a*****f" (shared/obfuscate "abcdef" :preserve-num 1)))
       ;; preserve-num larger than half the length is capped
-      (is (= "abc*****def" (shared/obfuscate "abcdef" :preserve-num 10)))))
+    (is (= "abc*****def" (shared/obfuscate "abcdef" :preserve-num 10)))))