Skip to content

Update the call to murmurhash in documentation #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkmohangb wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update the call to murmurhash in documentation #240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/minhash.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ in the constructor.
# We need to define a new hash function that outputs an integer that
# can be encoded in 32 bits.
def _hash_func(d):
return mmh3.hash32(d)
return mmh3.hash(d, signed=False)
Copy link

@davidlowryduda davidlowryduda Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I see now that this is the same change I made in #304 - both fix the same problem. I approve this change.


# Use this function in MinHash constructor.
m = MinHash(hashfunc=_hash_func)
Expand Down