Skip to content

Commit 4bacccb

Browse files
committed
[Test] Given the Java implementation of set() method doesn't return anything while the Ruby implementation did as a side effect, the test was updated to retrieve the value instead of relaying on set that return a value
1 parent 6aa8dad commit 4bacccb

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

logstash-core/spec/logstash/settings/bytes_spec.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
require "spec_helper"
1919
require "logstash/settings"
2020

21-
describe LogStash::Setting::Bytes do
21+
describe LogStash::Setting::BytesSetting do
2222
let(:multipliers) do
2323
{
2424
"b" => 1,
@@ -40,7 +40,8 @@
4040
# Hard-coded test just to make sure at least one known case is working
4141
context "when given '10mb'" do
4242
it "returns 10485760" do
43-
expect(subject.set("10mb")).to be == 10485760
43+
subject.set("10mb")
44+
expect(subject.value).to be == 10485760
4445
end
4546
end
4647

0 commit comments

Comments
 (0)