[Fetch] fetchXHR callbacks are always specified. NFC (#24845)

No need to check for undefined here.

Author: sbc100

src/Fetch.js

@@ -244,7 +244,7 @@ function fetchXHR(fetch, onsuccess, onerror, onprogress, onreadystatechange) {
 #if FETCH_DEBUG
     dbg('fetch: XHR failed, no URL specified!');
 #endif
-    onerror(fetch, 0, 'no url specified!');
+    onerror(fetch, 'no url specified!');
     return;
   }
   var url_ = UTF8ToString(url);
@@ -363,12 +363,12 @@ function fetchXHR(fetch, onsuccess, onerror, onprogress, onreadystatechange) {
 #if FETCH_DEBUG
       dbg(`fetch: xhr of URL "${xhr.url_}" / responseURL "${xhr.responseURL}" succeeded with status ${xhr.status}`);
 #endif
-      onsuccess?.(fetch, xhr, e);
+      onsuccess(fetch, xhr, e);
     } else {
 #if FETCH_DEBUG
       dbg(`fetch: xhr of URL "${xhr.url_}" / responseURL "${xhr.responseURL}" failed with status ${xhr.status}`);
 #endif
-      onerror?.(fetch, xhr, e);
+      onerror(fetch, e);
     }
   };
   xhr.onerror = (e) => {
@@ -380,7 +380,7 @@ function fetchXHR(fetch, onsuccess, onerror, onprogress, onreadystatechange) {
     dbg(`fetch: xhr of URL "${xhr.url_}" / responseURL "${xhr.responseURL}" finished with error, readyState ${xhr.readyState} and status ${xhr.status}`);
 #endif
     saveResponseAndStatus();
-    onerror?.(fetch, xhr, e);
+    onerror(fetch, e);
   };
   xhr.ontimeout = (e) => {
     // check if xhr was aborted by user and don't try to call back
@@ -390,7 +390,7 @@ function fetchXHR(fetch, onsuccess, onerror, onprogress, onreadystatechange) {
 #if FETCH_DEBUG
     dbg(`fetch: xhr of URL "${xhr.url_}" / responseURL "${xhr.responseURL}" timed out, readyState ${xhr.readyState} and status ${xhr.status}`);
 #endif
-    onerror?.(fetch, xhr, e);
+    onerror(fetch, e);
   };
   xhr.onprogress = (e) => {
     // check if xhr was aborted by user and don't try to call back
@@ -420,7 +420,7 @@ function fetchXHR(fetch, onsuccess, onerror, onprogress, onreadystatechange) {
     if (xhr.readyState >= 3 && xhr.status === 0 && e.loaded > 0) status = 200;
     {{{ makeSetValue('fetch', C_STRUCTS.emscripten_fetch_t.status, 'status', 'i16') }}}
     if (xhr.statusText) stringToUTF8(xhr.statusText, fetch + {{{ C_STRUCTS.emscripten_fetch_t.statusText }}}, 64);
-    onprogress?.(fetch, xhr, e);
+    onprogress(fetch, e);
     _free(ptr);
   };
   xhr.onreadystatechange = (e) => {
@@ -439,7 +439,7 @@ function fetchXHR(fetch, onsuccess, onerror, onprogress, onreadystatechange) {
       var ruPtr = stringToNewUTF8(xhr.responseURL);
       {{{ makeSetValue('fetch', C_STRUCTS.emscripten_fetch_t.responseUrl, 'ruPtr', '*') }}}
     }
-    onreadystatechange?.(fetch, xhr, e);
+    onreadystatechange(fetch, e);
   };
 #if FETCH_DEBUG
   dbg(`fetch: xhr.send(data=${data})`);
@@ -450,7 +450,7 @@ function fetchXHR(fetch, onsuccess, onerror, onprogress, onreadystatechange) {
 #if FETCH_DEBUG
     dbg(`fetch: xhr failed with exception: ${e}`);
 #endif
-    onerror?.(fetch, xhr, e);
+    onerror(fetch, e);
   }
 }
 
@@ -486,14 +486,14 @@ function startFetch(fetch, successcb, errorcb, progresscb, readystatechangecb) {
     });
   };
 
-  var reportProgress = (fetch, xhr, e) => {
+  var reportProgress = (fetch, e) => {
     doCallback(() => {
       if (onprogress) {{{ makeDynCall('vp', 'onprogress') }}}(fetch);
       else progresscb?.(fetch);
     });
   };
 
-  var reportError = (fetch, xhr, e) => {
+  var reportError = (fetch, e) => {
 #if FETCH_DEBUG
     dbg(`fetch: operation failed: ${e}`);
 #endif
@@ -504,7 +504,7 @@ function startFetch(fetch, successcb, errorcb, progresscb, readystatechangecb) {
     });
   };
 
-  var reportReadyStateChange = (fetch, xhr, e) => {
+  var reportReadyStateChange = (fetch, e) => {
 #if FETCH_DEBUG
     dbg(`fetch: ready state change. e: ${e}`);
 #endif