Skip to content

http: add server context only factory support to connect_grpc_bridge #43286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wbpcode merged 1 commit into from
Feb 5, 2026
Merged

http: add server context only factory support to connect_grpc_bridge #43286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions source/extensions/filters/http/connect_grpc_bridge/config.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,15 @@ Http::FilterFactoryCb ConnectGrpcFilterConfigFactory::createFilterFactoryFromPro
};
}

Http::FilterFactoryCb
ConnectGrpcFilterConfigFactory::createFilterFactoryFromProtoWithServerContextTyped(
const envoy::extensions::filters::http::connect_grpc_bridge::v3::FilterConfig&,
const std::string&, Server::Configuration::ServerFactoryContext&) {
return [](Http::FilterChainFactoryCallbacks& callbacks) {
callbacks.addStreamFilter(std::make_shared<ConnectGrpcBridgeFilter>());
};
}

/**
* Static registration for the Connect RPC stats filter. @see RegisterFactory.
*/
Expand Down
4 changes: 4 additions & 0 deletions source/extensions/filters/http/connect_grpc_bridge/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ class ConnectGrpcFilterConfigFactory
Http::FilterFactoryCb createFilterFactoryFromProtoTyped(
const envoy::extensions::filters::http::connect_grpc_bridge::v3::FilterConfig& proto_config,
const std::string&, Server::Configuration::FactoryContext&) override;

Http::FilterFactoryCb createFilterFactoryFromProtoWithServerContextTyped(
const envoy::extensions::filters::http::connect_grpc_bridge::v3::FilterConfig& proto_config,
const std::string&, Server::Configuration::ServerFactoryContext&) override;
};

} // namespace ConnectGrpcBridge
Expand Down
11 changes: 11 additions & 0 deletions test/extensions/filters/http/connect_grpc_bridge/config_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,17 @@ TEST(ConnectGrpcBridgeFilterConfigTest, ConnectGrpcBridgeFilter) {
cb(filter_callback);
}

TEST(ConnectGrpcBridgeFilterConfigTest, ConnectGrpcBridgeFilterWithServerContext) {
NiceMock<Server::Configuration::MockServerFactoryContext> context;
ConnectGrpcFilterConfigFactory factory;
envoy::extensions::filters::http::connect_grpc_bridge::v3::FilterConfig config;
Http::FilterFactoryCb cb =
factory.createFilterFactoryFromProtoWithServerContext(config, "stats", context);
Http::MockFilterChainFactoryCallbacks filter_callback;
EXPECT_CALL(filter_callback, addStreamFilter(_)).Times(AtLeast(1));
cb(filter_callback);
}

} // namespace
} // namespace ConnectGrpcBridge
} // namespace HttpFilters
Expand Down
Loading