Skip to content

Add provided()<func>.call *args, **kwargs arguments #945 #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pavalso wants to merge 9 commits into
base: develop
Choose a base branch
from
+55 −4
Open

Add provided()<func>.call *args, **kwargs arguments #945 #946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
193249f
Merge branch 'release/4.47.0'
ZipFile May 28, 2025
8460465
Merge branch 'release/4.47.1'
ZipFile May 30, 2025
9d69943
Merge branch 'release/4.48.0'
ZipFile Jun 16, 2025
2c0aede
Merge branch 'release/4.48.1'
ZipFile Jun 20, 2025
7df26d1
docs(declarative.rst): fix grammar in Declarative Container documenta…
okotdaniel Aug 11, 2025
5a1aef9
Merge branch 'release/4.48.2'
ZipFile Sep 19, 2025
964d932
Merge branch 'release/4.48.3'
ZipFile Dec 4, 2025
4f8c4bf
Add provided()<func>.call *args, **kwargs arguments #945
pavalso Dec 10, 2025
06b1bd0
Add ServiceWithCallable and related tests for method calls with args …
pavalso Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/dependency_injector/wiring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,8 +959,8 @@ def __getitem__(self, item) -> Self:
self.segments.append((self.TYPE_ITEM, item))
return self

def call(self) -> Self:
self.segments.append((self.TYPE_CALL, None))
def call(self, *args, **kwargs) -> Self:
self.segments.append((self.TYPE_CALL, (args, kwargs)))
return self

def modify(
Expand All @@ -975,7 +975,7 @@ def modify(
elif type_ == ProvidedInstance.TYPE_ITEM:
provider = provider[value]
elif type_ == ProvidedInstance.TYPE_CALL:
provider = provider.call()
provider = provider.call(*value[0], **value[1])
else:
assert_never(type_)
return provider
Expand Down
4 changes: 3 additions & 1 deletion tests/unit/samples/wiring/container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from dependency_injector import containers, providers

from .service import Service
from .service import Service, ServiceWithCallable


class SubContainer(containers.DeclarativeContainer):
Expand All @@ -14,4 +14,6 @@ class Container(containers.DeclarativeContainer):

service = providers.Factory(Service)

service_with_callable = providers.Factory(ServiceWithCallable)

sub = providers.Container(SubContainer)
21 changes: 21 additions & 0 deletions tests/unit/samples/wiring/module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,27 @@ def test_provided_instance(some_value: int = Provide[Container.service.provided.
return some_value


@inject
def test_provided_instance_call_with_args(
some_value: int = Provide[Container.service_with_callable.provided.method_with_args.call(1, 2)]
Copy link
Contributor

@ZipFile ZipFile Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we test for string ids? I.e. Provide["service_with_callable", provided().method_with_args.call(1, 2)]?

):
return some_value


@inject
def test_provided_instance_call_with_kwargs(
some_value: dict = Provide[Container.service_with_callable.provided.method_with_kwargs.call(a=1, b=2)]
):
return some_value


@inject
def test_provided_instance_call_with_args_and_kwargs(
some_value: dict = Provide[Container.service_with_callable.provided.foo.process.call(1, 2, key="value")]
):
return some_value


@inject
def test_subcontainer_provider(some_value: int = Provide[Container.sub.int_object]):
return some_value
Expand Down
13 changes: 13 additions & 0 deletions tests/unit/samples/wiring/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,15 @@
class Service:
service_attr: int


class ServiceWithCallable:
def __init__(self):
self.foo = CallableDict({"bar": lambda: 10})
Copy link
Contributor

@ZipFile ZipFile Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.foo = CallableDict({"bar": lambda: 10})
self.foo = {"bar": lambda *args, **kwargs: {"args": args, "kwargs": kwargs}}

Does it need to be separate dict subclass?

self.method_with_args = lambda x, y: x + y
self.method_with_kwargs = lambda **kwargs: kwargs
Comment on lines +8 to +9
Copy link
Contributor

@ZipFile ZipFile Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to have them as proper methods



class CallableDict(dict):
def __init__(self, data):
super().__init__(data)
self.process = lambda *args, **kwargs: {"args": args, "kwargs": kwargs}
15 changes: 15 additions & 0 deletions tests/unit/wiring/provider_ids/test_main_py36.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,21 @@ class TestService:
assert some_value == 10


def test_provided_instance_call_with_args():
some_value = module.test_provided_instance_call_with_args()
assert some_value == 3


def test_provided_instance_call_with_kwargs():
some_value = module.test_provided_instance_call_with_kwargs()
assert some_value == {"a": 1, "b": 2}


def test_provided_instance_call_with_args_and_kwargs():
some_value = module.test_provided_instance_call_with_args_and_kwargs()
assert some_value == {"args": (1, 2), "kwargs": {"key": "value"}}


def test_subcontainer():
some_value = module.test_subcontainer_provider()
assert some_value == 1
Expand Down