Correct a bank-account test to close account#2062
Correct a bank-account test to close account#2062itsjustaaron wants to merge 1 commit intoexercism:mainfrom
Conversation
The test that checks "close already closed account throws error" does not currently try to close the account twice. Adding in `account.close()` before the `expect()` should fix this.
|
Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed. That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
As you know from the forum post, we're discussing how to resolve this. I did want to re-open this to show you that we currently have CI running on each exercise, on each test. If a test is changed, almost always the "proof" also needs to be updated. The proof lives here: https://github.com/exercism/javascript/blob/main/exercises/practice/bank-account/.meta/proof.ci.js If we're changing the test to only throw on the "second" close, then we must update the solution to be "open by default", which may or may not be what we want to do, depending on the outcome of the forum post. |
|
Thank you for the contribution nonetheless! |
The test that checks "close already closed account throws error" does not currently try to close the account twice. Adding in
account.close()before theexpect()should fix this.