Infinite loop in Fizzy exercise tests

[ciccio-87]

Hi,

I was recently working on the Fizzy exercise and it seems that the f64 and Fizzable test cases end up looping indefinitely on an iterator.

It looks like the problem is here:

let actual = fizz_buzz::<Fizzable>()
  .apply(std::iter::successors(Some(Fizzable(1)), |prev| {
              Some(*prev + 1.into())
   }))
  .take(16)
  .collect::<Vec<_>>();

This seems to end up passing the whole, infinite, iterator to the apply method, before the take(16) , when it should probably pass only the taken elements, like this:

let actual = fizz_buzz::<Fizzable>()
  .apply(std::iter::successors(Some(Fizzable(1)), |prev| {
              Some(*prev + 1.into())
   })
  .take(16)
  )
  .collect::<Vec<_>>();

This ends up in a timeout in the f64 case and in an u8 overflow on the first Fizzable test case.

[github-actions]

Hello. Thanks for opening an issue on Exercism 🙂

At Exercism we use our Community Forum, not GitHub issues, as the primary place for discussion. That allows maintainers and contributors from across Exercism's ecosystem to discuss your problems/ideas/suggestions without them having to subscribe to hundreds of repositories.

This issue will be automatically closed. Please use this link to copy your GitHub Issue into a new topic on the forum, where we look forward to chatting with you!

If you're interested in learning more about this auto-responder, please read this blog post.

[senekor]

You're probably consuming the entire iterator eagerly in the apply function. Don't do that.

[ciccio-87]

Yup, should have thought about it a bit more, the issue is in my code, thanks.