scene: add api change

Author: 0xfedcafe

library/private/scene_impl.h

@@ -35,7 +35,7 @@ class scene_impl : public scene
   scene& add(const std::vector<std::filesystem::path>& filePath) override;
   scene& add(const std::vector<std::string>& filePathStrings) override;
   scene& add(const mesh_t& mesh) override;
-  scene& add(const double startTime, const double endTime, MeshCallback&& callback) override;
+  scene& add(std::vector<double> times, MeshCallback&& callback) override;
   scene& clear() override;
   int addLight(const light_state_t& lightState) const override;
   int getLightCount() const override;

library/public/scene.h

@@ -72,7 +72,7 @@ class F3D_EXPORT scene
   /**
    * Add and load provided mesh into the scene
    */
-  virtual scene& add(std::pair<double> timeRange, MeshCallback&& callback) = 0;
+  virtual scene& add(std::vector<double> times, MeshCallback&& callback) = 0;
 
   ///@{
   /**

library/src/scene_impl.cxx

@@ -296,9 +296,9 @@ scene& scene_impl::add(const std::vector<fs::path>& filePaths)
 }
 
 //----------------------------------------------------------------------------
-scene& scene_impl::add(const double startTime, const double endTime, MeshCallback&& callback)
+scene& scene_impl::add(std::vector<double> times, MeshCallback&& callback)
 {
-  if (startTime > endTime)
+  if (times[1] < times[0])
   {
     throw scene::load_failure_exception("startTime must be less than or equal to endTime");
   }
@@ -314,7 +314,7 @@ scene& scene_impl::add(const double startTime, const double endTime, MeshCallbac
     vtkMesh->SetFaces(mesh.face_sides, mesh.face_indices);
   };
 
-  vtkSource->SetAnimatedMesh(startTime, endTime, std::move(wrappedCallback));
+  vtkSource->SetAnimatedMesh(times[0], times[1], std::move(wrappedCallback));
 
   auto importer = vtkSmartPointer<vtkF3DGenericImporter>::New();
   importer->SetInternalReader(vtkSource);

library/testing/TestSDKSceneTemporalFromMemory.cxx

@@ -30,8 +30,7 @@ int TestSDKSceneTemporalFromMemory([[maybe_unused]] int argc, [[maybe_unused]] c
   const std::vector<unsigned int> faceSides{ 3, 3 };
   const std::vector<unsigned int> faceIndices{ 0, 1, 2, 1, 3, 2 };
 
-  auto meshCallback = [&](double time) -> f3d::mesh_t
-  {
+  auto meshCallback = [&](double time) -> f3d::mesh_t {
     if (time < 0.5)
     {
       return f3d::mesh_t{ basePoints, normals, tcoords, faceSides, faceIndices };
@@ -42,7 +41,7 @@ int TestSDKSceneTemporalFromMemory([[maybe_unused]] int argc, [[maybe_unused]] c
     }
   };
 
-  test("add animated mesh with callback", [&]() { sce.add(0.0, 1.0, meshCallback); });
+  test("add animated mesh with callback", [&]() { sce.add({ 0.0, 1.0 }, meshCallback); });
 
   test("animation time range", [&]() {
     auto range = sce.animationTimeRange();