fix: missing symbols on prebuilt Android with hermesV1 disabled#55400
Open
tjzel wants to merge 2 commits intofacebook:mainfrom
Open
fix: missing symbols on prebuilt Android with hermesV1 disabled#55400tjzel wants to merge 2 commits intofacebook:mainfrom
tjzel wants to merge 2 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Software Mansion
Contributor
|
This is a known issue for Hermes V1. |
cortinico
reviewed
Feb 4, 2026
Comment on lines
39
to
45
| DebugSessionToken enableDebugging( | ||
| std::unique_ptr<RuntimeAdapter>, | ||
| const std::string&) { | ||
| return -1; | ||
| }; | ||
|
|
||
| void disableDebugging(DebugSessionToken) {} |
Contributor
There was a problem hiding this comment.
Can you add a comment in the body explaining why we're leaving them empty (essentially what you wrote in your PR summary)
Contributor
|
@tjzel can we make sure the CI is green? |
Contributor
Author
|
yes, I'll work on that tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Since HermesV1 is enabled by default in React Native 0.84, the prebuilt Android artifacts are compiled with the flag
HERMES_V1_ENABLED. This results in dropping some inspector symbols, in my caseenableDebugginganddisableDebuggingfrominspector-modern/chrome/Registration.cpp.This is problematic, because even if the app sets
hermesV1Enabled=falseingradle.properties, it's shipped with binaries compiled withhermesV1Enabled=true. This makes it so I'm expecting symbols that should be available whenHERMES_V1_ENABLEDmacro isn't defined - but they aren't available.I don't know what other symbols could lead to compilation failures, maybe shipping a whole other binary would be a better idea. For the time being I made a simple fix that would provide fallback implementations instead of not generating them at all.
Changelog:
[ANDROID] [FIXED] - Provide symbol fallbacks for
inspector-modern/chrome/Registration.hwhen HermesV1 is disabled.Test Plan:
I tested these changes (although in
Registration.hfile) in a project, not building from source, and they worked.