fix: resolve lint issues across the codebase (#2337)

* fix: resolve lint issues across the codebase

- Fix no-floating-promises warnings by adding void operator for fire-and-forget calls
- Fix exhaustive-deps warnings in React hooks by adding missing dependencies
- Fix restrict-template-expressions warnings by properly typing template literals
- Fix no-useless-escape warnings in regex patterns
- Fix no-useless-rename warnings in destructuring
- Fix no-unused-expressions warnings
- Fix @tanstack/query/no-unstable-deps errors by destructuring query results
- Fix no-constant-condition warnings by removing ternary operators with constant conditions

Remaining issues are:
- tsconfig baseUrl errors (configuration issues, not code)
- unbound-method warnings in test files (intentional patterns)
- Simple unused variable warnings (as requested to skip)
- Generated files (api-client, routeTree.gen.ts)

Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>

* fix: restore compile-time type check with eslint-disable comment

Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>

* style: apply dprint formatting

Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: yujonglee <yujonglee.dev@gmail.com>

Author: devin-ai-integration[bot]

apps/api/src/scripts/generate-openapi.ts

@@ -33,4 +33,4 @@ async function main() {
   }
 }
 
-main();
+void main();

apps/api/src/stt/stt.test.ts

@@ -6,7 +6,7 @@ import {
   payloadIsControlMessage,
 } from "./utils";
 
-mock.module("../env", () => ({
+void mock.module("../env", () => ({
   env: {
     DEEPGRAM_API_KEY: "test-deepgram-key",
     ASSEMBLYAI_API_KEY: "test-assemblyai-key",

apps/bot/src/devin/poller.ts

@@ -256,7 +256,9 @@ export class DevinStatusPoller {
         `Discovered ${this.trackedPRs.size} PRs with active Devin sessions`,
       );
     } catch (error) {
-      this.logger.error(`Failed to discover existing sessions: ${error}`);
+      this.logger.error(
+        `Failed to discover existing sessions: ${error instanceof Error ? error.message : String(error)}`,
+      );
     }
   }
 
@@ -295,7 +297,7 @@ export class DevinStatusPoller {
         await this.checkPRStatus(pr, sessionsByPrUrl);
       } catch (error) {
         this.logger.error(
-          `Failed to check status for PR ${pr.prUrl}: ${error}`,
+          `Failed to check status for PR ${pr.prUrl}: ${error instanceof Error ? error.message : String(error)}`,
         );
       }
     }
@@ -329,7 +331,9 @@ export class DevinStatusPoller {
         return;
       }
     } catch (error) {
-      this.logger.error(`Failed to check PR state for ${pr.prUrl}: ${error}`);
+      this.logger.error(
+        `Failed to check PR state for ${pr.prUrl}: ${error instanceof Error ? error.message : String(error)}`,
+      );
     }
 
     // Use cached session lookup instead of making individual API calls
@@ -380,7 +384,7 @@ export class DevinStatusPoller {
         this.untrackPR(pr.prUrl);
       } catch (error) {
         this.logger.error(
-          `Failed to verify session status for ${pr.sessionId}: ${error}`,
+          `Failed to verify session status for ${pr.sessionId}: ${error instanceof Error ? error.message : String(error)}`,
         );
       }
       return;
@@ -510,7 +514,9 @@ export class DevinStatusPoller {
         `Updated check for PR ${pr.prUrl}: ${status} ${conclusion ?? ""}`,
       );
     } catch (error) {
-      this.logger.error(`Failed to update check for PR ${pr.prUrl}: ${error}`);
+      this.logger.error(
+        `Failed to update check for PR ${pr.prUrl}: ${error instanceof Error ? error.message : String(error)}`,
+      );
     }
   }
 }

apps/bot/src/features/devin-status.ts

@@ -38,7 +38,9 @@ export function registerDevinStatusHandler(app: Probot): void {
       try {
         await checkDevinSession(context, owner, repo, prNumber, headSha, prUrl);
       } catch (error) {
-        context.log.error(`[Devin] Failed to check Devin session: ${error}`);
+        context.log.error(
+          `[Devin] Failed to check Devin session: ${error instanceof Error ? error.message : String(error)}`,
+        );
       }
     },
   );

apps/bot/src/features/fix-merge-conflict.ts

@@ -59,7 +59,7 @@ export function registerFixMergeConflictHandler(app: Probot): void {
         }
       } catch (error) {
         context.log.error(
-          `Failed to handle merge conflict check for PR #${pr.number}: ${error}`,
+          `Failed to handle merge conflict check for PR #${pr.number}: ${error instanceof Error ? error.message : String(error)}`,
         );
       }
     }

apps/bot/src/features/pr-closed.ts

@@ -31,7 +31,7 @@ export function registerPrClosedHandler(app: Probot): void {
       );
     } catch (error) {
       context.log.error(
-        `Failed to terminate Devin session for ${prUrl}: ${error}`,
+        `Failed to terminate Devin session for ${prUrl}: ${error instanceof Error ? error.message : String(error)}`,
       );
     }
   });

apps/bot/src/server.ts

@@ -17,4 +17,4 @@ async function start() {
   await server.start();
 }
 
-start();
+void start();

apps/desktop/src/auth.tsx

@@ -123,7 +123,7 @@ export function AuthProvider({ children }: { children: React.ReactNode }) {
     } else {
       setSession(res.data.session);
       setServerReachable(true);
-      supabase.auth.startAutoRefresh();
+      void supabase.auth.startAutoRefresh();
     }
   };
 
@@ -149,20 +149,20 @@ export function AuthProvider({ children }: { children: React.ReactNode }) {
 
     const unlistenFocus = appWindow.listen("tauri://focus", () => {
       if (serverReachable) {
-        supabase.auth.startAutoRefresh();
+        void supabase.auth.startAutoRefresh();
       }
     });
     const unlistenBlur = appWindow.listen("tauri://blur", () => {
-      supabase.auth.stopAutoRefresh();
+      void supabase.auth.stopAutoRefresh();
     });
 
-    onOpenUrl(([url]) => {
-      handleAuthCallback(url);
+    void onOpenUrl(([url]) => {
+      void handleAuthCallback(url);
     });
 
     return () => {
-      unlistenFocus.then((fn) => fn());
-      unlistenBlur.then((fn) => fn());
+      void unlistenFocus.then((fn) => fn());
+      void unlistenBlur.then((fn) => fn());
     };
   }, [serverReachable]);
 
@@ -198,14 +198,14 @@ export function AuthProvider({ children }: { children: React.ReactNode }) {
             ) {
               setServerReachable(false);
               setSession(data.session);
-              supabase.auth.startAutoRefresh();
+              void supabase.auth.startAutoRefresh();
               return;
             }
           }
           if (refreshData.session) {
             setSession(refreshData.session);
             setServerReachable(true);
-            supabase.auth.startAutoRefresh();
+            void supabase.auth.startAutoRefresh();
           }
         }
       } catch (e) {
@@ -223,14 +223,14 @@ export function AuthProvider({ children }: { children: React.ReactNode }) {
       }
     };
 
-    initSession();
+    void initSession();
 
     const {
       data: { subscription },
     } = supabase.auth.onAuthStateChange((event, session) => {
       if (event === "TOKEN_REFRESHED" && !session) {
         if (isLocalAuthServer(env.VITE_SUPABASE_URL)) {
-          clearAuthStorage();
+          void clearAuthStorage();
           setServerReachable(false);
         }
       }

apps/desktop/src/billing.tsx

@@ -46,7 +46,7 @@ export function BillingProvider({ children }: { children: ReactNode }) {
   );
 
   const upgradeToPro = useCallback(() => {
-    openUrl(`${env.VITE_APP_URL}/app/checkout?period=monthly`);
+    void openUrl(`${env.VITE_APP_URL}/app/checkout?period=monthly`);
   }, []);
 
   const value = useMemo<BillingContextValue>(

apps/desktop/src/components/changelog-listener.tsx

@@ -15,7 +15,7 @@ export function ChangelogListener() {
     }
 
     let unlisten: null | UnlistenFn = null;
-    events.updatedEvent
+    void events.updatedEvent
       .listen(({ payload: { previous, current } }) => {
         openNew({
           type: "changelog",