Skip to content

Add trigger.rs for Nango action trigger API#3714

Merged
yujonglee merged 1 commit intomainfrom
devin/1770476239-nango-trigger
Feb 7, 2026
Merged

Add trigger.rs for Nango action trigger API#3714
yujonglee merged 1 commit intomainfrom
devin/1770476239-nango-trigger

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Feb 7, 2026

Add trigger.rs for Nango action trigger API

Summary

Adds a new trigger.rs module to crates/nango implementing the POST /action/trigger Nango API endpoint.

Two methods on NangoClient:

  • trigger_action — synchronous trigger, returns serde_json::Value
  • trigger_action_async — sets X-Async: true header, accepts optional max_retries (maps to X-Max-Retries), returns typed TriggerActionAsyncResponse { status_url, id }

Follows existing crate conventions (common_derives! macro, parse_response, header-based connection/provider params).

Review & Testing Checklist for Human

  • Verify this compilescargo check -p nango failed in CI-like env due to unrelated missing workspace member (plugins/cli2), so the new code was never actually compiled. This is the highest-priority item.
  • Confirm the sync return type (serde_json::Value) is the desired ergonomic choice vs. a generic T: DeserializeOwned parameter
  • Verify header names (Connection-Id, Provider-Config-Key, X-Async, X-Max-Retries) match the actual Nango API expectations

Notes


Open with Devin

Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@netlify
Copy link

netlify bot commented Feb 7, 2026

Deploy Preview for hyprnote-storybook canceled.

Name Link
🔨 Latest commit 17f3630
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote-storybook/deploys/6987532a89188a0008b96dac

@netlify
Copy link

netlify bot commented Feb 7, 2026

Deploy Preview for hyprnote canceled.

Name Link
🔨 Latest commit 17f3630
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/6987532a5437e70008d0591a

@yujonglee yujonglee merged commit e63aa87 into main Feb 7, 2026
16 of 17 checks passed
@yujonglee yujonglee deleted the devin/1770476239-nango-trigger branch February 7, 2026 14:59
Copy link
Contributor Author

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant