fix(api): resolve ruff lint errors

- Fix import sorting and unused imports
- Remove duplicate abstract method definitions in AIProvider
- Replace try-except-pass with contextlib.suppress in telemetry
- Prefix unused variable with underscore in rate_limit
- Add noqa comments for Pydantic/ABC Generic compatibility (UP046)
- Add noqa for local dev default password (S105)

Author: gracefullight

apps/api/alembic/env.py

@@ -1,11 +1,11 @@
 import asyncio
 from logging.config import fileConfig
 
-from alembic import context
 from sqlalchemy import pool
 from sqlalchemy.engine import Connection
 from sqlalchemy.ext.asyncio import async_engine_from_config
 
+from alembic import context
 from src.lib.config import settings
 from src.lib.database import Base
 

apps/api/src/common/models/__init__.py

@@ -8,9 +8,9 @@
 )
 
 __all__ = [
-    "TimestampMixin",
-    "UUIDMixin",
     "PaginatedResponse",
     "PaginationMeta",
     "PaginationParams",
+    "TimestampMixin",
+    "UUIDMixin",
 ]

apps/api/src/common/models/pagination.py

@@ -30,7 +30,7 @@ class PaginationMeta(BaseModel):
     has_prev: bool = Field(description="Whether there is a previous page")
 
 
-class PaginatedResponse(BaseModel, Generic[T]):
+class PaginatedResponse(BaseModel, Generic[T]):  # noqa: UP046
     """Generic paginated response wrapper."""
 
     data: list[T]

apps/api/src/lib/ai/base.py

@@ -1,28 +1,15 @@
 from abc import ABC, abstractmethod
-from typing import Any, AsyncIterator, Generic, TypeVar
+from collections.abc import AsyncIterator
+from typing import Any, Generic, TypeVar
 
 T = TypeVar("T")
 
 
-class AIProvider(ABC, Generic[T]):
+class AIProvider(ABC, Generic[T]):  # noqa: UP046
     @abstractmethod
     async def analyze_image(self, image_data: bytes | list[bytes]) -> T:
         pass
 
-    @abstractmethod
-    async def generate_text(self, prompt: str, **kwargs: Any) -> str:
-        pass
-
-    @abstractmethod
-    async def generate_stream(self, prompt: str, **kwargs: Any) -> AsyncIterator[str]:
-        pass
-
-    @abstractmethod
-    async def generate_structured(
-        self, prompt: str, schema: type[T], **kwargs: Any
-    ) -> T:
-        pass
-
     @abstractmethod
     async def generate_text(self, prompt: str, **kwargs: Any) -> str:
         """Generate text from prompt.

apps/api/src/lib/auth.py

@@ -1,6 +1,6 @@
 from collections.abc import Callable
 from functools import wraps
-from typing import Annotated, Any, Literal
+from typing import Annotated, Any
 
 import httpx
 from fastapi import Depends, HTTPException, Request, status

apps/api/src/lib/config.py

@@ -46,7 +46,7 @@ class Settings(BaseSettings):
     GCS_BUCKET_NAME: str | None = None
     MINIO_ENDPOINT: str = "localhost:9000"
     MINIO_ACCESS_KEY: str = "minioadmin"
-    MINIO_SECRET_KEY: str = "minioadmin"
+    MINIO_SECRET_KEY: str = "minioadmin"  # noqa: S105
 
 
 @lru_cache

apps/api/src/lib/dependencies.py

@@ -22,15 +22,15 @@
 
 # Re-export auth dependencies for convenience
 __all__ = [
-    "DBSession",
     "CurrentUser",
+    "DBSession",
+    "OptionalSession",
     "OptionalUser",
     "RequiredSession",
-    "OptionalSession",
-    "SessionUser",
     "SessionResponse",
+    "SessionUser",
     "get_current_user",
+    "get_optional_session",
     "get_optional_user",
     "get_required_session",
-    "get_optional_session",
 ]

apps/api/src/lib/rate_limit.py

@@ -2,8 +2,8 @@
 
 import time
 from collections import defaultdict
+from collections.abc import Callable
 from dataclasses import dataclass, field
-from typing import Callable
 
 from fastapi import HTTPException, Request, status
 
@@ -180,9 +180,9 @@ async def wrapper(*args, **kwargs):
             key = actual_key_func(request)
 
             if isinstance(limiter, RedisRateLimiter):
-                allowed, remaining, reset_after = await limiter.is_allowed(key)
+                allowed, _remaining, reset_after = await limiter.is_allowed(key)
             else:
-                allowed, remaining, reset_after = limiter.is_allowed(key)
+                allowed, _remaining, reset_after = limiter.is_allowed(key)
 
             if not allowed:
                 logger.warning("Rate limit exceeded", key=key)

apps/api/src/lib/telemetry.py

@@ -1,5 +1,7 @@
 """OpenTelemetry configuration for distributed tracing."""
 
+import contextlib
+
 from opentelemetry import trace
 from opentelemetry.exporter.otlp.proto.grpc.trace_exporter import OTLPSpanExporter
 from opentelemetry.instrumentation.fastapi import FastAPIInstrumentor
@@ -60,10 +62,8 @@ def instrument_app(app: "FastAPI") -> None:  # noqa: F821
     HTTPXClientInstrumentor().instrument()
 
     # Instrument Redis (if available)
-    try:
+    with contextlib.suppress(Exception):
         RedisInstrumentor().instrument()
-    except Exception:
-        pass  # Redis not installed or not configured
 
 
 def get_tracer(name: str = __name__) -> trace.Tracer:

apps/api/src/main.py

@@ -1,5 +1,6 @@
+from collections.abc import AsyncIterator
 from contextlib import asynccontextmanager
-from typing import AsyncIterator, Literal
+from typing import Literal
 from uuid import uuid4
 
 import structlog