add-fact/OCCU Should Include ADDR

[miqrogroove]

When adding an Occupation to an individual, the Address field is missing unless the user clicks "Edit with all GEDCOM tags". This is slightly confusing because an Address would seem to be a common element of some occupations.

[fisharebest]

an Address would seem to be a common element of some occupations

In my own tree, I have very, very few addresses for occupations.
A quick search says I have only 3 OCCU:ADDR records, out of 10,000 individuals.

Generally, sources just give "Farmhand", "Bootmaker", "Coalminer", "Seamstress", etc.

An address would make more sense for the concept of "Employment", rather than "Occupation". (But we don't have a GEDCOM tag for that).

[miqrogroove]

I think we are using very different sources.

[BertKoor]

With a tiny edit you can change this yourself. In the file /app/Elements/Occupation.php on line 33 just remove the trailing colon questionmark, so it becomes

'ADDR'  => '0:1',

In case webtrees is updated on your server, then this gets overwritten. If you want a more permanent solution so it survives future upgrades, you can put this into a custom module. Create a file module.php in new folder \modules_v4\OccuAddrModule with the following content:

<?php

declare(strict_types=1);

namespace OccuAddrNamespace;

use Fisharebest\Webtrees\Elements\Occupation;
use Fisharebest\Webtrees\I18N;
use Fisharebest\Webtrees\Module\AbstractModule;
use Fisharebest\Webtrees\Module\ModuleCustomInterface;
use Fisharebest\Webtrees\Module\ModuleCustomTrait;
use Fisharebest\Webtrees\Registry;

class MyOccupation extends Occupation
{
    protected const array SUBTAGS = [
        'TYPE'  => '0:1:?',
        'DATE'  => '0:1',
        'PLAC'  => '0:1',
        'ADDR'  => '0:1',
        'EMAIL' => '0:1:?',
        'WWW'   => '0:1:?',
        'PHON'  => '0:1:?',
        'FAX'   => '0:1:?',
        'CAUS'  => '0:1:?',
        'AGNC'  => '0:1',
        'RELI'  => '0:1:?',
        'NOTE'  => '0:M',
        'OBJE'  => '0:M',
        'SOUR'  => '0:M',
        'RESN'  => '0:1',
    ];
}

class OccuAddrModule extends AbstractModule implements ModuleCustomInterface
{
    use ModuleCustomTrait;

    public function __construct()
    {
    }

    public function title(): string
    {
        return 'Occupation with Address not hidden';
    }

    public function boot(): void
    {
        Registry::elementFactory()->registerTags([
            'INDI:OCCU' => new MyOccupation(I18N::translate('Occupation'))
        ]);
    }

}

return new OccuAddrModule;