fix: improve DNS endpoints implementation

- Use core.NewMissingSettingsError for validation errors
- Remove duplicate RBAC marker from stacks/init.go
- Add logging to DNS endpoint create/delete operations
- Simplify deleteDNSEndpoint function
- Fix typo in CRD test file (DNSEnpoint -> DNSEndpoint)

Author: flemzord

internal/resources/gateways/dnsendpoints.go

@@ -7,6 +7,7 @@ import (
 
 	"k8s.io/apimachinery/pkg/types"
 	"sigs.k8s.io/controller-runtime/pkg/client"
+	"sigs.k8s.io/controller-runtime/pkg/log"
 	"sigs.k8s.io/external-dns/apis/v1alpha1"
 	"sigs.k8s.io/external-dns/endpoint"
 
@@ -39,15 +40,15 @@ func getDNSConfig(ctx core.Context, stack string, dnsType string) (*DNSConfig, e
 		return nil, err
 	}
 	if len(dnsNames) == 0 {
-		return nil, fmt.Errorf("gateway.dns.%s.dns-names is required when gateway.dns.%s.enabled is true", dnsType, dnsType)
+		return nil, core.NewMissingSettingsError(fmt.Sprintf("gateway.dns.%s.dns-names is required when gateway.dns.%s.enabled is true", dnsType, dnsType))
 	}
 
 	targets, err := settings.GetTrimmedStringSlice(ctx, stack, "gateway", "dns", dnsType, "targets")
 	if err != nil {
 		return nil, err
 	}
 	if len(targets) == 0 {
-		return nil, fmt.Errorf("gateway.dns.%s.targets is required when gateway.dns.%s.enabled is true", dnsType, dnsType)
+		return nil, core.NewMissingSettingsError(fmt.Sprintf("gateway.dns.%s.targets is required when gateway.dns.%s.enabled is true", dnsType, dnsType))
 	}
 
 	providerSpec, err := settings.GetMapOrEmpty(ctx, stack, "gateway", "dns", dnsType, "provider-specific")
@@ -80,9 +81,12 @@ func expandDNSPattern(pattern, stack string) string {
 }
 
 func createDNSEndpoint(ctx core.Context, gateway v1beta1.Dependent, dnsType string, config *DNSConfig) error {
+	logger := log.FromContext(ctx)
 	name := fmt.Sprintf("%s-%s", gateway.GetName(), dnsType)
 	stackName := gateway.GetStack()
 
+	logger.Info("Creating DNS endpoint", "name", name, "type", dnsType, "dnsNames", config.DNSPatterns, "targets", config.Targets)
+
 	// Build endpoints array - one endpoint per DNS name
 	endpoints := []*endpoint.Endpoint{}
 	for _, dnsPattern := range config.DNSPatterns {
@@ -173,17 +177,12 @@ func reconcileDNSEndpoints(ctx core.Context, gateway v1beta1.Dependent) error {
 }
 
 func deleteDNSEndpoint(ctx core.Context, namespace, name string) error {
+	logger := log.FromContext(ctx)
 	dnsEndpoint := &v1alpha1.DNSEndpoint{}
 	dnsEndpoint.SetName(name)
 	dnsEndpoint.SetNamespace(namespace)
 
-	if err := ctx.GetClient().Get(ctx, types.NamespacedName{
-		Name:      name,
-		Namespace: namespace,
-	}, dnsEndpoint); err != nil {
-		// Resource doesn't exist, nothing to delete
-		return client.IgnoreNotFound(err)
-	}
+	logger.Info("Deleting DNS endpoint if exists", "name", name, "namespace", namespace)
 
-	return ctx.GetClient().Delete(ctx, dnsEndpoint)
+	return client.IgnoreNotFound(ctx.GetClient().Delete(ctx, dnsEndpoint))
 }

internal/resources/stacks/init.go

@@ -41,7 +41,6 @@ import (
 // +kubebuilder:rbac:groups=core,resources=events,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups=batch,resources=jobs,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups=cert-manager.io,resources=certificates,verbs=get;list;watch;create;update;patch;delete
-// +kubebuilder:rbac:groups=externaldns.k8s.io,resources=dnsendpoints,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups=formance.com,resources=stacks,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups=formance.com,resources=stacks/status,verbs=get;update;patch
 // +kubebuilder:rbac:groups=formance.com,resources=stacks/finalizers,verbs=update