Adding manual buttons for zoom-in or zoom-out#1055
Merged
mfisher87 merged 8 commits intogeojupyter:mainfrom Jan 19, 2026
Merged
Adding manual buttons for zoom-in or zoom-out#1055mfisher87 merged 8 commits intogeojupyter:mainfrom
mfisher87 merged 8 commits intogeojupyter:mainfrom
Conversation
Contributor
|
|
Contributor
|
Integration tests report: appsharing.space |
Collaborator
Author
|
@mfisher87 Tests are failing due to unmatched snapshots. Can you give a try to update them. |
Member
|
Nakul and I were chatting about this and we agree there should be a setting to show/hide these zoom buttons. Where we disagree is:
@martinRenou @arjxn-py @gjmooney what do you think: Should the zoom in/out buttons be shown or hidden by default? EDIT: We made them hidden by default! |
Member
|
We discovered a pre-existing bug while working on this: #1081 |
We think of this setting as "opt-in", so it makes sense for the box to initially be not checked. We want the default to be for the buttons to be hidden, so we need to change the setting from "disable" to "enable" to meet those conditions! Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com>
HaudinFlorence
pushed a commit
to HaudinFlorence/jupytergis
that referenced
this pull request
Jan 28, 2026
* adding manual buttons for zoom-in or zoom-out * add setting for disable/enable zoom buttons * moving buttons to bottom right * Change framing of setting to "enable", update default to `false` We think of this setting as "opt-in", so it makes sense for the box to initially be not checked. We want the default to be for the buttons to be hidden, so we need to change the setting from "disable" to "enable" to meet those conditions! Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com> * Adding icon for Jupytergis setting (geojupyter#1082) --------- Co-authored-by: Matt Fisher <mfisher87@gmail.com> Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com>
gjmooney
pushed a commit
to gjmooney/jupytergis
that referenced
this pull request
Feb 18, 2026
* adding manual buttons for zoom-in or zoom-out * add setting for disable/enable zoom buttons * moving buttons to bottom right * Change framing of setting to "enable", update default to `false` We think of this setting as "opt-in", so it makes sense for the box to initially be not checked. We want the default to be for the buttons to be hidden, so we need to change the setting from "disable" to "enable" to meet those conditions! Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com> * Adding icon for Jupytergis setting (geojupyter#1082) --------- Co-authored-by: Matt Fisher <mfisher87@gmail.com> Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding manual buttons for zoom-in or zoom-out as discussed in #939
Screencast.From.2026-01-04.14-48-45.mp4
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--1055.org.readthedocs.build/en/1055/
💡 JupyterLite preview: https://jupytergis--1055.org.readthedocs.build/en/1055/lite