Add Story mode presentation toggle button to toolbar#1056
Merged
martinRenou merged 5 commits intogeojupyter:mainfrom Jan 27, 2026
Merged
Add Story mode presentation toggle button to toolbar#1056martinRenou merged 5 commits intogeojupyter:mainfrom
martinRenou merged 5 commits intogeojupyter:mainfrom
Conversation
Contributor
|
|
Contributor
|
Integration tests report: appsharing.space |
gjmooney
force-pushed
the
add-presentation-toggle
branch
from
1b592f9 to
7cef6c1
Compare
martinRenou
requested changes
Jan 16, 2026
packages/base/src/constants.ts
Outdated
| [CommandIDs.temporalController]: { icon: clockIcon }, | ||
| [CommandIDs.addMarker]: { icon: markerIcon }, | ||
| [CommandIDs.addStorySegment]: { iconClass: 'fa fa-link' }, | ||
| [CommandIDs.toggleStoryPresentationMode]: { iconClass: 'fa fa-dragon' }, |
Member
There was a problem hiding this comment.
? dragon? 😆
May I suggest this instead?
Suggested change
| [CommandIDs.toggleStoryPresentationMode]: { iconClass: 'fa fa-dragon' }, | |
| [CommandIDs.toggleStoryPresentationMode]: { iconClass: 'fa fa-book-open-reader' }, |
Collaborator
Author
There was a problem hiding this comment.
Dragons go in stories! It makes sense! 🤣
Collaborator
Author
|
bot please update snapshots |
gjmooney
force-pushed
the
add-presentation-toggle
branch
from
3d74b33 to
8711aee
Compare
Collaborator
Author
|
bot please update snapshots |
1 similar comment
Collaborator
Author
|
bot please update snapshots |
martinRenou
force-pushed
the
add-presentation-toggle
branch
from
9d57dcd to
c9a64bb
Compare
gjmooney
added a commit
to gjmooney/jupytergis
that referenced
this pull request
Feb 18, 2026
* Add Story mode presentation toggle button to toolbar * Lint * Update story toggle icon * Update Playwright Snapshots * Disable toggle presentation button when no segments & change icon --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a story mode presentation toggle button to the toolbar
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--1056.org.readthedocs.build/en/1056/
💡 JupyterLite preview: https://jupytergis--1056.org.readthedocs.build/en/1056/lite