From f0fd5944761fb0639c6caa294c0eb318bad08a83 Mon Sep 17 00:00:00 2001 From: arjxn-py Date: Mon, 20 Jan 2025 19:03:27 +0530 Subject: [PATCH 1/3] Keep extension package name `extension-artifacts` for 3.12 --- .github/workflows/build.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b21b791e9..a70311a1d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -71,7 +71,7 @@ jobs: - name: Upload extension packages uses: actions/upload-artifact@v4 with: - name: extension-artifacts-${{ matrix.python-version }} + name: ${{ matrix.python-version == '3.12' && 'extension-artifacts' || format('extension-artifacts-{0}', matrix.python-version) }} path: | python/jupytergis_core/dist/jupytergis* python/jupytergis_lab/dist/jupytergis* @@ -121,7 +121,7 @@ jobs: steps: - uses: actions/download-artifact@v4 with: - name: extension-artifacts-3.12 + name: extension-artifacts - name: Install and Test shell: bash -l {0} @@ -166,7 +166,7 @@ jobs: - name: Download extension package uses: actions/download-artifact@v4 with: - name: extension-artifacts-3.12 + name: extension-artifacts - name: Install the extension shell: bash -l {0} @@ -279,7 +279,7 @@ jobs: - name: Download extension package uses: actions/download-artifact@v4 with: - name: extension-artifacts-3.12 + name: extension-artifacts - name: Install the extension shell: bash -l {0} From 1174933a1fc793c52077b339436cb81d164c35ce Mon Sep 17 00:00:00 2001 From: arjxn-py Date: Mon, 20 Jan 2025 19:05:47 +0530 Subject: [PATCH 2/3] log extension package name just to test --- .github/workflows/build.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a70311a1d..35199b6d5 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -68,6 +68,10 @@ jobs: pip install hatch yarn build:packages + - name: Log extension package name + run: | + echo "Extension package name: ${{ matrix.python-version == '3.12' && 'extension-artifacts' || format('extension-artifacts-{0}', matrix.python-version) }}" + - name: Upload extension packages uses: actions/upload-artifact@v4 with: From 4c7f69551ea8e93546c1581c9eaa97249c73f2eb Mon Sep 17 00:00:00 2001 From: arjxn-py Date: Mon, 20 Jan 2025 19:14:57 +0530 Subject: [PATCH 3/3] Remove logging --- .github/workflows/build.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 35199b6d5..a70311a1d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -68,10 +68,6 @@ jobs: pip install hatch yarn build:packages - - name: Log extension package name - run: | - echo "Extension package name: ${{ matrix.python-version == '3.12' && 'extension-artifacts' || format('extension-artifacts-{0}', matrix.python-version) }}" - - name: Upload extension packages uses: actions/upload-artifact@v4 with: