-
-
Notifications
You must be signed in to change notification settings - Fork 229
Expand file tree
/
Copy pathSentryGraphQlHttpFailedRequestHandlerTests.cs
More file actions
336 lines (279 loc) · 11.7 KB
/
SentryGraphQlHttpFailedRequestHandlerTests.cs
File metadata and controls
336 lines (279 loc) · 11.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
namespace Sentry.Tests;
public class SentryGraphQlHttpFailedRequestHandlerTests
{
private const string ValidQuery = "query getAllNotes { notes { id } }";
private const string DefaultErrorMessage = "Bad query";
private const string DefaultErrorCode = "BAD_OP";
private static HttpResponseMessage ForbiddenResponse()
=> new(HttpStatusCode.Forbidden);
private static HttpResponseMessage InternalServerErrorResponse()
=> new(HttpStatusCode.InternalServerError);
private HttpResponseMessage PreconditionFailedResponse()
=> new(HttpStatusCode.PreconditionFailed)
{
Content = SentryGraphQlTestHelpers.ErrorContent(DefaultErrorMessage, DefaultErrorCode)
};
[Fact]
public void HandleResponse_Disabled_DontCapture()
{
// Arrange
var hub = Substitute.For<IHub>();
var options = new SentryOptions
{
CaptureFailedRequests = false
};
var sut = new SentryGraphQLHttpFailedRequestHandler(hub, options);
var response = InternalServerErrorResponse();
response.RequestMessage = new HttpRequestMessage();
// Act
sut.HandleResponse(response);
// Assert
hub.DidNotReceive().CaptureEvent(Arg.Any<SentryEvent>());
}
[Fact]
public void HandleResponse_RequestsToSentryDsn_DontCapture()
{
// Arrange
var hub = Substitute.For<IHub>();
var options = new SentryOptions
{
CaptureFailedRequests = true,
Dsn = ValidDsn
};
var sut = new SentryGraphQLHttpFailedRequestHandler(hub, options);
var response = InternalServerErrorResponse();
response.RequestMessage = new HttpRequestMessage(HttpMethod.Post, options.Dsn);
// Act
sut.HandleResponse(response);
// Assert
hub.DidNotReceive().CaptureEvent(Arg.Any<SentryEvent>());
}
[Fact]
public void HandleResponse_NoMatchingTarget_DontCapture()
{
// Arrange
var hub = Substitute.For<IHub>();
var options = new SentryOptions
{
CaptureFailedRequests = true,
FailedRequestTargets = new List<StringOrRegex> { "http://foo/" }
};
var sut = new SentryGraphQLHttpFailedRequestHandler(hub, options);
var response = InternalServerErrorResponse();
response.RequestMessage = new HttpRequestMessage(HttpMethod.Get, "http://bar/");
// Act
sut.HandleResponse(response);
// Assert
hub.DidNotReceive().CaptureEvent(Arg.Any<SentryEvent>());
}
[Fact]
public void HandleResponse_NoGraphQLError_HttpHandlerFallbackCapturesFailedRequests()
{
// Arrange
var hub = Substitute.For<IHub>();
var options = new SentryOptions
{
CaptureFailedRequests = true
};
var sut = new SentryGraphQLHttpFailedRequestHandler(hub, options);
// Response has valid JSON but no GraphQL errors - just HTTP error status
var response = new HttpResponseMessage(HttpStatusCode.InternalServerError)
{
Content = SentryGraphQlTestHelpers.JsonContent(new { data = "some response data" }),
RequestMessage = new HttpRequestMessage(HttpMethod.Post, "http://example.com/graphql")
};
// Act
SentryEvent @event = null;
hub.CaptureEvent(Arg.Do<SentryEvent>(e => @event = e), hint: Arg.Any<SentryHint>());
sut.HandleResponse(response);
// Assert
hub.Received(1).CaptureEvent(
Arg.Any<SentryEvent>(),
Arg.Any<Scope>(), Arg.Any<SentryHint>());
// Should fall back to HTTP handler, capturing HttpRequestException
@event.Exception.Should().BeOfType<HttpRequestException>();
@event.Exception!.Message.Should().NotBeNullOrWhiteSpace();
}
[Fact]
public void HandleResponse_Error_Capture()
{
// Arrange
var hub = Substitute.For<IHub>();
var options = new SentryOptions
{
CaptureFailedRequests = true
};
var sut = new SentryGraphQLHttpFailedRequestHandler(hub, options);
var response = PreconditionFailedResponse();
response.RequestMessage = SentryGraphQlTestHelpers.GetRequestQuery(ValidQuery);
// Act
SentryEvent @event = null;
hub.CaptureEvent(Arg.Do<SentryEvent>(e => @event = e), hint: Arg.Any<SentryHint>());
sut.HandleResponse(response);
// Assert
hub.Received(1).CaptureEvent(
Arg.Any<SentryEvent>(),
Arg.Any<Scope>(), Arg.Any<SentryHint>());
// Verify it's actually a GraphQL error, not HTTP error fallback
@event.Exception.Should().BeOfType<GraphQLHttpRequestException>();
@event.Exception!.Message.Should().Be(DefaultErrorMessage);
}
[Fact]
public void HandleResponse_Error_DontSendPii()
{
// Arrange
var hub = Substitute.For<IHub>();
var options = new SentryOptions
{
CaptureFailedRequests = true
};
var sut = new SentryGraphQLHttpFailedRequestHandler(hub, options);
var response = PreconditionFailedResponse();
var uri = new Uri("http://admin:1234@localhost/test/path?query=string#fragment");
response.RequestMessage = SentryGraphQlTestHelpers.GetRequestQuery(ValidQuery, uri.ToString());
// Act
SentryEvent @event = null;
hub.CaptureEvent(Arg.Do<SentryEvent>(e => @event = e), hint: Arg.Any<SentryHint>());
sut.HandleResponse(response);
// Assert
@event.Exception.Should().BeOfType<GraphQLHttpRequestException>();
@event.Request.Url.Should().Be("http://localhost/test/path?query=string"); // No admin:1234
@event.Request.Data.Should().BeNull();
var responseContext = @event.Contexts[Response.Type] as Response;
responseContext?.Data.Should().BeNull();
}
[Fact]
public void HandleResponse_Error_CaptureRequestAndResponse()
{
// Arrange
var hub = Substitute.For<IHub>();
var options = new SentryOptions
{
CaptureFailedRequests = true,
SendDefaultPii = true
};
var sut = new SentryGraphQLHttpFailedRequestHandler(hub, options);
var query = ValidQuery;
var url = "http://foo/bar/hello";
var response = PreconditionFailedResponse();
response.RequestMessage = SentryGraphQlTestHelpers.GetRequestQuery(query, url);
var requestContent = new GraphQLRequestContent(SentryGraphQlTestHelpers.WrapRequestContent(query));
response.RequestMessage!.SetFused(requestContent);
response.Headers.Add("myHeader", "myValue");
SentryEvent @event = null;
hub.CaptureEvent(
Arg.Do<SentryEvent>(e => @event = e),
hint: Arg.Any<SentryHint>()
);
// Act
sut.HandleResponse(response);
// Assert
using (new AssertionScope())
{
@event.Should().NotBeNull();
// Ensure it's a GraphQL exception (not HTTP fallback)
@event.Exception.Should().BeOfType<GraphQLHttpRequestException>();
@event.Exception!.Message.Should().Be(DefaultErrorMessage);
// Ensure the mechanism is set
@event.Exception?.Data[Mechanism.MechanismKey].Should().Be(SentryGraphQLHttpFailedRequestHandler.MechanismType);
@event.Exception?.Data[Mechanism.HandledKey].Should().Be(false);
// Ensure the request properties are captured
@event.Request.Method.Should().Be(HttpMethod.Post.ToString());
@event.Request.Url.Should().Be(url);
@event.Request.ApiTarget.Should().Be("graphql");
@event.Request.Data.Should().Be(SentryGraphQlTestHelpers.WrapRequestContent(query));
// Ensure the response context is captured
@event.Contexts.Should().Contain(x => x.Key == Response.Type && x.Value is Response);
var responseContext = @event.Contexts[Response.Type] as Response;
responseContext?.StatusCode.Should().Be((short)response.StatusCode);
responseContext?.BodySize.Should().Be(response.Content.Headers.ContentLength);
responseContext?.Data?.ToString().Should().Be(
SentryGraphQlTestHelpers.ErrorContent(DefaultErrorMessage, DefaultErrorCode).ReadAsJson().ToString()
);
@event.Contexts.Response.Headers.Should().ContainKey("myHeader");
@event.Contexts.Response.Headers.Should().ContainValue("myValue");
// The fingerprints field should be set to ["$operationName", "$operationType", "$statusCode"].
@event.Fingerprint.Should().BeEquivalentTo(
"getAllNotes", "query", $"{(int)HttpStatusCode.PreconditionFailed}"
);
}
}
[Fact]
public void HandleResponse_Error_ResponseAsHint()
{
// Arrange
var hub = Substitute.For<IHub>();
var options = new SentryOptions
{
CaptureFailedRequests = true
};
var sut = new SentryGraphQLHttpFailedRequestHandler(hub, options);
var response = PreconditionFailedResponse(); // This is in the range
response.RequestMessage = SentryGraphQlTestHelpers.GetRequestQuery(ValidQuery);
// Act
SentryHint hint = null;
hub.CaptureEvent(
Arg.Any<SentryEvent>(),
hint: Arg.Do<SentryHint>(h => hint = h)
);
sut.HandleResponse(response);
// Assert
using (new AssertionScope())
{
hint.Should().NotBeNull();
// Response should be captured
hint.Items[HintTypes.HttpResponseMessage].Should().Be(response);
}
}
[Fact]
public void HandleResponse_GraphQLError_HasExceptionWithStackTrace()
{
// Arrange
var hub = Substitute.For<IHub>();
var options = new SentryOptions
{
CaptureFailedRequests = true
};
var sut = new SentryGraphQLHttpFailedRequestHandler(hub, options);
var response = PreconditionFailedResponse();
response.RequestMessage = SentryGraphQlTestHelpers.GetRequestQuery(ValidQuery);
// Act
SentryEvent @event = null;
hub.CaptureEvent(Arg.Do<SentryEvent>(e => @event = e), hint: Arg.Any<SentryHint>());
sut.HandleResponse(response);
// Assert
using (new AssertionScope())
{
@event.Should().NotBeNull();
@event.Exception.Should().NotBeNull();
@event.Exception!.StackTrace.Should().NotBeNullOrWhiteSpace();
}
}
#if NET5_0_OR_GREATER // This test is only valid on .NET 5+ where we can use SetCurrentStackTrace
[Fact]
public void HandleResponse_GraphQLError_ExceptionStackTraceHasCallerContext()
{
// Arrange
var hub = Substitute.For<IHub>();
var options = new SentryOptions
{
CaptureFailedRequests = true
};
var sut = new SentryGraphQLHttpFailedRequestHandler(hub, options);
var response = PreconditionFailedResponse();
response.RequestMessage = SentryGraphQlTestHelpers.GetRequestQuery(ValidQuery);
// Act
SentryEvent @event = null;
hub.CaptureEvent(Arg.Do<SentryEvent>(e => @event = e), hint: Arg.Any<SentryHint>());
sut.HandleResponse(response);
// Assert
using (new AssertionScope())
{
@event.Should().NotBeNull();
@event.Exception.Should().NotBeNull();
// Exception's stack trace should include this test method name, proving we captured caller context on .NET 5+
@event.Exception!.StackTrace.Should().Contain(nameof(HandleResponse_GraphQLError_ExceptionStackTraceHasCallerContext));
}
}
#endif
}