feat(srcsrv): Extend symbolic to extract the srcsrv integration name for metrics (#944)

* feat(srcsrv): Update symbolic to extract the srcsrv integration name for metrics

---------

Co-authored-by: Sebastian Zivota <loewenheim@users.noreply.github.com>

Author: mujacica

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## Unreleased
+
+- feat(pdb): Extract the srcsrv integration name for metrics ([#944](https://github.com/getsentry/symbolic/pull/944))
+
 ## 12.16.3
 
 - feat(elf): Added support for dynamic symbols when DYNAMIC segment is missing. ([#935](https://github.com/getsentry/symbolic/pull/935))

Cargo.lock

@@ -69,6 +69,7 @@ ms = [
     "pdb-addr2line",
     "scroll",
     "smallvec",
+    "srcsrv",
 ]
 ppdb = ["symbolic-ppdb"]
 # Source bundle creation
@@ -106,6 +107,7 @@ scroll = { workspace = true, optional = true }
 serde = { workspace = true }
 serde_json = { workspace = true, optional = true }
 smallvec = { workspace = true, optional = true }
+srcsrv = { version = "0.2", optional = true }
 symbolic-common = { version = "12.16.3", path = "../symbolic-common" }
 symbolic-ppdb = { version = "12.16.3", path = "../symbolic-ppdb", optional = true }
 thiserror = { workspace = true }

symbolic-debuginfo/Cargo.toml

@@ -16,6 +16,7 @@ use pdb_addr2line::pdb::{
 };
 use pdb_addr2line::ModuleProvider;
 use smallvec::SmallVec;
+use srcsrv;
 use thiserror::Error;
 
 use symbolic_common::{
@@ -251,6 +252,31 @@ impl<'data> PdbObject<'data> {
         false
     }
 
+    /// Returns the SRCSRV VCS integration name if available.
+    ///
+    /// This extracts the version control system identifier from the SRCSRV stream,
+    /// if present. Common values include "perforce", "tfs", "git", etc.
+    /// Returns `None` if no SRCSRV stream exists or if it cannot be parsed.
+    pub fn srcsrv_vcs_name(&self) -> Option<String> {
+        let mut pdb = self.pdb.write();
+
+        // Try to open the "srcsrv" named stream
+        let stream = match pdb.named_stream(b"srcsrv") {
+            Ok(stream) => stream,
+            Err(_) => return None,
+        };
+
+        // Parse the stream to extract VCS name
+        let stream_data = stream.as_slice();
+        if let Ok(parsed_stream) = srcsrv::SrcSrvStream::parse(stream_data) {
+            parsed_stream
+                .version_control_description()
+                .map(|s| s.to_string())
+        } else {
+            None
+        }
+    }
+
     /// Determines whether this object is malformed and was only partially parsed
     pub fn is_malformed(&self) -> bool {
         false

symbolic-debuginfo/src/pdb.rs

@@ -0,0 +1,29 @@
+use symbolic_common::ByteView;
+use symbolic_debuginfo::pdb::PdbObject;
+use symbolic_testutils::fixture;
+
+type Error = Box<dyn std::error::Error>;
+
+#[test]
+fn test_pdb_srcsrv_vcs_name() -> Result<(), Error> {
+    let view = ByteView::open(fixture("windows/crash_with_srcsrv.pdb"))?;
+    let pdb = PdbObject::parse(&view)?;
+
+    // This PDB file contains Perforce SRCSRV information
+    let vcs_name = pdb.srcsrv_vcs_name();
+    assert_eq!(vcs_name, Some("Perforce".to_string()));
+
+    Ok(())
+}
+
+#[test]
+fn test_pdb_without_srcsrv() -> Result<(), Error> {
+    let view = ByteView::open(fixture("windows/crash.pdb"))?;
+    let pdb = PdbObject::parse(&view)?;
+
+    // This PDB file does not contain SRCSRV information
+    let vcs_name = pdb.srcsrv_vcs_name();
+    assert_eq!(vcs_name, None);
+
+    Ok(())
+}