Skip to content

Commit ff0a822

Browse files
committed
Fix hot fix
In 1ff8966 (Hot fix: accommodate for (silent?) change in GitHub API's condition parsing, 2026-01-15), I tried to work around a silent change on GitHub's backend side. The change that broke Git for Windows' automation was that the `created=>${after}` search parameter no longer worked. In my frantic search for a hot fix, I failed to realize that the `=` in this construct is not actually part of the condition, but it is the assignment of a `GET` parameter. And the change on GitHub's side is simply that the `>${date}` condition no longer works, at all. The hot fix changed the order of `>` and `=`, which made the greater-than character part of the `GET` parameter's name: `create>`. As my excellent colleague Matthew Cheetham figured out, the equally documented form `${date}..` of that date condition _does_ work, still. So I guess some eager engineer simply forgot that there are multiple documented ways to specify date ranges, and they accidentally dropped support for one of them. Unfortunately, that was the form we used. So let's now use the other instead. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
1 parent 2c933ff commit ff0a822

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

GitGitGadget/trigger-workflow-dispatch.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ const waitForWorkflowRun = async (context, token, owner, repo, workflow_id, afte
2626
context,
2727
token,
2828
'GET',
29-
`/repos/${owner}/${repo}/actions/runs?actor=${actor}&event=workflow_dispatch&created>=${after}`
29+
`/repos/${owner}/${repo}/actions/runs?actor=${actor}&event=workflow_dispatch&created=${after}..`
3030
)
3131
const filtered = res.workflow_runs.filter(e => e.path === `.github/workflows/${workflow_id}` && after.localeCompare(e.created_at) <= 0)
3232
if (filtered.length > 0) return filtered

0 commit comments

Comments
 (0)