Skip to content

Commit 3d53374

Browse files
committed
adding correct insiders-mode name
1 parent 15e66b3 commit 3d53374

File tree

8 files changed

+21
-21
lines changed

8 files changed

+21
-21
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -530,21 +530,21 @@ The local GitHub MCP Server offers an insiders version with early access to new
530530
1. **Using Command Line Argument**:
531531

532532
```bash
533-
./github-mcp-server --insider-mode
533+
./github-mcp-server --insiders-mode
534534
```
535535

536536
2. **Using Environment Variable**:
537537

538538
```bash
539-
GITHUB_INSIDER_MODE=true ./github-mcp-server
539+
GITHUB_INSIDERS_MODE=true ./github-mcp-server
540540
```
541541

542542
When using Docker:
543543

544544
```bash
545545
docker run -i --rm \
546546
-e GITHUB_PERSONAL_ACCESS_TOKEN=<your-token> \
547-
-e GITHUB_INSIDER_MODE=true \
547+
-e GITHUB_INSIDERS_MODE=true \
548548
ghcr.io/github/github-mcp-server
549549
```
550550

cmd/github-mcp-server/main.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ var (
8383
LogFilePath: viper.GetString("log-file"),
8484
ContentWindowSize: viper.GetInt("content-window-size"),
8585
LockdownMode: viper.GetBool("lockdown-mode"),
86-
InsiderMode: viper.GetBool("insider-mode"),
86+
InsidersMode: viper.GetBool("insiders-mode"),
8787
RepoAccessCacheTTL: &ttl,
8888
}
8989
return ghmcp.RunStdioServer(stdioServerConfig)
@@ -109,7 +109,7 @@ func init() {
109109
rootCmd.PersistentFlags().String("gh-host", "", "Specify the GitHub hostname (for GitHub Enterprise etc.)")
110110
rootCmd.PersistentFlags().Int("content-window-size", 5000, "Specify the content window size")
111111
rootCmd.PersistentFlags().Bool("lockdown-mode", false, "Enable lockdown mode")
112-
rootCmd.PersistentFlags().Bool("insider-mode", false, "Enable insider features")
112+
rootCmd.PersistentFlags().Bool("insiders-mode", false, "Enable insiders features")
113113
rootCmd.PersistentFlags().Duration("repo-access-cache-ttl", 5*time.Minute, "Override the repo access cache TTL (e.g. 1m, 0s to disable)")
114114

115115
// Bind flag to viper
@@ -124,7 +124,7 @@ func init() {
124124
_ = viper.BindPFlag("host", rootCmd.PersistentFlags().Lookup("gh-host"))
125125
_ = viper.BindPFlag("content-window-size", rootCmd.PersistentFlags().Lookup("content-window-size"))
126126
_ = viper.BindPFlag("lockdown-mode", rootCmd.PersistentFlags().Lookup("lockdown-mode"))
127-
_ = viper.BindPFlag("insider-mode", rootCmd.PersistentFlags().Lookup("insider-mode"))
127+
_ = viper.BindPFlag("insiders-mode", rootCmd.PersistentFlags().Lookup("insiders-mode"))
128128
_ = viper.BindPFlag("repo-access-cache-ttl", rootCmd.PersistentFlags().Lookup("repo-access-cache-ttl"))
129129

130130
// Add subcommands

docs/remote-server.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ The Remote GitHub MCP server has optional headers equivalent to the Local server
6868
- Equivalent to `GITHUB_LOCKDOWN_MODE` env var for Local server.
6969
- If this header is empty, "false", "f", "no", "n", "0", or "off" (ignoring whitespace and case), it will be interpreted as false. All other values are interpreted as true.
7070
- `X-MCP-Insiders`: Enables insiders mode for early access to new features.
71-
- Equivalent to `GITHUB_INSIDER_MODE` env var or `--insider-mode` flag for Local server.
71+
- Equivalent to `GITHUB_INSIDERS_MODE` env var or `--insiders-mode` flag for Local server.
7272
- If this header is empty, "false", "f", "no", "n", "0", or "off" (ignoring whitespace and case), it will be interpreted as false. All other values are interpreted as true.
7373

7474
> **Looking for examples?** See the [Server Configuration Guide](./server-configuration.md) for common recipes like minimal setups, read-only mode, and combining tools with toolsets.

internal/ghmcp/server.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ type MCPServerConfig struct {
6464
// LockdownMode indicates if we should enable lockdown mode
6565
LockdownMode bool
6666

67-
// Insider indicates if we should enable experimental features
68-
InsiderMode bool
67+
// InsidersMode indicates if we should enable experimental features
68+
InsidersMode bool
6969

7070
// Logger is used for logging within the server
7171
Logger *slog.Logger
@@ -227,7 +227,7 @@ func NewMCPServer(cfg MCPServerConfig) (*mcp.Server, error) {
227227
cfg.Translator,
228228
github.FeatureFlags{
229229
LockdownMode: cfg.LockdownMode,
230-
InsiderMode: cfg.InsiderMode,
230+
InsidersMode: cfg.InsidersMode,
231231
},
232232
cfg.ContentWindowSize,
233233
featureChecker,
@@ -331,8 +331,8 @@ type StdioServerConfig struct {
331331
// LockdownMode indicates if we should enable lockdown mode
332332
LockdownMode bool
333333

334-
// InsiderMode indicates if we should enable experimental features
335-
InsiderMode bool
334+
// InsidersMode indicates if we should enable experimental features
335+
InsidersMode bool
336336

337337
// RepoAccessCacheTTL overrides the default TTL for repository access cache entries.
338338
RepoAccessCacheTTL *time.Duration
@@ -390,7 +390,7 @@ func RunStdioServer(cfg StdioServerConfig) error {
390390
Translator: t,
391391
ContentWindowSize: cfg.ContentWindowSize,
392392
LockdownMode: cfg.LockdownMode,
393-
InsiderMode: cfg.InsiderMode,
393+
InsidersMode: cfg.InsidersMode,
394394
Logger: logger,
395395
RepoAccessTTL: cfg.RepoAccessCacheTTL,
396396
TokenScopes: tokenScopes,

internal/ghmcp/server_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ func TestNewMCPServer_CreatesSuccessfully(t *testing.T) {
2323
Translator: translations.NullTranslationHelper,
2424
ContentWindowSize: 5000,
2525
LockdownMode: false,
26-
InsiderMode: false,
26+
InsidersMode: false,
2727
}
2828

2929
// Create the server

pkg/github/feature_flags.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@ package github
33
// FeatureFlags defines runtime feature toggles that adjust tool behavior.
44
type FeatureFlags struct {
55
LockdownMode bool
6-
InsiderMode bool
6+
InsidersMode bool
77
}

pkg/github/feature_flags_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ func HelloWorldTool(t translations.TranslationHelperFunc) inventory.ServerTool {
4545
if deps.IsFeatureEnabled(ctx, RemoteMCPEnthusiasticGreeting) {
4646
greeting += " Welcome to the future of MCP! 🎉"
4747
}
48-
if deps.GetFlags().InsiderMode {
48+
if deps.GetFlags().InsidersMode {
4949
greeting += " Experimental features are enabled! 🚀"
5050
}
5151

@@ -140,17 +140,17 @@ func TestHelloWorld_ConditionalBehavior_Config(t *testing.T) {
140140

141141
tests := []struct {
142142
name string
143-
insiderMode bool
143+
insidersMode bool
144144
expectedGreeting string
145145
}{
146146
{
147147
name: "Experimental disabled - default greeting",
148-
insiderMode: false,
148+
insidersMode: false,
149149
expectedGreeting: "Hello, world!",
150150
},
151151
{
152152
name: "Experimental enabled - experimental greeting",
153-
insiderMode: true,
153+
insidersMode: true,
154154
expectedGreeting: "Hello, world! Experimental features are enabled! 🚀",
155155
},
156156
}
@@ -163,7 +163,7 @@ func TestHelloWorld_ConditionalBehavior_Config(t *testing.T) {
163163
deps := NewBaseDeps(
164164
nil, nil, nil, nil,
165165
translations.NullTranslationHelper,
166-
FeatureFlags{InsiderMode: tt.insiderMode},
166+
FeatureFlags{InsidersMode: tt.insidersMode},
167167
0,
168168
nil,
169169
)

pkg/github/server_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ func stubRepoAccessCache(client *githubv4.Client, ttl time.Duration) *lockdown.R
8484
func stubFeatureFlags(enabledFlags map[string]bool) FeatureFlags {
8585
return FeatureFlags{
8686
LockdownMode: enabledFlags["lockdown-mode"],
87-
InsiderMode: enabledFlags["insider-mode"],
87+
InsidersMode: enabledFlags["insiders-mode"],
8888
}
8989
}
9090

0 commit comments

Comments
 (0)