-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Open
Labels
under-discussionBeing considered or is under active discussionBeing considered or is under active discussion
Milestone
Description
I noticed that gitlens created a terminal for me just now:
After it completed I continued on using the terminal like normal but later realized the title was set to Gitlens which can't be changed.
I was thinking a better way to approach this might be to do something like this:
window.createTerminal({
name: "GitLens", // + " (revert)"?
cwd: "/Users/daimms/dev/microsoft/vscode",
shellPath: "bash",
shellArgs: ["-c", `git revert ${hash}`]
});That way the terminal would be short lived only for this action, it would close immediately after running the command right now but if you think this is a good idea and would adopt we can look into adding waitOnExit to the API: microsoft/vscode#70444
I think another option is for the extension to contribute tasks and run them which already leverage waitOnExit internally and should reuse the terminal.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
under-discussionBeing considered or is under active discussionBeing considered or is under active discussion
