Try to fix paratest

Author: AdrienClairembault

.gitignore

@@ -22,6 +22,9 @@ phpunit.xml
 /tests/cypress/downloads/
 /tests/cypress/videos/
 /tests/files/
+/tests/files-2/
+/tests/files-3/
+/tests/files-4/
 /tests/.env
 /nbproject
 .composer.hash

Makefile

@@ -177,6 +177,17 @@ test-db-update: ## Update testing's database
 		--env=testing
 .PHONY: test-db-update
 
+test-db-clone: ## Set up DBs for parallel test execution
+	@$(DB) bash -c ' \
+		for i in 2 3 4; do \
+			mariadb -u root -pglpi -e "DROP DATABASE IF EXISTS glpi_test_$$i"; \
+			mariadb -u root -pglpi -e "CREATE DATABASE glpi_test_$$i CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci;"; \
+			mariadb-dump -u root -pglpi --single-transaction glpi_test | mariadb -u root -pglpi glpi_test_$$i; \
+			echo "Database glpi_test_$$i created and populated"; \
+		done \
+	'
+.PHONY: test-db-clone
+
 e2e-db-install: ## Install e2e testing's database
 	@$(CONSOLE) database:install \
 		-r -f \
@@ -216,6 +227,11 @@ phpunit: ## Run phpunits tests, example: make phpunit c='tests/functional/Glpi/M
 	@$(PHP) php vendor/bin/phpunit $(c)
 .PHONY: phpunit
 
+paratest: ## Run paratest with 4 workers
+	@$(eval c ?=)
+	@$(PHP) php vendor/bin/paratest -p 4 --exclude-group "single-thread" $(c)
+.PHONY: paratest
+
 phpstan: ## Run phpstan
 	@$(eval c ?=)
 	@$(PHP) php vendor/bin/phpstan --memory-limit=1G $(c)

src/Glpi/Application/Environment.php

@@ -139,11 +139,13 @@ public static function validate(): void
      */
     public function getConstantsOverride(string $root_dir): array
     {
+        $test_token = getenv('TEST_TOKEN');
+
         return match ($this) {
             default => [],
             self::TESTING     => [
                 'GLPI_CONFIG_DIR'               => $root_dir . '/tests/config',
-                'GLPI_VAR_DIR'                  => $root_dir . '/tests/files',
+                'GLPI_VAR_DIR'                  => $root_dir . '/tests/files' . (($test_token !== false && $test_token !== '' && $test_token > 1) ? "-$test_token" : ''),
                 'GLPI_LOG_LVL'                  => LogLevel::DEBUG,
                 'GLPI_STRICT_ENV'               => true,
                 'GLPI_SERVERSIDE_URL_ALLOWLIST' => [

src/RuleCollection.php

@@ -879,7 +879,9 @@ public function moveRule($ID, $ref_ID, $type = self::MOVE_AFTER, $new_rule = fal
         $ruleDescription = new Rule();
 
         // Get actual ranking of Rule to move
-        $ruleDescription->getFromDB($ID);
+        if (!$ruleDescription->getFromDB($ID)) {
+            throw new RuntimeException("Failed to load rule");
+        }
         $old_rank = $ruleDescription->fields["ranking"];
 
         $max_ranking_criteria = [

tests/functional/Glpi/Api/HL/Controller/AdministrationControllerTest.php

@@ -39,7 +39,6 @@
 use Glpi\Http\Request;
 use Glpi\Tests\HLAPITestCase;
 use PHPUnit\Framework\Attributes\DataProvider;
-use PHPUnit\Framework\Attributes\Group;
 
 class AdministrationControllerTest extends HLAPITestCase
 {
@@ -305,7 +304,6 @@ private function addCustomUserPicture(int $user_id, string $picture_path)
         ]);
     }
 
-    #[Group('single-thread')]
     public function testGetMyPicture()
     {
         $this->login();
@@ -338,7 +336,6 @@ public function testGetMyPicture()
         });
     }
 
-    #[Group('single-thread')]
     public function testGetUserPictureByID()
     {
         $this->login();
@@ -364,7 +361,6 @@ public function testGetUserPictureByID()
         });
     }
 
-    #[Group('single-thread')]
     public function testGetUserPictureByUsername()
     {
         $this->login();

tests/functional/Glpi/Form/Export/FormSerializerTest.php

@@ -1574,7 +1574,6 @@ public function testExportAndImportItemQuestionWithInvalidItemsId(): void
         $this->assertEquals(0, (new QuestionTypeItem())->getDefaultValueItemId($question));
     }
 
-    #[Group('single-thread')]
     public function testExportAndImportWithCustomIcon(): void
     {
         // Arrange: create a form with a custom icon

tests/functional/Glpi/Form/Migration/FormMigrationTest.php

@@ -144,6 +144,7 @@ public static function tearDownAfterClass(): void
             $DB->dropTable($table['TABLE_NAME']);
         }
 
+        $DB->clearSchemaCache();
         parent::tearDownAfterClass();
     }
 

tests/functional/Glpi/Form/Migration/TargetsMigrationTest.php

@@ -146,6 +146,7 @@ public static function tearDownAfterClass(): void
             $DB->dropTable($table['TABLE_NAME']);
         }
 
+        $DB->clearSchemaCache();
         parent::tearDownAfterClass();
     }
 

tests/functional/Glpi/Inventory/Assets/AntivirusTest.php

@@ -38,9 +38,7 @@
 use Glpi\Inventory\Converter;
 use Glpi\Tests\AbstractInventoryAsset;
 use PHPUnit\Framework\Attributes\DataProvider;
-use PHPUnit\Framework\Attributes\Group;
 
-#[Group('single-thread')]
 class AntivirusTest extends AbstractInventoryAsset
 {
     public static function assetProvider(): array

tests/functional/Glpi/Inventory/Assets/BatteryTest.php

@@ -38,9 +38,7 @@
 use Glpi\Inventory\Converter;
 use Glpi\Tests\AbstractInventoryAsset;
 use PHPUnit\Framework\Attributes\DataProvider;
-use PHPUnit\Framework\Attributes\Group;
 
-#[Group('single-thread')]
 class BatteryTest extends AbstractInventoryAsset
 {
     public static function assetProvider(): array