About code formatting.

[Daylily-Zeleen]

I'm not sure which format tool is used in this project.
Could you please provide ".clang-format" to keep consistency in code style?

[nmerget]

Makes sense. Maybe we should just copy the files from Godot repository or do you have any recommendations?

[Daylily-Zeleen]

The code style of this repository is significantly different from Godot. I think use Godot's code style directly is not appropriate.

But I do prefer Godot's code style, I mostly work around Godot, so I usually copy the file from Godot repository.

[nmerget]

It would be totally fine to reformat the code if we ensure to format it everytime. Maybe we can add a linting step in GitHub actions

[Benjamin-Dobell]

Eep. Please don't reformat all the code. Whilst I agree that it would have been easier as a module to follow along with what Godot do internally, that's not how Alex started the project. If we can setup clang formatting to try adhere to his style and run it just on diffs that'd be okay. Otherwise when we reformat we break git blame, which would make the project much more difficult to work.

Formatting is fairly superficial, I know linting is standard practice these days but there are decades of projects (particularly C++) that got by just fine without automating it. Linting should be a convenience, but it's not convenient if it makes the code harder to work with by drastically altering line history.

[nmerget]

Eep. Please don't reformat all the code. Whilst I agree that it would have been easier as a module to follow along with what Godot do internally, that's not how Alex started the project. If we can setup clang formatting to try adhere to his style and run it just on diffs that'd be okay. Otherwise when we reformat we break git blame, which would make the project much more difficult to work.

Formatting is fairly superficial, I know linting is standard practice these days but there are decades of projects (particularly C++) that got by just fine without automating it. Linting should be a convenience, but it's not convenient if it makes the code harder to work with by drastically altering line history.

Maybe we can use a tool or AI to create a clang-format based on the current files?

[nmerget]

I tried to add a .clang-format to respect most of the current files, but there are some inconsistencies - most of the files have been changed :/

[randomdevpete]

Is breaking bit glame such a huge problem? I know it's annoying when you have to trace something back but the history is still there. Inconsistent formatting is much worse of a problem down the line, and for a young project it's better to standardise now.