From 4db4ef62b10cb10c7e9879fbe34f3654829a9f46 Mon Sep 17 00:00:00 2001 From: Anton Golub Date: Mon, 11 Aug 2025 09:42:46 +0300 Subject: [PATCH 1/2] refactor: `cd()` avoid arg mutation --- build/core.cjs | 5 ++--- src/core.ts | 4 +--- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/build/core.cjs b/build/core.cjs index 1c4f3dc22f..11fcbc3657 100644 --- a/build/core.cjs +++ b/build/core.cjs @@ -1098,9 +1098,8 @@ function syncCwd() { if ($[CWD] != import_node_process2.default.cwd()) import_node_process2.default.chdir($[CWD]); } function cd(dir) { - if (dir instanceof ProcessOutput) { - dir = dir.toString().trim(); - } + if (dir instanceof ProcessOutput) + return cd(dir.toString().trim()); $.log({ kind: "cd", dir, verbose: !$.quiet && $.verbose }); import_node_process2.default.chdir(dir); $[CWD] = import_node_process2.default.cwd(); diff --git a/src/core.ts b/src/core.ts index 7ad9d7c5c7..8ae7096130 100644 --- a/src/core.ts +++ b/src/core.ts @@ -1027,9 +1027,7 @@ function syncCwd() { } export function cd(dir: string | ProcessOutput) { - if (dir instanceof ProcessOutput) { - dir = dir.toString().trim() - } + if (dir instanceof ProcessOutput) return cd(dir.toString().trim()) $.log({ kind: 'cd', dir, verbose: !$.quiet && $.verbose }) process.chdir(dir) From fdf1d86768c4f86012d0a17ce10399e4ff96b878 Mon Sep 17 00:00:00 2001 From: Anton Golub Date: Mon, 11 Aug 2025 09:50:31 +0300 Subject: [PATCH 2/2] chore: jsr types imprs --- build/core.cjs | 3 +-- src/core.ts | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/build/core.cjs b/build/core.cjs index 11fcbc3657..b33284b305 100644 --- a/build/core.cjs +++ b/build/core.cjs @@ -1098,8 +1098,7 @@ function syncCwd() { if ($[CWD] != import_node_process2.default.cwd()) import_node_process2.default.chdir($[CWD]); } function cd(dir) { - if (dir instanceof ProcessOutput) - return cd(dir.toString().trim()); + if (dir instanceof ProcessOutput) return cd(dir.toString().trim()); $.log({ kind: "cd", dir, verbose: !$.quiet && $.verbose }); import_node_process2.default.chdir(dir); $[CWD] = import_node_process2.default.cwd(); diff --git a/src/core.ts b/src/core.ts index 8ae7096130..381981bc3a 100644 --- a/src/core.ts +++ b/src/core.ts @@ -1026,7 +1026,7 @@ function syncCwd() { if ($[CWD] != process.cwd()) process.chdir($[CWD]) } -export function cd(dir: string | ProcessOutput) { +export function cd(dir: string | ProcessOutput): void { if (dir instanceof ProcessOutput) return cd(dir.toString().trim()) $.log({ kind: 'cd', dir, verbose: !$.quiet && $.verbose })