chore: verify build health and remove rx samples

- Create scripts/verify_all.sh for local verification
- Update CI to run tests and lint
- Remove deprecated snippets/app-rx module
- Fix FireMarkers unit tests
- Update README with verification instructions

Author: dkhawk

.github/workflows/build.yml

@@ -99,7 +99,6 @@ jobs:
         ./gradlew :snippets:app-utils-ktx:assembleDebug
         ./gradlew :snippets:app-compose:assembleDebug
         ./gradlew :snippets:app-places-ktx:assembleDebug
-        ./gradlew :snippets:app-rx:assembleDebug
         ./gradlew :snippets:app-utils:assembleDebug
 
   build-tutorials:
@@ -119,13 +118,25 @@ jobs:
       run: |
         ./gradlew :tutorials:kotlin:Polygons:assembleDebug
 
-  test: # used as required status check
+  test:
     runs-on: ubuntu-latest
+    timeout-minutes: 60
     needs:
       - build-ApiDemos
       - build-WearOS
+      - build-FireMarkers
       - build-Snippets
       - build-tutorials
-      - build-FireMarkers
     steps:
-      - run: echo "Fail if all other steps are not successful"
+      - uses: actions/checkout@v4
+      - name: set up Java 21
+        uses: actions/setup-java@v4
+        with:
+          distribution: 'adopt'
+          java-version: '21'
+      
+      - name: Run Unit Tests
+        run: ./gradlew testDebugUnitTest
+      
+      - name: Run Lint
+        run: ./gradlew lintDebug

FireMarkers/app/src/test/java/com/example/firemarkers/viewmodel/MarkersViewModelTest.kt

@@ -156,7 +156,7 @@ class MarkersViewModelTest {
         listenerCaptor.firstValue.onCancelled(error)
         testDispatcher.scheduler.advanceUntilIdle()
 
-        assertThat(errorMessage).isEqualTo("DB error on animation: Test Error")
+        assertThat(errorMessage).isEqualTo("Database error (animation): Test Error")
         job.cancel()
     }
 }

FireMarkers/app/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker

@@ -0,0 +1 @@
+mock-maker-inline

README.md

@@ -43,6 +43,14 @@ To run the samples, you will need:
 1. In the welcome screen of Android Studio, select "Open an Existing project"
 1. Select one of the sample directories from this repository
 
+## verifying the build
+
+To verify that all samples build and pass tests, run:
+
+```bash
+./scripts/verify_all.sh
+```
+
 Alternatively, use the `gradlew build` command to build the project directly or download an APK
 under [releases](https://github.com/googlemaps/android-samples/releases).
 

gradle/gradle-daemon-jvm.properties

@@ -0,0 +1,13 @@
+#This file is generated by updateDaemonJvm
+toolchainUrl.FREE_BSD.AARCH64=https\://api.foojay.io/disco/v3.0/ids/c5760d82d08e6c26884debb23736ea57/redirect
+toolchainUrl.FREE_BSD.X86_64=https\://api.foojay.io/disco/v3.0/ids/879378f84c64b2c76003b97a32968399/redirect
+toolchainUrl.LINUX.AARCH64=https\://api.foojay.io/disco/v3.0/ids/c5760d82d08e6c26884debb23736ea57/redirect
+toolchainUrl.LINUX.X86_64=https\://api.foojay.io/disco/v3.0/ids/879378f84c64b2c76003b97a32968399/redirect
+toolchainUrl.MAC_OS.AARCH64=https\://api.foojay.io/disco/v3.0/ids/021e528cbed860c875a9016f29ee13c1/redirect
+toolchainUrl.MAC_OS.X86_64=https\://api.foojay.io/disco/v3.0/ids/6141bf023dcc7a96c47cad75c59b054e/redirect
+toolchainUrl.UNIX.AARCH64=https\://api.foojay.io/disco/v3.0/ids/c5760d82d08e6c26884debb23736ea57/redirect
+toolchainUrl.UNIX.X86_64=https\://api.foojay.io/disco/v3.0/ids/879378f84c64b2c76003b97a32968399/redirect
+toolchainUrl.WINDOWS.AARCH64=https\://api.foojay.io/disco/v3.0/ids/9b6bab41c3ef2acea6116b7821b8dc11/redirect
+toolchainUrl.WINDOWS.X86_64=https\://api.foojay.io/disco/v3.0/ids/a6eb06d81d82a782734ef3b616ba2684/redirect
+toolchainVendor=JETBRAINS
+toolchainVersion=21

gradle/libs.versions.toml

@@ -37,10 +37,8 @@ materialIconsExtended = "1.7.8"
 
 # Google Maps & Places
 mapsCompose = "7.0.0"
-mapsKtx = "5.2.2"
-mapsRx = "1.0.1"
+mapsKtx = "6.0.0"
 places = "5.1.1"
-placesRx = "1.0.1"
 playServicesMaps = "20.0.0"
 secretsGradlePlugin = "2.0.1"
 
@@ -67,7 +65,6 @@ firebaseDatabase = "22.0.1"
 
 # Third Party
 easypermissions = "3.0.0"
-rxlifecycle = "4.0.2"
 volley = "1.2.1"
 
 [libraries]
@@ -105,10 +102,8 @@ ui-tooling-preview = { module = "androidx.compose.ui:ui-tooling-preview", versio
 # Maps & Places
 maps-compose = { module = "com.google.maps.android:maps-compose", version.ref = "mapsCompose" }
 maps-ktx = { group = "com.google.maps.android", name = "maps-ktx", version.ref = "mapsKtx" }
-maps-rx = { module = "com.google.maps.android:maps-rx", version.ref = "mapsRx" }
 maps-utils-ktx = { group = "com.google.maps.android", name = "maps-utils-ktx", version.ref = "mapsKtx" }
 places = { group = "com.google.android.libraries.places", name = "places", version.ref = "places" }
-places-rx = { module = "com.google.maps.android:places-rx", version.ref = "placesRx" }
 play-services-maps = { group = "com.google.android.gms", name = "play-services-maps", version.ref = "playServicesMaps" }
 
 # Wear OS
@@ -142,7 +137,6 @@ firebase-database = { module = "com.google.firebase:firebase-database", version.
 
 # Third Party
 easypermissions = { group = "pub.devrel", name = "easypermissions", version.ref = "easypermissions" }
-rxlifecycle-android-lifecycle-kotlin = { module = "com.trello.rxlifecycle4:rxlifecycle-android-lifecycle-kotlin", version.ref = "rxlifecycle" }
 volley = { group = "com.android.volley", name = "volley", version.ref = "volley" }
 
 [plugins]

scripts/verify_all.sh

@@ -0,0 +1,74 @@
+#!/bin/bash
+# script: verify_all.sh
+# description: Builds and verifies all Android modules in the project.
+
+set -e # Exit immediately if a command exits with a non-zero status.
+
+# Colors for output
+GREEN='\033[0;32m'
+RED='\033[0;31m'
+NC='\033[0m' # No Color
+
+echo "Starting project verification..."
+
+# List of modules to check
+# Note: snippets has submodules, checking root snippets project might be enough if it aggregates them,
+# but we'll be explicit or use standard tasks.
+MODULES=(
+    ":ApiDemos:java-app"
+    ":ApiDemos:kotlin-app"
+    ":ApiDemos:common-ui"
+    ":FireMarkers:app"
+    ":WearOS:Wearable"
+    ":snippets:app"
+    ":snippets:app-ktx"
+    ":snippets:app-utils-ktx"
+    ":snippets:app-compose"
+    ":snippets:app-places-ktx"
+    ":snippets:app-utils"
+    ":tutorials:kotlin:Polygons"
+)
+
+# Function to run verification for a module
+verify_module() {
+    local module=$1
+    echo "------------------------------------------------"
+    # Determine variant-specific tasks
+    local assembleTask=":assembleDebug"
+    local testTask=":testDebugUnitTest"
+    local lintTask=":lintDebug"
+
+    if [[ "$module" == ":snippets:app" ]]; then
+        assembleTask=":assembleGmsDebug"
+        testTask=":testGmsDebugUnitTest"
+        lintTask=":lintGmsDebug"
+    fi
+
+    # Run assemble, lint, and test
+    if ./gradlew "$module$assembleTask" "$module$testTask" "$module$lintTask"; then
+         echo -e "${GREEN}SUCCESS: $module verified.${NC}"
+    else
+         echo -e "${RED}FAILURE: $module failed verification.${NC}"
+         return 1
+    fi
+}
+
+FAILED_MODULES=()
+
+for module in "${MODULES[@]}"; do
+    if ! verify_module "$module"; then
+        FAILED_MODULES+=("$module")
+    fi
+done
+
+echo "------------------------------------------------"
+if [ ${#FAILED_MODULES[@]} -eq 0 ]; then
+    echo -e "${GREEN}ALL MODULES PASSED VERIFICATION.${NC}"
+    exit 0
+else
+    echo -e "${RED}THE FOLLOWING MODULES FAILED:${NC}"
+    for failed in "${FAILED_MODULES[@]}"; do
+        echo -e "${RED}- $failed${NC}"
+    done
+    exit 1
+fi

settings.gradle.kts

@@ -22,6 +22,9 @@ pluginManagement {
         gradlePluginPortal()
     }
 }
+plugins {
+    id("org.gradle.toolchains.foojay-resolver-convention") version "1.0.0"
+}
 // [END maps_android_settings_plugin_management]
 
 // [START maps_android_settings_dependency_resolution_management]
@@ -64,8 +67,6 @@ include(":snippets:app-compose")
 project(":snippets:app-compose").projectDir = file("snippets/app-compose")
 include(":snippets:app-places-ktx")
 project(":snippets:app-places-ktx").projectDir = file("snippets/app-places-ktx")
-include(":snippets:app-rx")
-project(":snippets:app-rx").projectDir = file("snippets/app-rx")
 include(":snippets:app-utils")
 project(":snippets:app-utils").projectDir = file("snippets/app-utils")