Attempt to make sync and async versions

Author: AstraLuma

gqlmod_github/__init__.py

@@ -6,7 +6,6 @@
 
 import graphql
 
-from gqlmod.helpers.urllib import UrllibJsonProvider
 from gqlmod.helpers.utils import walk_query, walk_variables, unwrap_type
 
 
@@ -25,27 +24,27 @@ def find_directive(ast_node, name):
     }
 
 
-class GitHubProvider(UrllibJsonProvider):
+class GitHubBaseProvider:
     endpoint = 'https://api.github.com/graphql'
 
     def __init__(self, token=None):
         self.token = token
 
-    def build_request(self, query, variables):
+    def _build_accept_header(self, variables):
         previews = variables.pop('__previews', None)
-        req = super().build_request(query, variables)
         if previews:
             # XXX: Can github accept more than one preview at once?
-            req.add_header('Accept', ', '.join(
+            return ', '.join(
                 f"application/vnd.github.{p}+json"
                 for p in previews
-            ))
-        return req
+            )
+        else:
+            return "application/json"
 
-    def modify_request(self, req, variables):
-        if self.token:
-            req.add_header('Authorization', f"Bearer {self.token}")
+    def _build_authorization_header(self, variables):
+        return f"Bearer {self.token}"
 
+    # This can't be async
     def get_schema_str(self):
         with urllib.request.urlopen("https://developer.github.com/v4/public_schema/schema.public.graphql") as fobj:
             return fobj.read().decode('utf-8')
@@ -68,3 +67,32 @@ def codegen_extra_kwargs(self, gast, schema):
         return {
             '__previews': previews,
         }
+
+
+try:
+    from gqlmod.helpers.urllib import UrllibJsonProvider
+except ImportError:
+    pass
+else:
+    class GitHubSyncProvider(GitHubBaseProvider, UrllibJsonProvider):
+        def build_request(self, query, variables):
+            req = super().build_request(query, variables)
+            req.add_header('Accept', self._build_accept_header(variables))
+            req.add_header('Authorization', self._build_authorization_header(variables))
+            return req
+
+
+try:
+    from gqlmod.helpers.aiohttp import AiohttpProvider
+except ImportError:
+    pass
+else:
+    class GitHubAsyncProvider(GitHubBaseProvider, AiohttpProvider):
+        use_json = True
+
+        def modify_request_args(self, variables, kwargs):
+            super().modify_request_args(kwargs)
+            kwargs.setdefault('headers', {}).update({
+                'Accept': self._build_accept_header(variables),
+                'Authorization': self._build_authorization_header(variables)
+            })

setup.cfg

@@ -33,10 +33,16 @@ tests_require =
 app =
     jwcrypto
     python-dateutil
+async =
+    gqlmod[aiohttp]
+sync =
+
 
 [options.entry_points]
 graphql_providers =
-    github = gqlmod_github:GitHubProvider
+    github = gqlmod_github:GitHubSyncProvider
+    github-sync = gqlmod_github:GitHubSyncProvider
+    github-async = gqlmod_github:GitHubAsyncProvider
 
 [flake8]
 select = C,E,F,W,B,B9

tests/queries_async.gql

@@ -0,0 +1,70 @@
+#~github-async~
+
+query Login {
+    viewer {
+        login
+        # primarySubjectId
+        hovercard {
+            contexts {
+                message
+                octicon
+            }
+        }
+    }
+}
+
+mutation start_check_run($repo:ID!, $sha:GitObjectID!) {
+    createCheckRun(input: {
+        headSha: $sha
+        name: "gqlmod check"
+        repositoryId: $repo
+        status: IN_PROGRESS
+    }) {
+        checkRun {
+            id
+        }
+    }
+}
+
+mutation append_check_run($repo:ID!, $checkrun:ID!, $annotations:[CheckAnnotationData!]) {
+    updateCheckRun(input: {
+        repositoryId: $repo
+        checkRunId: $checkrun
+        output: {
+            title: "gqlmod check"
+            summary: "Running..."
+            annotations: $annotations
+        }
+    }) {
+        checkRun {
+            id
+        }
+    }
+}
+
+mutation complete_check_run($repo:ID!, $checkrun:ID!, $state:CheckConclusionState) {
+    updateCheckRun(input: {
+        repositoryId: $repo
+        checkRunId: $checkrun
+        status: COMPLETED
+        conclusion: $state  # Probably want either FAILURE or SUCCESS
+        output: {
+            title: "gqlmod check"
+            summary: "Finished"
+        }
+    }) {
+        checkRun {
+            id
+        }
+    }
+}
+
+query get_label($repo: ID!, $name: String!) {
+  node(id: $repo) {
+    ... on Repository {
+      label(name: $name) {
+        id
+      }
+    }
+  }
+}

tests/test_github.py

@@ -3,9 +3,17 @@
 
 def test_get_schema():
     assert gqlmod.providers.query_for_schema('github')
+    assert gqlmod.providers.query_for_schema('github-sync')
+    assert gqlmod.providers.query_for_schema('github-async')
 
 
 def test_import():
     gqlmod.enable_gql_import()
     import tests.queries  # noqa
     # TODO: Actually check previews got detected
+
+
+def test_async_import():
+    gqlmod.enable_gql_import()
+    import tests.queries_async  # noqa
+    # TODO: Actually check previews got detected