Skip to content

Adding Vale skip rules doesn't resolve comments #979

@jdbaldry

Description

@jdbaldry

Side question: When I added in the skip rule commands in my file, it didn't resolve the conversation automatically in GH (unlike if I make a fix like changing the spelling of something). So at first I thought my skip rule hadn't worked. I think I've seen this before and sat there setting and resetting a skip rule in different ways not realizing Vale wasn't flagging it anymore. Is this expected behaviour? If so, then I'll add something to WT.

Ah yeah that's because the bot doesn't resolve or remove its own comments, it relies on GitHub marking the comments as outdated. I bet that because the skip rules are on separate lines, before and after the comment, GitHub doesn't consider it outdated like it would if the line itself changed.

That's indeed a bit of a nuisance and I'll open an issue for it.

Originally posted by @jdbaldry in #969

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions