Skip to content

Commit 76d73ae

Browse files
GuyPagoGuyPago
authored
Refactor/controller response types (#577)
* Change `InvokeHttp404` to `NotFound` * Replace `(int)HttpStatusCode.*` with `StatusCodes.*` * Change return type to `JsonResult` for both implicit `ActionResult<T>` casting support and runtime performance * Remove `UseGrandDetection` * Use `ActionResult<T>` instead of `ProducesResponseTypeAttribute` --------- Co-authored-by: Guy Taggar <guypago@outlook.com>
1 parent 32f9f37 commit 76d73ae

39 files changed

+337
-415
lines changed

‎src/Modules/Grand.Module.Api/Controllers/BrandController.cs‎

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
using MediatR;
88
using Microsoft.AspNetCore.JsonPatch;
99
using Microsoft.AspNetCore.Mvc;
10-
using System.Net;
1110
using Microsoft.AspNetCore.Http;
1211
using Grand.Module.Api.Attributes;
1312
using Microsoft.AspNetCore.Routing;
@@ -29,7 +28,7 @@ public BrandController(IMediator mediator, IPermissionService permissionService)
2928
[EndpointName("GetBrands")]
3029
[HttpGet]
3130
[EnableQuery]
32-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
31+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
3332
[ProducesResponseType(StatusCodes.Status200OK, Type = typeof(IEnumerable<BrandDto>))]
3433
public async Task<IActionResult> Get()
3534
{
@@ -41,8 +40,8 @@ public async Task<IActionResult> Get()
4140
[EndpointDescription("Get entity from Brand by key")]
4241
[EndpointName("GetBrandById")]
4342
[HttpGet("{key}")]
44-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
45-
[ProducesResponseType((int)HttpStatusCode.NotFound)]
43+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
44+
[ProducesResponseType(StatusCodes.Status404NotFound)]
4645
[ProducesResponseType(StatusCodes.Status200OK, Type = typeof(BrandDto))]
4746
public async Task<IActionResult> GetById([FromRoute] string key)
4847
{
@@ -57,9 +56,9 @@ public async Task<IActionResult> GetById([FromRoute] string key)
5756
[EndpointDescription("Add new entity to Brand")]
5857
[EndpointName("InsertBrand")]
5958
[HttpPost]
60-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
59+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
6160
[ProducesResponseType(StatusCodes.Status200OK, Type = typeof(BrandDto))]
62-
[ProducesResponseType((int)HttpStatusCode.BadRequest)]
61+
[ProducesResponseType(StatusCodes.Status400BadRequest)]
6362
public async Task<IActionResult> Post([FromBody] BrandDto model)
6463
{
6564
if (!await _permissionService.Authorize(PermissionSystemName.Brands)) return Forbid();
@@ -71,9 +70,9 @@ public async Task<IActionResult> Post([FromBody] BrandDto model)
7170
[EndpointDescription("Update entity in Brand")]
7271
[EndpointName("UpdateBrand")]
7372
[HttpPut]
74-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
73+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
7574
[ProducesResponseType(StatusCodes.Status200OK, Type = typeof(BrandDto))]
76-
[ProducesResponseType((int)HttpStatusCode.BadRequest)]
75+
[ProducesResponseType(StatusCodes.Status400BadRequest)]
7776
public async Task<IActionResult> Put([FromBody] BrandDto model)
7877
{
7978
if (!await _permissionService.Authorize(PermissionSystemName.Brands)) return Forbid();
@@ -85,10 +84,10 @@ public async Task<IActionResult> Put([FromBody] BrandDto model)
8584
[EndpointDescription("Partially update entity in Brand")]
8685
[EndpointName("PartiallyUpdateBrand")]
8786
[HttpPatch("{key}")]
88-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
89-
[ProducesResponseType((int)HttpStatusCode.OK)]
90-
[ProducesResponseType((int)HttpStatusCode.BadRequest)]
91-
[ProducesResponseType((int)HttpStatusCode.NotFound)]
87+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
88+
[ProducesResponseType(StatusCodes.Status200OK)]
89+
[ProducesResponseType(StatusCodes.Status400BadRequest)]
90+
[ProducesResponseType(StatusCodes.Status404NotFound)]
9291

9392
///sample
9493
///{
@@ -115,9 +114,9 @@ public async Task<IActionResult> Patch([FromRoute] string key, [FromBody] JsonPa
115114
[EndpointDescription("Delete entity in Brand")]
116115
[EndpointName("DeleteBrand")]
117116
[HttpDelete("{key}")]
118-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
119-
[ProducesResponseType((int)HttpStatusCode.OK)]
120-
[ProducesResponseType((int)HttpStatusCode.NotFound)]
117+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
118+
[ProducesResponseType(StatusCodes.Status200OK)]
119+
[ProducesResponseType(StatusCodes.Status404NotFound)]
121120
public async Task<IActionResult> Delete([FromRoute] string key)
122121
{
123122
if (!await _permissionService.Authorize(PermissionSystemName.Brands)) return Forbid();

‎src/Modules/Grand.Module.Api/Controllers/BrandLayoutController.cs‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
using Grand.Domain.Catalog;
66
using MediatR;
77
using Microsoft.AspNetCore.Mvc;
8-
using System.Net;
98
using Grand.Module.Api.Attributes;
109
using Microsoft.AspNetCore.Http;
1110
using Microsoft.AspNetCore.Routing;
@@ -26,9 +25,9 @@ public BrandLayoutController(IMediator mediator, IPermissionService permissionSe
2625
[EndpointDescription("Get entity from BrandLayout by key")]
2726
[EndpointName("GetBrandLayoutById")]
2827
[HttpGet("{key}")]
29-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
28+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
3029
[ProducesResponseType(StatusCodes.Status200OK, Type = typeof(LayoutDto))]
31-
[ProducesResponseType((int)HttpStatusCode.NotFound)]
30+
[ProducesResponseType(StatusCodes.Status404NotFound)]
3231
public async Task<IActionResult> Get([FromRoute] string key)
3332
{
3433
if (!await _permissionService.Authorize(PermissionSystemName.Maintenance)) return Forbid();
@@ -43,7 +42,7 @@ public async Task<IActionResult> Get([FromRoute] string key)
4342
[EndpointName("GetBrandLayouts")]
4443
[HttpGet]
4544
[EnableQuery]
46-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
45+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
4746
[ProducesResponseType(StatusCodes.Status200OK, Type = typeof(IEnumerable<LayoutDto>))]
4847
public async Task<IActionResult> Get()
4948
{

‎src/Modules/Grand.Module.Api/Controllers/CategoryController.cs‎

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
using MediatR;
88
using Microsoft.AspNetCore.JsonPatch;
99
using Microsoft.AspNetCore.Mvc;
10-
using System.Net;
1110
using Grand.Module.Api.Attributes;
1211
using Microsoft.AspNetCore.Http;
1312
using Microsoft.AspNetCore.Routing;
@@ -30,9 +29,9 @@ public CategoryController(
3029
[EndpointDescription("Get entity from Category by key")]
3130
[EndpointName("GetCategoryById")]
3231
[HttpGet("{key}")]
33-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
32+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
3433
[ProducesResponseType(StatusCodes.Status200OK, Type = typeof(CategoryDto))]
35-
[ProducesResponseType((int)HttpStatusCode.NotFound)]
34+
[ProducesResponseType(StatusCodes.Status404NotFound)]
3635
public async Task<IActionResult> Get([FromRoute] string key)
3736
{
3837
if (!await _permissionService.Authorize(PermissionSystemName.Categories)) return Forbid();
@@ -47,7 +46,7 @@ public async Task<IActionResult> Get([FromRoute] string key)
4746
[EndpointName("GetCategories")]
4847
[HttpGet]
4948
[EnableQuery]
50-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
49+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
5150
[ProducesResponseType(StatusCodes.Status200OK, Type = typeof(IEnumerable<CategoryDto>))]
5251
public async Task<IActionResult> Get()
5352
{
@@ -59,9 +58,9 @@ public async Task<IActionResult> Get()
5958
[EndpointDescription("Add new entity to Category")]
6059
[EndpointName("InsertCategory")]
6160
[HttpPost]
62-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
61+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
6362
[ProducesResponseType(StatusCodes.Status200OK, Type = typeof(CategoryDto))]
64-
[ProducesResponseType((int)HttpStatusCode.BadRequest)]
63+
[ProducesResponseType(StatusCodes.Status400BadRequest)]
6564
public async Task<IActionResult> Post([FromBody] CategoryDto model)
6665
{
6766
if (!await _permissionService.Authorize(PermissionSystemName.Categories)) return Forbid();
@@ -73,9 +72,9 @@ public async Task<IActionResult> Post([FromBody] CategoryDto model)
7372
[EndpointDescription("Update entity in Category")]
7473
[EndpointName("UpdateCategory")]
7574
[HttpPut]
76-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
75+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
7776
[ProducesResponseType(StatusCodes.Status200OK, Type = typeof(CategoryDto))]
78-
[ProducesResponseType((int)HttpStatusCode.BadRequest)]
77+
[ProducesResponseType(StatusCodes.Status400BadRequest)]
7978
public async Task<IActionResult> Put([FromBody] CategoryDto model)
8079
{
8180
if (!await _permissionService.Authorize(PermissionSystemName.Categories)) return Forbid();
@@ -87,10 +86,10 @@ public async Task<IActionResult> Put([FromBody] CategoryDto model)
8786
[EndpointDescription("Update entity in Category (delta)")]
8887
[EndpointName("UpdateCategoryPatch")]
8988
[HttpPatch("{key}")]
90-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
91-
[ProducesResponseType((int)HttpStatusCode.OK)]
92-
[ProducesResponseType((int)HttpStatusCode.BadRequest)]
93-
[ProducesResponseType((int)HttpStatusCode.NotFound)]
89+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
90+
[ProducesResponseType(StatusCodes.Status200OK)]
91+
[ProducesResponseType(StatusCodes.Status400BadRequest)]
92+
[ProducesResponseType(StatusCodes.Status404NotFound)]
9493
public async Task<IActionResult> Patch([FromRoute] string key, [FromBody] JsonPatchDocument<CategoryDto> model)
9594
{
9695
if (string.IsNullOrEmpty(key))
@@ -110,9 +109,9 @@ public async Task<IActionResult> Patch([FromRoute] string key, [FromBody] JsonPa
110109
[EndpointDescription("Delete entity from Category")]
111110
[EndpointName("DeleteCategory")]
112111
[HttpDelete("{key}")]
113-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
114-
[ProducesResponseType((int)HttpStatusCode.OK)]
115-
[ProducesResponseType((int)HttpStatusCode.NotFound)]
112+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
113+
[ProducesResponseType(StatusCodes.Status200OK)]
114+
[ProducesResponseType(StatusCodes.Status404NotFound)]
116115
public async Task<IActionResult> Delete([FromRoute] string key)
117116
{
118117
if (!await _permissionService.Authorize(PermissionSystemName.Categories)) return Forbid();

‎src/Modules/Grand.Module.Api/Controllers/CategoryLayoutController.cs‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
using Grand.Domain.Catalog;
66
using MediatR;
77
using Microsoft.AspNetCore.Mvc;
8-
using System.Net;
98
using Grand.Module.Api.Attributes;
109
using Microsoft.AspNetCore.Http;
1110
using Microsoft.AspNetCore.Routing;
@@ -28,9 +27,9 @@ public CategoryLayoutController(
2827
[EndpointDescription("Get entity from CategoryLayout by key")]
2928
[EndpointName("GetCategoryLayoutById")]
3029
[HttpGet("{key}")]
31-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
30+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
3231
[ProducesResponseType(StatusCodes.Status200OK, Type = typeof(LayoutDto))]
33-
[ProducesResponseType((int)HttpStatusCode.NotFound)]
32+
[ProducesResponseType(StatusCodes.Status404NotFound)]
3433
public async Task<IActionResult> Get([FromRoute] string key)
3534
{
3635
if (!await _permissionService.Authorize(PermissionSystemName.Maintenance)) return Forbid();
@@ -45,7 +44,7 @@ public async Task<IActionResult> Get([FromRoute] string key)
4544
[EndpointName("GetCategoryLayout")]
4645
[HttpGet]
4746
[EnableQuery]
48-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
47+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
4948
[ProducesResponseType(StatusCodes.Status200OK, Type = typeof(IEnumerable<LayoutDto>))]
5049
public async Task<IActionResult> Get()
5150
{

‎src/Modules/Grand.Module.Api/Controllers/CollectionController.cs‎

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
using Microsoft.AspNetCore.JsonPatch;
1111
using Microsoft.AspNetCore.Mvc;
1212
using Microsoft.AspNetCore.Routing;
13-
using System.Net;
1413

1514
namespace Grand.Module.Api.Controllers;
1615

@@ -28,9 +27,9 @@ public CollectionController(IMediator mediator, IPermissionService permissionSer
2827
[EndpointDescription("Get entity from Collection by key")]
2928
[EndpointName("GetCollectionById")]
3029
[HttpGet("{key}")]
31-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
30+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
3231
[ProducesResponseType(StatusCodes.Status200OK, Type = typeof(CollectionDto))]
33-
[ProducesResponseType((int)HttpStatusCode.NotFound)]
32+
[ProducesResponseType(StatusCodes.Status404NotFound)]
3433
public async Task<IActionResult> Get([FromRoute] string key)
3534
{
3635
if (!await _permissionService.Authorize(PermissionSystemName.Collections)) return Forbid();
@@ -45,7 +44,7 @@ public async Task<IActionResult> Get([FromRoute] string key)
4544
[EndpointName("GetCollections")]
4645
[HttpGet]
4746
[EnableQuery]
48-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
47+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
4948
[ProducesResponseType(StatusCodes.Status200OK, Type = typeof(IEnumerable<CollectionDto>))]
5049
public async Task<IActionResult> Get()
5150
{
@@ -57,9 +56,9 @@ public async Task<IActionResult> Get()
5756
[EndpointDescription("Add new entity to Collection")]
5857
[EndpointName("InsertCollection")]
5958
[HttpPost]
60-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
59+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
6160
[ProducesResponseType(StatusCodes.Status200OK, Type = typeof(CollectionDto))]
62-
[ProducesResponseType((int)HttpStatusCode.BadRequest)]
61+
[ProducesResponseType(StatusCodes.Status400BadRequest)]
6362
public async Task<IActionResult> Post([FromBody] CollectionDto model)
6463
{
6564
if (!await _permissionService.Authorize(PermissionSystemName.Collections)) return Forbid();
@@ -71,9 +70,9 @@ public async Task<IActionResult> Post([FromBody] CollectionDto model)
7170
[EndpointDescription("Update entity in Collection")]
7271
[EndpointName("UpdateCollection")]
7372
[HttpPut]
74-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
73+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
7574
[ProducesResponseType(StatusCodes.Status200OK, Type = typeof(CollectionDto))]
76-
[ProducesResponseType((int)HttpStatusCode.BadRequest)]
75+
[ProducesResponseType(StatusCodes.Status400BadRequest)]
7776
public async Task<IActionResult> Put([FromBody] CollectionDto model)
7877
{
7978
if (!await _permissionService.Authorize(PermissionSystemName.Collections)) return Forbid();
@@ -85,10 +84,10 @@ public async Task<IActionResult> Put([FromBody] CollectionDto model)
8584
[EndpointDescription("Partially update entity in Collection")]
8685
[EndpointName("PartiallyUpdateCollection")]
8786
[HttpPatch("{key}")]
88-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
89-
[ProducesResponseType((int)HttpStatusCode.OK)]
90-
[ProducesResponseType((int)HttpStatusCode.BadRequest)]
91-
[ProducesResponseType((int)HttpStatusCode.NotFound)]
87+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
88+
[ProducesResponseType(StatusCodes.Status200OK)]
89+
[ProducesResponseType(StatusCodes.Status400BadRequest)]
90+
[ProducesResponseType(StatusCodes.Status404NotFound)]
9291
public async Task<IActionResult> Patch([FromRoute] string key, [FromBody] JsonPatchDocument<CollectionDto> model)
9392
{
9493
if (string.IsNullOrEmpty(key))
@@ -108,9 +107,9 @@ public async Task<IActionResult> Patch([FromRoute] string key, [FromBody] JsonPa
108107
[EndpointDescription("Delete entity in Collection")]
109108
[EndpointName("DeleteCollection")]
110109
[HttpDelete("{key}")]
111-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
112-
[ProducesResponseType((int)HttpStatusCode.OK)]
113-
[ProducesResponseType((int)HttpStatusCode.NotFound)]
110+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
111+
[ProducesResponseType(StatusCodes.Status200OK)]
112+
[ProducesResponseType(StatusCodes.Status404NotFound)]
114113
public async Task<IActionResult> Delete([FromRoute] string key)
115114
{
116115
if (!await _permissionService.Authorize(PermissionSystemName.Collections)) return Forbid();

‎src/Modules/Grand.Module.Api/Controllers/CollectionLayoutController.cs‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
using Microsoft.AspNetCore.Http;
99
using Microsoft.AspNetCore.Mvc;
1010
using Microsoft.AspNetCore.Routing;
11-
using System.Net;
1211

1312
namespace Grand.Module.Api.Controllers;
1413

@@ -26,9 +25,9 @@ public CollectionLayoutController(IMediator mediator, IPermissionService permiss
2625
[EndpointDescription("Get entity from CollectionLayout by key")]
2726
[EndpointName("GetCollectionLayoutById")]
2827
[HttpGet("{key}")]
29-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
28+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
3029
[ProducesResponseType(StatusCodes.Status200OK, Type = typeof(LayoutDto))]
31-
[ProducesResponseType((int)HttpStatusCode.NotFound)]
30+
[ProducesResponseType(StatusCodes.Status404NotFound)]
3231
public async Task<IActionResult> Get([FromRoute] string key)
3332
{
3433
if (!await _permissionService.Authorize(PermissionSystemName.Maintenance)) return Forbid();
@@ -43,7 +42,7 @@ public async Task<IActionResult> Get([FromRoute] string key)
4342
[EndpointName("GetCollectionLayouts")]
4443
[HttpGet]
4544
[EnableQuery]
46-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
45+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
4746
[ProducesResponseType(StatusCodes.Status200OK, Type = typeof(IEnumerable<LayoutDto>))]
4847
public async Task<IActionResult> Get()
4948
{

‎src/Modules/Grand.Module.Api/Controllers/CountryController.cs‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
using Grand.Domain.Directory;
66
using MediatR;
77
using Microsoft.AspNetCore.Mvc;
8-
using System.Net;
98
using Grand.Module.Api.Attributes;
109
using Microsoft.AspNetCore.Http;
1110
using Microsoft.AspNetCore.Routing;
@@ -26,9 +25,9 @@ public CountryController(IMediator mediator, IPermissionService permissionServic
2625
[EndpointDescription("Get entity from Country by key")]
2726
[EndpointName("GetCountryById")]
2827
[HttpGet("{key}")]
29-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
28+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
3029
[ProducesResponseType(StatusCodes.Status200OK, Type = typeof(CountryDto))]
31-
[ProducesResponseType((int)HttpStatusCode.NotFound)]
30+
[ProducesResponseType(StatusCodes.Status404NotFound)]
3231
public async Task<IActionResult> Get([FromRoute] string key)
3332
{
3433
if (!await _permissionService.Authorize(PermissionSystemName.Countries)) return Forbid();
@@ -44,7 +43,7 @@ public async Task<IActionResult> Get([FromRoute] string key)
4443
[EndpointName("GetCountries")]
4544
[HttpGet]
4645
[EnableQuery]
47-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
46+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
4847
[ProducesResponseType(StatusCodes.Status200OK, Type = typeof(IEnumerable<CountryDto>))]
4948
public async Task<IActionResult> Get()
5049
{

‎src/Modules/Grand.Module.Api/Controllers/CurrencyController.cs‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
using Grand.Domain.Directory;
66
using MediatR;
77
using Microsoft.AspNetCore.Mvc;
8-
using System.Net;
98
using Grand.Module.Api.Attributes;
109
using Microsoft.AspNetCore.Http;
1110
using Microsoft.AspNetCore.Routing;
@@ -26,9 +25,9 @@ public CurrencyController(IMediator mediator, IPermissionService permissionServi
2625
[EndpointDescription("Get entity from Currency by key")]
2726
[EndpointName("GetCurrencyById")]
2827
[HttpGet("{key}")]
29-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
28+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
3029
[ProducesResponseType(StatusCodes.Status200OK, Type = typeof(CurrencyDto))]
31-
[ProducesResponseType((int)HttpStatusCode.NotFound)]
30+
[ProducesResponseType(StatusCodes.Status404NotFound)]
3231
public async Task<IActionResult> Get([FromRoute] string key)
3332
{
3433
if (!await _permissionService.Authorize(PermissionSystemName.Currencies)) return Forbid();
@@ -43,7 +42,7 @@ public async Task<IActionResult> Get([FromRoute] string key)
4342
[EndpointName("GetCurrencies")]
4443
[HttpGet]
4544
[EnableQuery]
46-
[ProducesResponseType((int)HttpStatusCode.Forbidden)]
45+
[ProducesResponseType(StatusCodes.Status403Forbidden)]
4746
[ProducesResponseType(StatusCodes.Status200OK, Type = typeof(IEnumerable<CurrencyDto>))]
4847
public async Task<IActionResult> Get()
4948
{

0 commit comments

Comments
 (0)