Improvements/code (#580)

* Fix logical operators in CustomerValidator.cs
* Refactor to run application asynchronously
* Remove unused code
* Refactor filters to use constructor parameters
* Refactor test assertion to use Assert.IsNull
* Replace manual null check with ArgumentNullException.ThrowIfNull
* Refactor filters to use primary constructors
* Remove DebuggerToString method from ViewBuffer class
* Refactor PageNavigationTagHelper to use Append method
* Remove IDownloadService dependency and reformat code
* Refactor argument validation for conciseness
* Replace build.yml with sonarcube.yml for SonarQube integration
* Remove unused using directive

Author: KrzysztofPajak

.github/workflows/build.yml .github/workflows/sonarcube.yml.github/workflows/build.yml renamed to .github/workflows/sonarcube.yml

@@ -42,6 +42,8 @@ jobs:
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
         shell: powershell
         run: |
-          .\.sonar\scanner\dotnet-sonarscanner begin /k:"grandnode_grandnode2" /o:"grandnode" /d:sonar.token="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io"
-          dotnet build
-          .\.sonar\scanner\dotnet-sonarscanner end /d:sonar.token="${{ secrets.SONAR_TOKEN }}"
+            .\.sonar\scanner\dotnet-sonarscanner begin /k:"grandnode_grandnode2" /o:"grandnode" `
+              /d:sonar.token="${{ secrets.SONAR_TOKEN }}" `
+              /d:sonar.host.url="https://sonarcloud.io" `
+              /d:sonar.coverage.exclusions="**" `
+              /d:sonar.cpd.exclusions="**"

src/Aspire/Aspire.AppHost/Program.cs

@@ -6,4 +6,4 @@
 var mongodb = mongo.AddDatabase("Mongodb");
 builder.ConfigureGrandWebProject(mongodb);
 
-builder.Build().Run();
+await builder.Build().RunAsync();

src/Business/Grand.Business.Catalog/Commands/UpdateProductReviewTotalsCommandHandler.cs

@@ -20,8 +20,7 @@ public UpdateProductReviewTotalsCommandHandler(IRepository<Product> productRepos
 
     public async Task<bool> Handle(UpdateProductReviewTotalsCommand request, CancellationToken cancellationToken)
     {
-        if (request.Product == null)
-            throw new ArgumentNullException(nameof(request.Product));
+        ArgumentNullException.ThrowIfNull(request.Product);
 
         var approvedRatingSum = 0;
         var notApprovedRatingSum = 0;

src/Business/Grand.Business.Catalog/Services/Products/ProductAttributeService.cs

@@ -2,6 +2,7 @@
 using Grand.Data;
 using Grand.Domain;
 using Grand.Domain.Catalog;
+using Grand.Domain.Directory;
 using Grand.Infrastructure.Caching;
 using Grand.Infrastructure.Caching.Constants;
 using Grand.Infrastructure.Extensions;
@@ -257,12 +258,10 @@ public virtual async Task InsertProductAttributeValue(ProductAttributeValue prod
         ArgumentNullException.ThrowIfNull(productAttributeValue);
 
         var p = await _productRepository.GetByIdAsync(productId);
-        if (p == null)
-            throw new ArgumentNullException(nameof(p));
+        ArgumentNullException.ThrowIfNull(p, nameof(p));
 
         var pam = p.ProductAttributeMappings.FirstOrDefault(x => x.Id == productAttributeMappingId);
-        if (pam == null)
-            throw new ArgumentNullException(nameof(pam));
+        ArgumentNullException.ThrowIfNull(pam, nameof(pam));
 
         pam.ProductAttributeValues.Add(productAttributeValue);
         await _productRepository.UpdateToSet(productId, x => x.ProductAttributeMappings, z => z.Id,

src/Business/Grand.Business.Catalog/Services/Products/ProductCourseService.cs

@@ -28,8 +28,7 @@ public virtual async Task<Product> GetProductByCourseId(string courseId)
 
     public virtual async Task UpdateCourseOnProduct(string productId, string courseId)
     {
-        if (string.IsNullOrEmpty(productId))
-            throw new ArgumentNullException(nameof(productId));
+        ArgumentNullException.ThrowIfNullOrEmpty(productId);
 
         await _productRepository.UpdateField(productId, x => x.CourseId, courseId);
         await _productRepository.UpdateField(productId, x => x.UpdatedOnUtc, DateTime.UtcNow);

src/Business/Grand.Business.Catalog/Services/Products/ProductService.cs

@@ -1181,8 +1181,8 @@ public virtual async Task DeleteProductWarehouseInventory(ProductWarehouseInvent
 
     public virtual async Task DeleteDiscount(string discountId, string productId)
     {
-        if (string.IsNullOrEmpty(discountId))
-            throw new ArgumentNullException(nameof(discountId));
+        ArgumentNullException.ThrowIfNullOrEmpty(discountId);
+        ArgumentNullException.ThrowIfNullOrEmpty(productId);
 
         await _productRepository.Pull(productId, x => x.AppliedDiscounts, discountId);
 

src/Business/Grand.Business.Checkout/Commands/Handlers/Orders/ActivatedValueForPurchasedVouchersCommandHandler.cs

@@ -28,8 +28,7 @@ public ActivatedValueForPurchasedGiftVouchersCommandHandler(
     public async Task<bool> Handle(ActivatedValueForPurchasedGiftVouchersCommand request,
         CancellationToken cancellationToken)
     {
-        if (request.Order == null)
-            throw new ArgumentNullException(nameof(request.Order));
+        ArgumentNullException.ThrowIfNull(request.Order);
 
         foreach (var orderItem in request.Order.OrderItems)
         {

src/Business/Grand.Business.Checkout/Commands/Handlers/Orders/AwardLoyaltyPointsCommandHandler.cs

@@ -34,8 +34,7 @@ public AwardLoyaltyPointsCommandHandler(
 
     public async Task<bool> Handle(AwardLoyaltyPointsCommand request, CancellationToken cancellationToken)
     {
-        if (request.Order == null)
-            throw new ArgumentNullException(nameof(request.Order));
+        ArgumentNullException.ThrowIfNull(request.Order);
 
         var customer = await _customerService.GetCustomerById(request.Order.CustomerId);
         var currency = await _currencyService.GetCurrencyByCode(request.Order.CustomerCurrencyCode);

src/Business/Grand.Business.Checkout/Commands/Handlers/Orders/CancelOrderCommandHandler.cs

@@ -49,8 +49,7 @@ public CancelOrderCommandHandler(
 
     public async Task<bool> Handle(CancelOrderCommand request, CancellationToken cancellationToken)
     {
-        if (request.Order == null)
-            throw new ArgumentNullException(nameof(request.Order));
+        ArgumentNullException.ThrowIfNull(request.Order);
 
         if (request.Order.OrderStatusId == (int)OrderStatusSystem.Cancelled)
             throw new Exception("Cannot do cancel for order.");

src/Business/Grand.Business.Checkout/Commands/Handlers/Orders/CancelOrderItemCommandHandler.cs

@@ -33,11 +33,8 @@ public CancelOrderItemCommandHandler(
     public async Task<(bool error, string message)> Handle(CancelOrderItemCommand request,
         CancellationToken cancellationToken)
     {
-        if (request.Order == null)
-            throw new ArgumentNullException(nameof(request.Order));
-
-        if (request.OrderItem == null)
-            throw new ArgumentNullException(nameof(request.OrderItem));
+        ArgumentNullException.ThrowIfNull(request.Order);
+        ArgumentNullException.ThrowIfNull(request.OrderItem);
 
         var product = await _productService.GetProductById(request.OrderItem.ProductId);
         if (product == null)