Improvements/code (#574)

* Renamed IWorkContextAccessor to IContextAccessor.
* Added IStoreContext to IContextAccessor and moved CurrentStore/CurrentHost from IWorkContext.
* Theme Moder plugin - Fix typo in CSS padding-left unit in home.css
* Views - Refactor menu display logic into a private method
* Fix loop variable scoping in public.common.js
* Remove MigrationProcessTest.cs
* Limit loop iterations in ProductController to 100
* Grand.Web.Admin - Generate unique file names for uploaded zip files
* Grand.Web.Admin - Refactor plugin path handling and simplify deletions
* Remove [DisableRequestSizeLimit] from AsyncUpload method
* Created IAdminStoreService to retrieve the active store in the admin panel (for settings).
* Updated validators in the admin panel.
* Update plugins (AdminStoreService)
* Admin - Update validators (add BaseStoreAccessValidator)
* Refactor KnowledgebaseService with new helper methods
* Fix redundant rendering of Selector_Store in Header.cshtml
* Theme.Plugin - Update ShoppingCartLinks.cshtml
* Remove duplicated code
* Renamed `GetPushReceivers` to `GetAllowedPushReceivers` in the `IPushNotificationsService` interface and its implementation in `PushNotificationsService`.

Author: KrzysztofPajak

src/Business/Grand.Business.Authentication/Services/ExternalAuthenticationService.cs

@@ -31,7 +31,7 @@ public ExternalAuthenticationService(
         IGroupService groupService,
         IMediator mediator,
         IRepository<ExternalAuthentication> externalAuthenticationRecordRepository,
-        IWorkContextAccessor workContextAccessor,
+        IContextAccessor contextAccessor,
         IEnumerable<IExternalAuthenticationProvider> externalAuthenticationProviders,
         CustomerSettings customerSettings,
         ExternalAuthenticationSettings externalAuthenticationSettings)
@@ -44,7 +44,7 @@ public ExternalAuthenticationService(
         _groupService = groupService;
         _mediator = mediator;
         _externalAuthenticationRecordRepository = externalAuthenticationRecordRepository;
-        _workContextAccessor = workContextAccessor;
+        _contextAccessor = contextAccessor;
         _externalAuthenticationProviders = externalAuthenticationProviders;
     }
 
@@ -58,7 +58,7 @@ public ExternalAuthenticationService(
     private readonly IGroupService _groupService;
     private readonly IMediator _mediator;
     private readonly IRepository<ExternalAuthentication> _externalAuthenticationRecordRepository;
-    private readonly IWorkContextAccessor _workContextAccessor;
+    private readonly IContextAccessor _contextAccessor;
     private readonly IEnumerable<IExternalAuthenticationProvider> _externalAuthenticationProviders;
     private readonly CustomerSettings _customerSettings;
     private readonly ExternalAuthenticationSettings _externalAuthenticationSettings;
@@ -130,32 +130,32 @@ _customerSettings.UserRegistrationType is UserRegistrationType.Standard
                 or UserRegistrationType.EmailValidation;
 
         //create registration request
-        var registrationRequest = new RegistrationRequest(_workContextAccessor.WorkContext.CurrentCustomer,
+        var registrationRequest = new RegistrationRequest(_contextAccessor.WorkContext.CurrentCustomer,
             parameters.Email, parameters.Email,
             CommonHelper.GenerateRandomDigitCode(20),
             PasswordFormat.Hashed,
-            _workContextAccessor.WorkContext.CurrentStore.Id,
+            _contextAccessor.StoreContext.CurrentStore.Id,
             approved);
 
         //whether registration request has been completed successfully
         await _customerManagerService.RegisterCustomer(registrationRequest);
 
         //allow to save other customer values by consuming this event
-        await _mediator.Publish(new RegisteredByExternalMethod(_workContextAccessor.WorkContext.CurrentCustomer, parameters));
+        await _mediator.Publish(new RegisteredByExternalMethod(_contextAccessor.WorkContext.CurrentCustomer, parameters));
 
         //raise customer registered event
-        await _mediator.Publish(new CustomerRegisteredEvent(_workContextAccessor.WorkContext.CurrentCustomer));
+        await _mediator.Publish(new CustomerRegisteredEvent(_contextAccessor.WorkContext.CurrentCustomer));
 
         //associate external account with registered user
-        await AssociateCustomer(_workContextAccessor.WorkContext.CurrentCustomer, parameters);
+        await AssociateCustomer(_contextAccessor.WorkContext.CurrentCustomer, parameters);
 
         //authenticate
         if (!approved)
             return _customerSettings.UserRegistrationType == UserRegistrationType.AdminApproval
                 ? new RedirectToRouteResult("RegisterResult",
                     new { resultId = (int)UserRegistrationType.AdminApproval })
                 : Error(["Error on registration"]);
-        await _authenticationService.SignIn(_workContextAccessor.WorkContext.CurrentCustomer, false);
+        await _authenticationService.SignIn(_contextAccessor.WorkContext.CurrentCustomer, false);
 
         return new RedirectToRouteResult("RegisterResult", new { resultId = (int)UserRegistrationType.Standard });
     }
@@ -206,8 +206,8 @@ public virtual IList<IExternalAuthenticationProvider> LoadActiveAuthenticationPr
         return LoadAllAuthenticationProviders()
             .Where(provider =>
                 provider.IsMethodActive(_externalAuthenticationSettings) &&
-                provider.IsAuthenticateGroup(_workContextAccessor.WorkContext.CurrentCustomer) &&
-                provider.IsAuthenticateStore(_workContextAccessor.WorkContext.CurrentStore)
+                provider.IsAuthenticateGroup(_contextAccessor.WorkContext.CurrentCustomer) &&
+                provider.IsAuthenticateStore(_contextAccessor.StoreContext.CurrentStore)
             ).ToList();
     }
 
@@ -242,8 +242,8 @@ public virtual bool AuthenticationProviderIsAvailable(string systemName)
 
         return authenticationMethod != null &&
                authenticationMethod.IsMethodActive(_externalAuthenticationSettings) &&
-               authenticationMethod.IsAuthenticateGroup(_workContextAccessor.WorkContext.CurrentCustomer) &&
-               authenticationMethod.IsAuthenticateStore(_workContextAccessor.WorkContext.CurrentStore);
+               authenticationMethod.IsAuthenticateGroup(_contextAccessor.WorkContext.CurrentCustomer) &&
+               authenticationMethod.IsAuthenticateStore(_contextAccessor.StoreContext.CurrentStore);
     }
 
     #endregion
@@ -264,8 +264,8 @@ public virtual async Task<IActionResult> Authenticate(ExternalAuthParam paramete
             return Error(["External authentication method cannot be loaded"]);
 
         //get current logged-in user
-        var currentLoggedInUser = await _groupService.IsRegistered(_workContextAccessor.WorkContext.CurrentCustomer)
-            ? _workContextAccessor.WorkContext.CurrentCustomer
+        var currentLoggedInUser = await _groupService.IsRegistered(_contextAccessor.WorkContext.CurrentCustomer)
+            ? _contextAccessor.WorkContext.CurrentCustomer
             : null;
 
         //authenticate associated user if already exists

src/Business/Grand.Business.Authentication/Services/TwoFactorAuthenticationService.cs

@@ -14,14 +14,14 @@ public class TwoFactorAuthenticationService : ITwoFactorAuthenticationService
     private readonly IEnumerable<ISMSVerificationService> _smsVerificationService;
     private readonly TwoFactorAuthenticator _twoFactorAuthentication;
     private readonly ICustomerService _customerService;
-    private readonly IWorkContextAccessor _workContextAccessor;
+    private readonly IContextAccessor _contextAccessor;
 
     public TwoFactorAuthenticationService(
-        IWorkContextAccessor workContextAccessor,
+        IContextAccessor contextAccessor,
         ICustomerService customerService,
         IEnumerable<ISMSVerificationService> smsVerificationService)
     {
-        _workContextAccessor = workContextAccessor;
+        _contextAccessor = contextAccessor;
         _customerService = customerService;
         _smsVerificationService = smsVerificationService;
         _twoFactorAuthentication = new TwoFactorAuthenticator();
@@ -62,7 +62,7 @@ public virtual async Task<TwoFactorCodeSetup> GenerateCodeSetup(string secretKey
         switch (twoFactorAuthenticationType)
         {
             case TwoFactorAuthenticationType.AppVerification:
-                var setupInfo = _twoFactorAuthentication.GenerateSetupCode(_workContextAccessor.WorkContext.CurrentStore.CompanyName,
+                var setupInfo = _twoFactorAuthentication.GenerateSetupCode(_contextAccessor.StoreContext.CurrentStore.CompanyName,
                     customer.Email, secretKey, false);
                 model.CustomValues.Add("QrCodeImageUrl", setupInfo.QrCodeSetupImageUrl);
                 model.CustomValues.Add("ManualEntryQrCode", setupInfo.ManualEntryKey);

src/Business/Grand.Business.Catalog/Services/Brands/BrandService.cs

@@ -24,12 +24,12 @@ public class BrandService : IBrandService
     /// </summary>
     public BrandService(ICacheBase cacheBase,
         IRepository<Brand> brandRepository,
-        IWorkContextAccessor workContextAccessor,
+        IContextAccessor contextAccessor,
         IMediator mediator, AccessControlConfig accessControlConfig)
     {
         _cacheBase = cacheBase;
         _brandRepository = brandRepository;
-        _workContextAccessor = workContextAccessor;
+        _contextAccessor = contextAccessor;
         _mediator = mediator;
         _accessControlConfig = accessControlConfig;
     }
@@ -39,7 +39,7 @@ public BrandService(ICacheBase cacheBase,
     #region Fields
 
     private readonly IRepository<Brand> _brandRepository;
-    private readonly IWorkContextAccessor _workContextAccessor;
+    private readonly IContextAccessor _contextAccessor;
     private readonly IMediator _mediator;
     private readonly ICacheBase _cacheBase;
     private readonly AccessControlConfig _accessControlConfig;
@@ -77,7 +77,7 @@ public virtual async Task<IPagedList<Brand>> GetAllBrands(string brandName = "",
             if (!showHidden && !_accessControlConfig.IgnoreAcl)
             {
                 //Limited to customer groups rules
-                var allowedCustomerGroupsIds = _workContextAccessor.WorkContext.CurrentCustomer.GetCustomerGroupIds();
+                var allowedCustomerGroupsIds = _contextAccessor.WorkContext.CurrentCustomer.GetCustomerGroupIds();
                 query = from p in query
                     where !p.LimitedToGroups || allowedCustomerGroupsIds.Any(x => p.CustomerGroups.Contains(x))
                     select p;

src/Business/Grand.Business.Catalog/Services/Categories/CategoryService.cs

@@ -5,6 +5,7 @@
 using Grand.Domain;
 using Grand.Domain.Catalog;
 using Grand.Domain.Customers;
+using Grand.Domain.Stores;
 using Grand.Infrastructure;
 using Grand.Infrastructure.Caching;
 using Grand.Infrastructure.Caching.Constants;
@@ -32,14 +33,14 @@ public class CategoryService : ICategoryService
     /// <param name="accessControlConfig"></param>
     public CategoryService(ICacheBase cacheBase,
         IRepository<Category> categoryRepository,
-        IWorkContextAccessor workContextAccessor,
+        IContextAccessor contextAccessor,
         IMediator mediator,
         IAclService aclService,
         AccessControlConfig accessControlConfig)
     {
         _cacheBase = cacheBase;
         _categoryRepository = categoryRepository;
-        _workContextAccessor = workContextAccessor;
+        _contextAccessor = contextAccessor;
         _mediator = mediator;
         _aclService = aclService;
         _accessControlConfig = accessControlConfig;
@@ -50,12 +51,15 @@ public CategoryService(ICacheBase cacheBase,
     #region Fields
 
     private readonly IRepository<Category> _categoryRepository;
-    private readonly IWorkContextAccessor _workContextAccessor;
+    private readonly IContextAccessor _contextAccessor;
     private readonly IMediator _mediator;
     private readonly ICacheBase _cacheBase;
     private readonly IAclService _aclService;
     private readonly AccessControlConfig _accessControlConfig;
 
+    private Customer CurrentCustomer => _contextAccessor.WorkContext.CurrentCustomer;
+    private Store CurrentStore => _contextAccessor.StoreContext.CurrentStore;
+
     #endregion
 
     #region Methods
@@ -91,7 +95,7 @@ public virtual async Task<IPagedList<Category>> GetAllCategories(string parentId
             if (!showHidden && !_accessControlConfig.IgnoreAcl)
             {
                 //Limited to customer group (access control list)
-                var allowedCustomerGroupsIds = _workContextAccessor.WorkContext.CurrentCustomer.GetCustomerGroupIds();
+                var allowedCustomerGroupsIds = CurrentCustomer.GetCustomerGroupIds();
                 query = from p in query
                     where !p.LimitedToGroups || allowedCustomerGroupsIds.Any(x => p.CustomerGroups.Contains(x))
                     select p;
@@ -124,23 +128,23 @@ public virtual async Task<IList<Category>> GetMenuCategories()
         switch (_accessControlConfig.IgnoreAcl)
         {
             case true when
-                string.IsNullOrEmpty(_workContextAccessor.WorkContext.CurrentStore.Id) || _accessControlConfig.IgnoreStoreLimitations:
+                string.IsNullOrEmpty(CurrentStore.Id) || _accessControlConfig.IgnoreStoreLimitations:
                 return await Task.FromResult(query.ToList());
             case false:
             {
                 //Limited to customer group (access control list)
-                var allowedCustomerGroupsIds = _workContextAccessor.WorkContext.CurrentCustomer.GetCustomerGroupIds();
+                var allowedCustomerGroupsIds = CurrentCustomer.GetCustomerGroupIds();
                 query = from p in query
                     where !p.LimitedToGroups || allowedCustomerGroupsIds.Any(x => p.CustomerGroups.Contains(x))
                     select p;
                 break;
             }
         }
 
-        if (!string.IsNullOrEmpty(_workContextAccessor.WorkContext.CurrentStore.Id) && !_accessControlConfig.IgnoreStoreLimitations)
+        if (!string.IsNullOrEmpty(CurrentStore.Id) && !_accessControlConfig.IgnoreStoreLimitations)
             //Limited to stores rule
             query = from p in query
-                where !p.LimitedToStores || p.Stores.Contains(_workContextAccessor.WorkContext.CurrentStore.Id)
+                where !p.LimitedToStores || p.Stores.Contains(CurrentStore.Id)
                 select p;
         return await Task.FromResult(query.ToList());
     }
@@ -155,10 +159,8 @@ public virtual async Task<IList<Category>> GetMenuCategories()
     public virtual async Task<IList<Category>> GetAllCategoriesByParentCategoryId(string parentCategoryId = "",
         bool showHidden = false, bool includeAllLevels = false)
     {
-        var storeId = _workContextAccessor.WorkContext.CurrentStore.Id;
-        var customer = _workContextAccessor.WorkContext.CurrentCustomer;
         var key = string.Format(CacheKey.CATEGORIES_BY_PARENT_CATEGORY_ID_KEY, parentCategoryId, showHidden,
-            customer.Id, storeId, includeAllLevels);
+            CurrentCustomer.Id, CurrentStore.Id, includeAllLevels);
         return await _cacheBase.GetAsync(key, async () =>
         {
             var query = _categoryRepository.Table.Where(c => c.ParentCategoryId == parentCategoryId);
@@ -170,7 +172,7 @@ public virtual async Task<IList<Category>> GetAllCategoriesByParentCategoryId(st
                 if (!_accessControlConfig.IgnoreAcl)
                 {
                     //Limited to customer groups rules
-                    var allowedCustomerGroupsIds = _workContextAccessor.WorkContext.CurrentCustomer.GetCustomerGroupIds();
+                    var allowedCustomerGroupsIds = CurrentCustomer.GetCustomerGroupIds();
                     query = from p in query
                         where !p.LimitedToGroups || allowedCustomerGroupsIds.Any(x => p.CustomerGroups.Contains(x))
                         select p;
@@ -179,7 +181,7 @@ public virtual async Task<IList<Category>> GetAllCategoriesByParentCategoryId(st
                 if (!_accessControlConfig.IgnoreStoreLimitations)
                     //Limited to stores rules
                     query = from p in query
-                        where !p.LimitedToStores || p.Stores.Contains(storeId)
+                        where !p.LimitedToStores || p.Stores.Contains(CurrentStore.Id)
                         select p;
             }
 
@@ -207,8 +209,8 @@ public virtual async Task<IList<Category>> GetAllCategoriesDisplayedOnHomePage(b
         var categories = await Task.FromResult(query.ToList());
         if (!showHidden)
             categories = categories
-                .Where(c => _aclService.Authorize(c, _workContextAccessor.WorkContext.CurrentCustomer) &&
-                            _aclService.Authorize(c, _workContextAccessor.WorkContext.CurrentStore.Id))
+                .Where(c => _aclService.Authorize(c, CurrentCustomer) &&
+                            _aclService.Authorize(c, CurrentStore.Id))
                 .ToList();
 
         return categories;
@@ -228,8 +230,8 @@ public virtual async Task<IList<Category>> GetAllCategoriesFeaturedProductsOnHom
         var categories = await Task.FromResult(query.ToList());
         if (!showHidden)
             categories = categories
-                .Where(c => _aclService.Authorize(c, _workContextAccessor.WorkContext.CurrentCustomer) &&
-                            _aclService.Authorize(c, _workContextAccessor.WorkContext.CurrentStore.Id))
+                .Where(c => _aclService.Authorize(c, CurrentCustomer) &&
+                            _aclService.Authorize(c, CurrentStore.Id))
                 .ToList();
         return categories;
     }
@@ -245,8 +247,8 @@ public virtual async Task<IList<Category>> GetAllCategoriesSearchBox()
             .OrderBy(x => x.SearchBoxDisplayOrder);
 
         var categories = (await Task.FromResult(query.ToList()))
-            .Where(c => _aclService.Authorize(c, _workContextAccessor.WorkContext.CurrentCustomer) &&
-                        _aclService.Authorize(c, _workContextAccessor.WorkContext.CurrentStore.Id))
+            .Where(c => _aclService.Authorize(c, CurrentCustomer) &&
+                        _aclService.Authorize(c, CurrentStore.Id))
             .ToList();
 
         return categories;
@@ -268,8 +270,8 @@ public virtual async Task<IList<Category>> GetCategoryBreadCrumb(Category catego
         while (category != null && //not null                
                (showHidden || category.Published) && //published
                (showHidden ||
-                _aclService.Authorize(category, _workContextAccessor.WorkContext.CurrentCustomer)) && //limited to customer groups
-               (showHidden || _aclService.Authorize(category, _workContextAccessor.WorkContext.CurrentStore.Id)) && //limited to store
+                _aclService.Authorize(category, CurrentCustomer)) && //limited to customer groups
+               (showHidden || _aclService.Authorize(category, CurrentStore.Id)) && //limited to store
                !alreadyProcessedCategoryIds.Contains(category.Id))
         {
             result.Add(category);
@@ -301,8 +303,8 @@ public virtual IList<Category> GetCategoryBreadCrumb(Category category, IList<Ca
         while (category != null && //not null                
                (showHidden || category.Published) && //published
                (showHidden ||
-                _aclService.Authorize(category, _workContextAccessor.WorkContext.CurrentCustomer)) && //limited to customer groups
-               (showHidden || _aclService.Authorize(category, _workContextAccessor.WorkContext.CurrentStore.Id)) && //limited to store
+                _aclService.Authorize(category, CurrentCustomer)) && //limited to customer groups
+               (showHidden || _aclService.Authorize(category, CurrentStore.Id)) && //limited to store
                !alreadyProcessedCategoryIds.Contains(category.Id)) //avoid circular references
         {
             result.Add(category);