Improvements/code (#589)

* Remove redundant self-assignments
* Mark entity as non-nullable in LiteDBRepository.cs
* Improve null safety and readability in various files
* Refactor file reading to be asynchronous
* Make RedisMessageCacheManager.Clear method asynchronous
* Refactor CultureInfo validation logic in validators
* Improve URL validation logic in DomainHostValidator and StoreValidator

Author: KrzysztofPajak

src/Core/Grand.Data/LiteDb/LiteDBRepository.cs

@@ -226,8 +226,8 @@ private Task Update(T entity, UpdateBuilder<T> updateBuilder)
             propertyInfo?.SetValue(entity, item.Value);
         }
 
-        entity.UpdatedOnUtc = _auditInfoProvider.GetCurrentDateTime();
-        entity.UpdatedBy = _auditInfoProvider.GetCurrentUser();
+        entity!.UpdatedOnUtc = _auditInfoProvider.GetCurrentDateTime();
+        entity!.UpdatedBy = _auditInfoProvider.GetCurrentUser();
 
         Collection.Update(entity);
         return Task.CompletedTask;

src/Core/Grand.Infrastructure/Caching/Redis/RedisMessageCacheManager.cs

@@ -53,12 +53,11 @@ public override Task RemoveByPrefix(string prefix, bool publisher = true)
     ///     Clear cache
     /// </summary>
     /// <param name="publisher">publisher</param>
-    public override Task Clear(bool publisher = true)
+    public override async Task Clear(bool publisher = true)
     {
-        base.Clear();
+        await base.Clear(publisher);
         if (publisher)
-            _messageBus.PublishAsync(new MessageEvent { Key = "", MessageType = (int)MessageEventType.ClearCache });
+            await _messageBus.PublishAsync(new MessageEvent { Key = "", MessageType = (int)MessageEventType.ClearCache });
 
-        return Task.CompletedTask;
     }
 }

src/Modules/Grand.Module.Installer/Services/InstallDataLocaleResources.cs

@@ -12,7 +12,7 @@ protected virtual async Task InstallLocaleResources()
 
         //save resources
         var filePath = Path.Combine(_hostingEnvironment.ContentRootPath, "App_Data/Resources/DefaultLanguage.xml");
-        var localesXml = File.ReadAllText(filePath);
+        var localesXml = await File.ReadAllTextAsync(filePath);
 
         var xmlDoc = XmlExtensions.LanguageXmlDocument(localesXml);
 

src/Web/Grand.Web.Admin/Areas/Admin/Views/Shared/_AdminLayout.cshtml

@@ -176,7 +176,7 @@
                                     @if (await groupService.IsAdmin(currentCustomer))
                                     {
                                         <li>
-                                            <a href="@Url.Action("Edit", "Customer", new { currentCustomer.Id, area = Constants.AreaAdmin })">
+                                            <a href="@Url.Action("Edit", "Customer", new { currentCustomer!.Id, area = Constants.AreaAdmin })">
                                                 <i class="icon-user"></i> @Loc["Admin.Header.Profile"]
                                             </a>
                                         </li>

src/Web/Grand.Web.Admin/Controllers/OrderController.cs

@@ -945,7 +945,6 @@ public async Task<IActionResult> AddressEdit(OrderAddressModel model,
 
         //If we got this far, something failed, redisplay form
         model = await orderViewModelService.PrepareOrderAddressModel(order, address);
-        model.BillingAddress = model.BillingAddress;
         return View(model);
     }
 

src/Web/Grand.Web.Admin/Controllers/ProductController.cs

@@ -631,7 +631,6 @@ public async Task<IActionResult> RelatedProductAddPopup(ProductModel.AddRelatedP
 
         Error(ModelState);
         model = await _productViewModelService.PrepareRelatedProductModel();
-        model.ProductId = model.ProductId;
         return View(model);
     }
 
@@ -729,7 +728,6 @@ public async Task<IActionResult> SimilarProductAddPopup(ProductModel.AddSimilarP
 
         Error(ModelState);
         model = await _productViewModelService.PrepareSimilarProductModel();
-        model.ProductId = model.ProductId;
         return View(model);
     }
 
@@ -827,7 +825,6 @@ public async Task<IActionResult> BundleProductAddPopup(ProductModel.AddBundlePro
 
         Error(ModelState);
         model = await _productViewModelService.PrepareBundleProductModel();
-        model.ProductId = model.ProductId;
         return View(model);
     }
 
@@ -915,7 +912,6 @@ public async Task<IActionResult> CrossSellProductAddPopup(ProductModel.AddCrossS
 
         Error(ModelState);
         model = await _productViewModelService.PrepareCrossSellProductModel();
-        model.ProductId = model.ProductId;
         return View(model);
     }
 
@@ -1002,7 +998,6 @@ public async Task<IActionResult> RecommendedProductAddPopup(ProductModel.AddReco
 
         Error(ModelState);
         model = await _productViewModelService.PrepareRecommendedProductModel();
-        model.ProductId = model.ProductId;
         return View(model);
     }
 
@@ -1108,7 +1103,6 @@ public async Task<IActionResult> AssociatedProductAddPopup(ProductModel.AddAssoc
 
         Error(ModelState);
         model = await _productViewModelService.PrepareAssociatedProductModel();
-        model.ProductId = model.ProductId;
         return View(model);
     }
 

src/Web/Grand.Web.Admin/Services/ShipmentViewModelService.cs

@@ -104,7 +104,7 @@ public virtual async Task<ShipmentModel> PrepareShipmentModel(Shipment shipment,
         if (prepareProducts)
             foreach (var shipmentItem in shipment.ShipmentItems)
             {
-                var orderItem = order.OrderItems.FirstOrDefault(x => x.Id == shipmentItem.OrderItemId);
+                var orderItem = order?.OrderItems.FirstOrDefault(x => x.Id == shipmentItem.OrderItemId);
                 if (orderItem == null)
                     continue;
 
@@ -143,8 +143,7 @@ public virtual async Task<ShipmentModel> PrepareShipmentModel(Shipment shipment,
 
         if (prepareShipmentEvent && !string.IsNullOrEmpty(shipment.TrackingNumber))
         {
-            var srcm = _shippingService.LoadShippingRateCalculationProviderBySystemName(
-                order.ShippingRateProviderSystemName);
+            var srcm = _shippingService.LoadShippingRateCalculationProviderBySystemName(order?.ShippingRateProviderSystemName);
             if (srcm != null &&
                 srcm.IsShippingRateMethodActive(_shippingProviderSettings))
             {

src/Web/Grand.Web.Admin/Validators/Directory/CurrencyValidator.cs

@@ -37,10 +37,9 @@ public CurrencyValidator(
                 {
                     if (string.IsNullOrEmpty(x))
                         return true;
-                    //create a CultureInfo object
-                    //if "DisplayLocale" is wrong, then exception will be thrown
-                    new CultureInfo(x);
-                    return true;
+
+                    var culture = new CultureInfo(x);
+                    return culture != null;
                 }
                 catch
                 {

src/Web/Grand.Web.Admin/Validators/Localization/LanguageValidator.cs

@@ -21,8 +21,8 @@ public LanguageValidator(
                 try
                 {
                     //create a CultureInfo object
-                    new CultureInfo(x);
-                    return true;
+                    var culture = new CultureInfo(x);
+                    return culture != null;
                 }
                 catch
                 {

src/Web/Grand.Web.Admin/Validators/Stores/DomainHostValidator.cs

@@ -18,8 +18,8 @@ public DomainHostValidator(
         {
             try
             {
-                new Uri(x.Url);
-                return true;
+                var uri = new Uri(x.Url);
+                return uri != null;
             }
             catch
             {