test: unskip finalize request integration tests (#56)

# 🤖 Linear

Closes GRT-224
Closes GRT-249

Author: 0xJabberwock

test/integration/arbitrum/FinalizeRequest.t.sol

@@ -112,9 +112,6 @@ contract IntegrationFinalizeRequest is IntegrationBase {
     // Dispute the response
     bytes32 _disputeId = _disputeResponse(_requestId, _responseId);
 
-    // TODO: Request can be finalized without response here
-    // _finalizeRequest(_requestId, 0);
-
     // Revert if the request is finalized with response with unresolved dispute
     vm.expectRevert(IOracle.Oracle_InvalidFinalizedResponse.selector);
     _finalizeRequest(_requestId, _responseId);
@@ -161,9 +158,6 @@ contract IntegrationFinalizeRequest is IntegrationBase {
     // Dispute the response
     bytes32 _disputeId = _disputeResponse(_requestId, _responseId);
 
-    // TODO: Request can be finalized without response here
-    // _finalizeRequest(_requestId, 0);
-
     // Revert if the request is finalized with response with unresolved dispute
     vm.expectRevert(IOracle.Oracle_InvalidFinalizedResponse.selector);
     _finalizeRequest(_requestId, _responseId);
@@ -213,9 +207,6 @@ contract IntegrationFinalizeRequest is IntegrationBase {
     // Dispute the response
     bytes32 _disputeId = _disputeResponse(_requestId, _responseId);
 
-    // TODO: Request can be finalized without response here
-    // _finalizeRequest(_requestId, 0);
-
     // Revert if the request is finalized with response with unresolved dispute
     vm.expectRevert(IOracle.Oracle_InvalidFinalizedResponse.selector);
     _finalizeRequest(_requestId, _responseId);
@@ -258,9 +249,6 @@ contract IntegrationFinalizeRequest is IntegrationBase {
     // Dispute the response
     bytes32 _disputeId = _disputeResponse(_requestId, _responseId);
 
-    // TODO: Request can be finalized without response here
-    // _finalizeRequest(_requestId, 0);
-
     // Revert if the request is finalized with response with unresolved dispute
     vm.expectRevert(IOracle.Oracle_InvalidFinalizedResponse.selector);
     _finalizeRequest(_requestId, _responseId);
@@ -306,9 +294,6 @@ contract IntegrationFinalizeRequest is IntegrationBase {
     // Dispute the response
     bytes32 _disputeId = _disputeResponse(_requestId, _responseId);
 
-    // TODO: Request can be finalized without response here
-    // _finalizeRequest(_requestId, 0);
-
     // Revert if the request is finalized with response with unresolved dispute
     vm.expectRevert(IOracle.Oracle_InvalidFinalizedResponse.selector);
     _finalizeRequest(_requestId, _responseId);
@@ -352,13 +337,10 @@ contract IntegrationFinalizeRequest is IntegrationBase {
     // Pass the response deadline
     vm.warp(_requestCreatedAt + responseDeadline);
 
-    // TODO: What if the request is finalized without response, after a response has been disputed but before
-    //       its bond escalation settlement or dispute arbitration?
-
     // Finalize the request without response
     _finalizeRequest(_requestId, 0);
 
-    // Revert if the unfinalizable response has unresolved dispute
+    // Revert if the unfinalizable response has an unresolved dispute
     vm.expectRevert(IBondedResponseModule.BondedResponseModule_InvalidReleaseParameters.selector);
     _releaseUnfinalizableResponseBond(_requestId, _responseId);
 
@@ -375,18 +357,8 @@ contract IntegrationFinalizeRequest is IntegrationBase {
     // Settle the bond escalation
     _settleBondEscalation(_requestId, _responseId, _disputeId);
 
-    vm.skip(true); // TODO: How does the proposer release the response bond?
-
-    // Release the unfinalizable response bond
-    _releaseUnfinalizableResponseBond(_requestId, _responseId);
-
-    // Assert HorizonAccountingExtension::release
-    assertEq(horizonAccountingExtension.bondedForRequest(_proposer, _requestId), 0);
-    assertEq(horizonAccountingExtension.totalBonded(_proposer), 0);
-
-    // TODO: What if the release does not revert because the proposer had bonded multiple times for the same request?
-    // Revert if the unfinalizable response bond has already been released
-    vm.expectRevert();
+    // Revert if the unfinalizable response has a resolved dispute with `Won`
+    vm.expectRevert(IBondedResponseModule.BondedResponseModule_InvalidReleaseParameters.selector);
     _releaseUnfinalizableResponseBond(_requestId, _responseId);
   }
 
@@ -401,15 +373,13 @@ contract IntegrationFinalizeRequest is IntegrationBase {
     // Dispute the response
     bytes32 _disputeId = _disputeResponse(_requestId, _responseId);
 
-    // TODO: What if the request is finalized without response, after a response has been disputed but before
-    //       its bond escalation settlement or dispute arbitration?
     // Pass the response deadline
     vm.warp(_requestCreatedAt + responseDeadline);
 
     // Finalize the request without response
     _finalizeRequest(_requestId, 0);
 
-    // Revert if the unfinalizable response has unresolved dispute
+    // Revert if the unfinalizable response has an unresolved dispute
     vm.expectRevert(IBondedResponseModule.BondedResponseModule_InvalidReleaseParameters.selector);
     _releaseUnfinalizableResponseBond(_requestId, _responseId);
 
@@ -426,16 +396,16 @@ contract IntegrationFinalizeRequest is IntegrationBase {
     // Settle the bond escalation
     _settleBondEscalation(_requestId, _responseId, _disputeId);
 
-    vm.skip(true); // TODO: How does the proposer release the response bond?
-
     // Release the unfinalizable response bond
     _releaseUnfinalizableResponseBond(_requestId, _responseId);
 
     // Assert HorizonAccountingExtension::release
     assertEq(horizonAccountingExtension.bondedForRequest(_proposer, _requestId), 0);
     assertEq(horizonAccountingExtension.totalBonded(_proposer), 0);
 
-    // TODO: What if the release does not revert because the proposer had bonded multiple times for the same request?
+    // TODO: What if the release does not revert because the proposer had bonded multiple times for the same request,
+    //       either as proposer or disputer?
+
     // Revert if the unfinalizable response bond has already been released
     vm.expectRevert();
     _releaseUnfinalizableResponseBond(_requestId, _responseId);
@@ -455,13 +425,10 @@ contract IntegrationFinalizeRequest is IntegrationBase {
     // Pass the response deadline
     vm.warp(_requestCreatedAt + responseDeadline);
 
-    // TODO: What if the request is finalized without response, after a response has been disputed but before
-    //       its bond escalation settlement or dispute arbitration?
-
     // Finalize the request without response
     _finalizeRequest(_requestId, 0);
 
-    // Revert if the unfinalizable response has unresolved dispute
+    // Revert if the unfinalizable response has an unresolved dispute
     vm.expectRevert(IBondedResponseModule.BondedResponseModule_InvalidReleaseParameters.selector);
     _releaseUnfinalizableResponseBond(_requestId, _responseId);
 
@@ -479,18 +446,8 @@ contract IntegrationFinalizeRequest is IntegrationBase {
     // Arbitrate and resolve the dispute, and finalize the request without response
     _arbitrateDispute(_disputeId, IOracle.DisputeStatus.Won);
 
-    vm.skip(true); // TODO: How does the proposer release the response bond?
-
-    // Release the unfinalizable response bond
-    _releaseUnfinalizableResponseBond(_requestId, _responseId);
-
-    // Assert HorizonAccountingExtension::release
-    assertEq(horizonAccountingExtension.bondedForRequest(_proposer, _requestId), 0);
-    assertEq(horizonAccountingExtension.totalBonded(_proposer), 0);
-
-    // TODO: What if the release does not revert because the proposer had bonded multiple times for the same request?
-    // Revert if the unfinalizable response bond has already been released
-    vm.expectRevert();
+    // Revert if the unfinalizable response has a resolved dispute with `Won`
+    vm.expectRevert(IBondedResponseModule.BondedResponseModule_InvalidReleaseParameters.selector);
     _releaseUnfinalizableResponseBond(_requestId, _responseId);
   }
 
@@ -510,13 +467,10 @@ contract IntegrationFinalizeRequest is IntegrationBase {
     // Pass the response deadline
     vm.warp(_requestCreatedAt + responseDeadline);
 
-    // TODO: What if the request is finalized without response, after a response has been disputed but before
-    //       its bond escalation settlement or dispute arbitration?
-
     // Finalize the request without response
     _finalizeRequest(_requestId, 0);
 
-    // Revert if the unfinalizable response has unresolved dispute
+    // Revert if the unfinalizable response has an unresolved dispute
     vm.expectRevert(IBondedResponseModule.BondedResponseModule_InvalidReleaseParameters.selector);
     _releaseUnfinalizableResponseBond(_requestId, _responseId);
 
@@ -537,16 +491,16 @@ contract IntegrationFinalizeRequest is IntegrationBase {
     // Arbitrate and resolve the dispute, and finalize the request with response
     _arbitrateDispute(_disputeId, IOracle.DisputeStatus.Lost);
 
-    vm.skip(true); // TODO: How does the proposer release the response bond?
-
     // Release the unfinalizable response bond
     _releaseUnfinalizableResponseBond(_requestId, _responseId);
 
     // Assert HorizonAccountingExtension::release
     assertEq(horizonAccountingExtension.bondedForRequest(_proposer, _requestId), 0);
     assertEq(horizonAccountingExtension.totalBonded(_proposer), 0);
 
-    // TODO: What if the release does not revert because the proposer had bonded multiple times for the same request?
+    // TODO: What if the release does not revert because the proposer had bonded multiple times for the same request,
+    //       either as proposer or disputer?
+
     // Revert if the unfinalizable response bond has already been released
     vm.expectRevert();
     _releaseUnfinalizableResponseBond(_requestId, _responseId);
@@ -566,13 +520,10 @@ contract IntegrationFinalizeRequest is IntegrationBase {
     // Pass the response deadline
     vm.warp(_requestCreatedAt + responseDeadline);
 
-    // TODO: What if the request is finalized without response, after a response has been disputed but before
-    //       its bond escalation settlement or dispute arbitration?
-
     // Finalize the request without response
     _finalizeRequest(_requestId, 0);
 
-    // Revert if the unfinalizable response has unresolved dispute
+    // Revert if the unfinalizable response has an unresolved dispute
     vm.expectRevert(IBondedResponseModule.BondedResponseModule_InvalidReleaseParameters.selector);
     _releaseUnfinalizableResponseBond(_requestId, _responseId);
 
@@ -590,16 +541,16 @@ contract IntegrationFinalizeRequest is IntegrationBase {
     // Arbitrate and resolve the dispute, and finalize the request without response
     _arbitrateDispute(_disputeId, IOracle.DisputeStatus.NoResolution);
 
-    vm.skip(true); // TODO: How does the proposer release the response bond?
-
     // Release the unfinalizable response bond
     _releaseUnfinalizableResponseBond(_requestId, _responseId);
 
     // Assert HorizonAccountingExtension::release
     assertEq(horizonAccountingExtension.bondedForRequest(_proposer, _requestId), 0);
     assertEq(horizonAccountingExtension.totalBonded(_proposer), 0);
 
-    // TODO: What if the release does not revert because the proposer had bonded multiple times for the same request?
+    // TODO: What if the release does not revert because the proposer had bonded multiple times for the same request,
+    //       either as proposer or disputer?
+
     // Revert if the unfinalizable response bond has already been released
     vm.expectRevert();
     _releaseUnfinalizableResponseBond(_requestId, _responseId);